From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bV8dx-0004vj-Mm for qemu-devel@nongnu.org; Wed, 03 Aug 2016 22:44:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bV8dt-0005NE-HI for qemu-devel@nongnu.org; Wed, 03 Aug 2016 22:44:20 -0400 References: <1469633448-10692-1-git-send-email-brogers@suse.com> <579977B8.4090600@cn.fujitsu.com> <579F2FBA020000480012E89B@prv-mh.provo.novell.com> From: Cao jin Message-ID: <57A2ADCD.9040402@cn.fujitsu.com> Date: Thu, 4 Aug 2016 10:51:57 +0800 MIME-Version: 1.0 In-Reply-To: <579F2FBA020000480012E89B@prv-mh.provo.novell.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bruce Rogers , qemu-devel@nongnu.org Cc: anthony.perard@citrix.com, qemu-stable@nongnu.org On 08/02/2016 01:17 AM, Bruce Rogers wrote: > Hi Cao, > > > Upon re-reading your comment, I believe you are still thinking that > > it was right to use the error object in this context. The fact that this > > device has no pin interrupt is _not_ an error condition, and hence the > > use of error_setg() is not appropriate, and in fact causes Xen HVM PCI > > passthrough to fail, when it would otherwise succeed. > Hi bruce, Thanks for pointing it out, I didn't have much knowledge on this topic, but you words buys me, I am fine with the patch. > > This patch does not attempt to address any shortcomings with > > XEN_PT_LOG, since it is still in use in many other places in this source > > file. > > > hth, > > > Bruce > > -- Yours Sincerely, Cao jin