From: Daniel Borkmann <daniel@iogearbox.net>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, davem@davemloft.net,
alexei.starovoitov@gmail.com, tgraf@suug.ch,
netdev@vger.kernel.org
Subject: Re: [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store_bytes
Date: Thu, 04 Aug 2016 10:27:32 +0200 [thread overview]
Message-ID: <57A2FC74.7040701@iogearbox.net> (raw)
In-Reply-To: <201608041148.lftoFao6%fengguang.wu@intel.com>
On 08/04/2016 05:10 AM, kbuild test robot wrote:
> Hi Daniel,
>
> [auto build test WARNING on net/master]
>
> url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/Few-BPF-helper-related-checksum-fixes/20160804-085300
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
> include/linux/skbuff.h:940: warning: No description found for parameter 'sk'
>>> include/linux/skbuff.h:2864: warning: No description found for parameter 'off'
> include/net/sock.h:449: warning: No description found for parameter 'sk_padding'
> include/net/sock.h:449: warning: No description found for parameter 'sk_rcu'
> include/linux/netdevice.h:1889: warning: No description found for parameter 'prio_tc_map[TC_BITMASK + 1]'
>
> vim +/off +2864 include/linux/skbuff.h
>
> ^1da177e Linus Torvalds 2005-04-16 2848 }
> ^1da177e Linus Torvalds 2005-04-16 2849
> ^1da177e Linus Torvalds 2005-04-16 2850 /**
> ^1da177e Linus Torvalds 2005-04-16 2851 * skb_postpull_rcsum - update checksum for received skb after pull
> ^1da177e Linus Torvalds 2005-04-16 2852 * @skb: buffer to update
> ^1da177e Linus Torvalds 2005-04-16 2853 * @start: start of data before pull
> ^1da177e Linus Torvalds 2005-04-16 2854 * @len: length of data pulled
> ^1da177e Linus Torvalds 2005-04-16 2855 *
> ^1da177e Linus Torvalds 2005-04-16 2856 * After doing a pull on a received packet, you need to call this to
> 84fa7933 Patrick McHardy 2006-08-29 2857 * update the CHECKSUM_COMPLETE checksum, or set ip_summed to
> 84fa7933 Patrick McHardy 2006-08-29 2858 * CHECKSUM_NONE so that it can be recomputed from scratch.
> ^1da177e Linus Torvalds 2005-04-16 2859 */
Alright, I move the kdoc under skb_postpull_rcsum() and also add one for
skb_postpush_rcsum() in a v2 of this set. I didn't touch it because of -net
tree, but since someone might be using 'make htmldocs' it shouldn't generate
additional warnings. So, will respin with v2!
next prev parent reply other threads:[~2016-08-04 8:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 0:50 [PATCH net 0/3] Few BPF helper related checksum fixes Daniel Borkmann
2016-08-04 0:50 ` [PATCH net 1/3] bpf: also call skb_postpush_rcsum on xmit occasions Daniel Borkmann
2016-08-04 0:50 ` [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store_bytes Daniel Borkmann
2016-08-04 3:10 ` kbuild test robot
2016-08-04 8:27 ` Daniel Borkmann [this message]
2016-08-04 0:50 ` [PATCH net 3/3] bpf: fix checksum for vlan push/pop helper Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A2FC74.7040701@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=kbuild-all@01.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.