From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata() Date: Thu, 04 Aug 2016 17:40:05 +0900 Message-ID: <57A2FF65.80704@samsung.com> References: <1470290508-19178-1-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1470290508-19178-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Lin Huang Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, =?UTF-8?B?Iu2VqOuqheyjvCAoc2Ftc3VuZy4=?= =?UTF-8?B?Y29tKSI=?= , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-pm@vger.kernel.org KyBNeXVuZ2pvbyBIYW0sCgpIaSBMaW4gSHVhbmcsCgpPbiAyMDE264WEIDA47JuUIDA07J28IDE1 OjAxLCBMaW4gSHVhbmcgd3JvdGU6Cj4gdGhlcmUgZGVmaW5lIHR3byBkZXZmcmVxX2V2ZW50X2dl dF9kcnZkYXRhKCkgZnVuY3Rpb24gaW4gZGV2ZnJlcS1ldmVudC5oCj4gd2hlbiBkaXNhYmxlIENP TkZJR19QTV9ERVZGUkVRX0VWRU5ULCBpdCB3aWxsIGxlYWQgdG8gYnVpbGQgZmFpbC4gU28KPiBy ZW1vdmUgZGV2ZnJlcV9ldmVudF9nZXRfZHJ2ZGF0YSgpIGZ1bmN0aW9uLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IExpbiBIdWFuZyA8aGxAcm9jay1jaGlwcy5jb20+Cj4gLS0tCj4gIGluY2x1ZGUvbGlu dXgvZGV2ZnJlcS1ldmVudC5oIHwgNSAtLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBkZWxldGlv bnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9kZXZmcmVxLWV2ZW50LmggYi9p bmNsdWRlL2xpbnV4L2RldmZyZXEtZXZlbnQuaAo+IGluZGV4IDBhODNhMWUuLjRkYjAwYjAgMTAw NjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9kZXZmcmVxLWV2ZW50LmgKPiArKysgYi9pbmNsdWRl L2xpbnV4L2RldmZyZXEtZXZlbnQuaAo+IEBAIC0xNDgsMTEgKzE0OCw2IEBAIHN0YXRpYyBpbmxp bmUgaW50IGRldmZyZXFfZXZlbnRfcmVzZXRfZXZlbnQoc3RydWN0IGRldmZyZXFfZXZlbnRfZGV2 ICplZGV2KQo+ICAJcmV0dXJuIC1FSU5WQUw7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbmxpbmUgdm9p ZCAqZGV2ZnJlcV9ldmVudF9nZXRfZHJ2ZGF0YShzdHJ1Y3QgZGV2ZnJlcV9ldmVudF9kZXYgKmVk ZXYpCj4gLXsKPiAtCXJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+IC19Cj4gLQo+ICBzdGF0aWMg aW5saW5lIHN0cnVjdCBkZXZmcmVxX2V2ZW50X2RldiAqZGV2ZnJlcV9ldmVudF9nZXRfZWRldl9i eV9waGFuZGxlKAo+ICAJCQkJCXN0cnVjdCBkZXZpY2UgKmRldiwgaW50IGluZGV4KQo+ICB7Cj4g CgpMb29rcyBnb29kIHRvIG1lLgoKQWNrZWQtYnk6IENoYW53b28gQ2hvaSA8Y3cwMC5jaG9pQHNh bXN1bmcuY29tPgoKUmVnYXJkcywKQ2hhbndvbyBDaG9pCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGlu dXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932728AbcHDImG (ORCPT ); Thu, 4 Aug 2016 04:42:06 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:38765 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753896AbcHDIl2 convert rfc822-to-8bit (ORCPT ); Thu, 4 Aug 2016 04:41:28 -0400 X-AuditID: cbfee68d-f79286d000007a9a-d8-57a2ff6660d6 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <57A2FF65.80704@samsung.com> Date: Thu, 04 Aug 2016 17:40:05 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, =?UTF-8?B?Iu2VqOuqheyjvCAoc2Ftc3VuZy4=?= =?UTF-8?B?Y29tKSI=?= Subject: Re: [PATCH] PM / devfreq: event: remove duplicate devfreq_event_get_drvdata() References: <1470290508-19178-1-git-send-email-hl@rock-chips.com> In-reply-to: <1470290508-19178-1-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJIsWRmVeSWpSXmKPExsWyRsSkUDft/6Jwg7NnxCx+bDjFbHF51xw2 i8+9RxgtPj34z2xxu3EFmwOrx+Yl9R5/Z+1n8ejbsorR4/MmuQCWKC6blNSczLLUIn27BK6M i48esxXc4ahomfiXvYFxNnsXIyeHhICJxOwnHUwQtpjEhXvr2boYuTiEBFYwSszsaGSBKTp4 +xc7RGIWo8SnP51gHbwCghI/Jt8DK2IWUJeYNG8RM4QtIrGm9SdUXFti2cLXzBDNDxglujfu YIRo1pBo2trKCmKzCKhKzOk7CWazCWhJ7H9xgw3E5hdQlLj64zFQPQeHqECERPeJSpCwCFD4 47pfjCAzmQX2MEr0/tkJNlMYqObe5r9MEMumM0o8erEW7ApOASeJX1tOgiUkBE6xS9z71cII sVlA4tvkQywgGyQEZCU2HWCGeFlS4uCKGywTGCVmIXl0FpJHZyF5dBaSRxcwsqxiFE0tSC4o TkovMtQrTswtLs1L10vOz93ECIzR0/+e9e5gvH3A+hCjAAejEg9vgc6icCHWxLLiytxDjKZA F01klhJNzgcmgrySeENjMyMLUxNTYyNzSzMlcV5FqZ/BQgLpiSWp2ampBalF8UWlOanFhxiZ ODilGhhz4xMFgv8qtd6RNfvx9tuydGOnpit1KtFfFk2Ks3RU642rOxm6POqB/PorW1b9LrH8 tVt/V/id85UM/ccS5/+Z+tZlt5f6LO6qzce1DNb8enh6h0pZn/jB1nmq26Per7K6c978qPzz A4Wb1wnFKJfbSt7V6Ls6W/tRyuEn0z0sNI7dnHZrU/UTJZbijERDLeai4kQAnsrvrMwCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsVy+t9jQd20/4vCDVpPCVr82HCK2eLyrjls Fp97jzBafHrwn9niduMKNgdWj81L6j3+ztrP4tG3ZRWjx+dNcgEsUQ2MNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6dpgm hIa46VrANEbo+oYEwfUYGaCBhDWMGd9ObmApOMVR8efEBLYGxk72LkZODgkBE4mDt39B2WIS F+6tZ+ti5OIQEpjFKPHpTycTSIJXQFDix+R7LF2MHBzMAvISRy5lg4SZBdQlJs1bxAxR/4BR onvjDkaIeg2Jpq2trCA2i4CqxJy+k2A2m4CWxP4XN9hAbH4BRYmrPx4zgswUFYiQ6D5RCRIW AQp/XPeLEWQms8AeRonePzvBZgoD1dzb/JcJYtl0RolHL9aygCQ4BZwkfm05yTSBUXAWkltn Idw6C8mtCxiZVzFKpBYkFxQnpeca5aWW6xUn5haX5qXrJefnbmIEx/Qz6R2Mh3e5H2IU4GBU 4uG1mLgoXIg1say4MvcQowQHs5II7/e/QCHelMTKqtSi/Pii0pzU4kOMpkDPTmSWEk3OB6ab vJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB9DFxcEo1MO7OPK+Tvl0xQepN cu/xqiO6Im37Y6zYlQR/zxH9OlfVN9U93rPM81Z9tvT3G6IHgtsnqbkcCJsaczFF/VrhlPi/ e6dlK5ZUTXnjs+WXY8+N9Ibje82aol4+NVCoPn3hTuhFtz/S/zpuNQhlLpxTZLZRcarua8XJ nLcKnAp9/Dh105OOpccpK7EUZyQaajEXFScCAJb1dGb/AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Myungjoo Ham, Hi Lin Huang, On 2016년 08월 04일 15:01, Lin Huang wrote: > there define two devfreq_event_get_drvdata() function in devfreq-event.h > when disable CONFIG_PM_DEVFREQ_EVENT, it will lead to build fail. So > remove devfreq_event_get_drvdata() function. > > Signed-off-by: Lin Huang > --- > include/linux/devfreq-event.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/linux/devfreq-event.h b/include/linux/devfreq-event.h > index 0a83a1e..4db00b0 100644 > --- a/include/linux/devfreq-event.h > +++ b/include/linux/devfreq-event.h > @@ -148,11 +148,6 @@ static inline int devfreq_event_reset_event(struct devfreq_event_dev *edev) > return -EINVAL; > } > > -static inline void *devfreq_event_get_drvdata(struct devfreq_event_dev *edev) > -{ > - return ERR_PTR(-EINVAL); > -} > - > static inline struct devfreq_event_dev *devfreq_event_get_edev_by_phandle( > struct device *dev, int index) > { > Looks good to me. Acked-by: Chanwoo Choi Regards, Chanwoo Choi