From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVFsn-00078g-LW for qemu-devel@nongnu.org; Thu, 04 Aug 2016 06:28:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVFsj-0006zT-F9 for qemu-devel@nongnu.org; Thu, 04 Aug 2016 06:28:08 -0400 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]:33832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVFsj-0006zB-69 for qemu-devel@nongnu.org; Thu, 04 Aug 2016 06:28:05 -0400 Received: by mail-lf0-x242.google.com with SMTP id l69so14324850lfg.1 for ; Thu, 04 Aug 2016 03:28:04 -0700 (PDT) References: <1470146790-6168-1-git-send-email-paulinaszubarczyk@gmail.com> <1470146790-6168-2-git-send-email-paulinaszubarczyk@gmail.com> <20160804093813.GB32096@citrix.com> From: Paulina Szubarczyk Message-ID: <57A31891.9060106@gmail.com> Date: Thu, 4 Aug 2016 12:27:29 +0200 MIME-Version: 1.0 In-Reply-To: <20160804093813.GB32096@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 1/2] Interface for grant copy operation in libs. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Liu Cc: xen-devel@lists.xenproject.org, roger.pau@citrix.com, ian.jackson@eu.citrix.com, david.vrabel@citrix.com, sstabellini@kernel.org, anthony.perard@citrix.com, qemu-devel@nongnu.org On 08/04/2016 11:38 AM, Wei Liu wrote: > The code looks ok. I have two minor suggestions below. > > I would suggest changing the subject line to: > > libs/gnttab: introduce grant copy interface > > On Tue, Aug 02, 2016 at 04:06:29PM +0200, Paulina Szubarczyk wrote: >> In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) >> system call is invoked. In mini-os the operation is yet not >> implemented. For the OSs that does not implement gnttab the >> call of the grant copy operation causes abort. >> >> Signed-off-by: Paulina Szubarczyk >> --- >> Changes since v3: >> - revert to cast from xengnttab_grant_copy_segment_t >> to ioctl_gntdev_grant_copy. >> - added compile-time check to compare the libs >> xengnttab_grant_copy_segment_t with the ioctl structure. >> The patch relies on Wei patch introducing XENGNTTAB_BUILD_BUG_ON >> in libs/gnttab. > > I should resubmit that one soon. > >> --- > [...] >> + rc = ioctl(fd, IOCTL_GNTDEV_GRANT_COPY, ©); >> + if (rc) >> + { >> + GTERROR(xgt->logger, "ioctl GRANT COPY failed %d ", errno); >> + } > > Normally for a single statement you don't need {} around it. > > No need to resubmit just because of this patch. I can handle the subject > line change, fix up the style issue and change the comment according to > David's suggestion while committing if you don't object to any of them. > Ok, thank you. > I won't commit this patch right away though. I will wait until the QEMU > patch is acked because I would avoid committing things that have no > users. > > If you end up submitting another version you can make those changes > yourself. > > > Wei. > Paulina From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulina Szubarczyk Subject: Re: [PATCH v4 1/2] Interface for grant copy operation in libs. Date: Thu, 4 Aug 2016 12:27:29 +0200 Message-ID: <57A31891.9060106@gmail.com> References: <1470146790-6168-1-git-send-email-paulinaszubarczyk@gmail.com> <1470146790-6168-2-git-send-email-paulinaszubarczyk@gmail.com> <20160804093813.GB32096@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVFsF-0000wr-9m for xen-devel@lists.xenproject.org; Thu, 04 Aug 2016 10:27:35 +0000 Received: by mail-lf0-f66.google.com with SMTP id 33so14347765lfw.3 for ; Thu, 04 Aug 2016 03:27:33 -0700 (PDT) In-Reply-To: <20160804093813.GB32096@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Wei Liu Cc: sstabellini@kernel.org, ian.jackson@eu.citrix.com, qemu-devel@nongnu.org, david.vrabel@citrix.com, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org T24gMDgvMDQvMjAxNiAxMTozOCBBTSwgV2VpIExpdSB3cm90ZToKPiBUaGUgY29kZSBsb29rcyBv ay4gSSBoYXZlIHR3byBtaW5vciBzdWdnZXN0aW9ucyBiZWxvdy4KPgo+IEkgd291bGQgc3VnZ2Vz dCBjaGFuZ2luZyB0aGUgc3ViamVjdCBsaW5lIHRvOgo+Cj4gICAgbGlicy9nbnR0YWI6IGludHJv ZHVjZSBncmFudCBjb3B5IGludGVyZmFjZQo+Cj4gT24gVHVlLCBBdWcgMDIsIDIwMTYgYXQgMDQ6 MDY6MjlQTSArMDIwMCwgUGF1bGluYSBTenViYXJjenlrIHdyb3RlOgo+PiBJbiBhIGxpbnV4IHBh cnQgYW4gaW9jdGwoZ250ZGV2LCBJT0NUTF9HTlRERVZfR1JBTlRfQ09QWSwgLi4pCj4+IHN5c3Rl bSBjYWxsIGlzIGludm9rZWQuIEluIG1pbmktb3MgdGhlIG9wZXJhdGlvbiBpcyB5ZXQgbm90Cj4+ IGltcGxlbWVudGVkLiBGb3IgdGhlIE9TcyB0aGF0IGRvZXMgbm90IGltcGxlbWVudCBnbnR0YWIg dGhlCj4+IGNhbGwgb2YgdGhlIGdyYW50IGNvcHkgb3BlcmF0aW9uIGNhdXNlcyBhYm9ydC4KPj4K Pj4gU2lnbmVkLW9mZi1ieTogUGF1bGluYSBTenViYXJjenlrIDxwYXVsaW5hc3p1YmFyY3p5a0Bn bWFpbC5jb20+Cj4+IC0tLQo+PiBDaGFuZ2VzIHNpbmNlIHYzOgo+PiAtIHJldmVydCB0byBjYXN0 IGZyb20geGVuZ250dGFiX2dyYW50X2NvcHlfc2VnbWVudF90Cj4+ICAgIHRvIGlvY3RsX2dudGRl dl9ncmFudF9jb3B5Lgo+PiAtIGFkZGVkIGNvbXBpbGUtdGltZSBjaGVjayB0byBjb21wYXJlIHRo ZSBsaWJzCj4+ICAgIHhlbmdudHRhYl9ncmFudF9jb3B5X3NlZ21lbnRfdCB3aXRoIHRoZSBpb2N0 bCBzdHJ1Y3R1cmUuCj4+ICAgIFRoZSBwYXRjaCByZWxpZXMgb24gV2VpIHBhdGNoIGludHJvZHVj aW5nIFhFTkdOVFRBQl9CVUlMRF9CVUdfT04KPj4gICAgaW4gbGlicy9nbnR0YWIuCj4KPiBJIHNo b3VsZCByZXN1Ym1pdCB0aGF0IG9uZSBzb29uLgo+Cj4+IC0tLQo+IFsuLi5dCj4+ICsgICAgcmMg PSBpb2N0bChmZCwgSU9DVExfR05UREVWX0dSQU5UX0NPUFksICZjb3B5KTsKPj4gKyAgICBpZiAo cmMpCj4+ICsgICAgewo+PiArICAgICAgICBHVEVSUk9SKHhndC0+bG9nZ2VyLCAiaW9jdGwgR1JB TlQgQ09QWSBmYWlsZWQgJWQgIiwgZXJybm8pOwo+PiArICAgIH0KPgo+IE5vcm1hbGx5IGZvciBh IHNpbmdsZSBzdGF0ZW1lbnQgeW91IGRvbid0IG5lZWQge30gYXJvdW5kIGl0Lgo+Cj4gTm8gbmVl ZCB0byByZXN1Ym1pdCBqdXN0IGJlY2F1c2Ugb2YgdGhpcyBwYXRjaC4gSSBjYW4gaGFuZGxlIHRo ZSBzdWJqZWN0Cj4gbGluZSBjaGFuZ2UsICBmaXggdXAgdGhlIHN0eWxlIGlzc3VlIGFuZCBjaGFu Z2UgdGhlIGNvbW1lbnQgYWNjb3JkaW5nIHRvCj4gRGF2aWQncyBzdWdnZXN0aW9uIHdoaWxlIGNv bW1pdHRpbmcgaWYgeW91IGRvbid0IG9iamVjdCB0byBhbnkgb2YgdGhlbS4KPgoKT2ssIHRoYW5r IHlvdS4KCj4gSSB3b24ndCBjb21taXQgdGhpcyBwYXRjaCByaWdodCBhd2F5IHRob3VnaC4gSSB3 aWxsIHdhaXQgdW50aWwgdGhlIFFFTVUKPiBwYXRjaCBpcyBhY2tlZCBiZWNhdXNlIEkgd291bGQg YXZvaWQgY29tbWl0dGluZyB0aGluZ3MgdGhhdCBoYXZlIG5vCj4gdXNlcnMuCj4KPiBJZiB5b3Ug ZW5kIHVwIHN1Ym1pdHRpbmcgYW5vdGhlciB2ZXJzaW9uIHlvdSBjYW4gbWFrZSB0aG9zZSBjaGFu Z2VzCj4geW91cnNlbGYuCj4KPgo+IFdlaS4KPgoKUGF1bGluYQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4t ZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==