From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVPaS-0001PS-3B for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:49:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVPaM-0005AZ-IW for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:49:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVPaM-0005A1-CK for qemu-devel@nongnu.org; Thu, 04 Aug 2016 16:49:46 -0400 References: <1470224274-31522-1-git-send-email-armbru@redhat.com> <1470224274-31522-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <57A3AA69.1090906@redhat.com> Date: Thu, 4 Aug 2016 14:49:45 -0600 MIME-Version: 1.0 In-Reply-To: <1470224274-31522-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RVm0MjC0thOmHr88sl6wChhhBnuHvlltH" Subject: Re: [Qemu-devel] [PATCH 2/4] checkpatch: Fix newline detection in error_setg() & friends List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: "Jason J. Herne" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RVm0MjC0thOmHr88sl6wChhhBnuHvlltH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/03/2016 05:37 AM, Markus Armbruster wrote: > Commit 5d596c2's regexp assumes the error message string is the first > argument. Correct for error_report(), wrong for all the others. > Relax the regexp to match newline in anywhere. This might cause > additional false positives. Might, but those are still rare enough that we don't have to worry about it unless someone actually hits such a false positive. >=20 > While there, update the list of error_reporting functions. >=20 > Cc: Jason J. Herne > Signed-off-by: Markus Armbruster > --- > scripts/checkpatch.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --RVm0MjC0thOmHr88sl6wChhhBnuHvlltH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJXo6ppAAoJEKeha0olJ0Nqdq8IAIALlTbB69MzJEMThNp2AKvD hPO85BxxRuFa4npqtKOb6VDqQyRZMQPiZMLDhkitZXBZdI1vM3u6YCmwMVSvwaUp E4DDNrrlPRtp42K89UlshGscoB1Tgkh64nH9h8/Vg3b2xCvzT7DzDtSDc53rUXQ7 +u3PIvGO1/YQbMRLfPcaMh3FVoxUrUz6ZS7Gl2JMG5NCuG/BGNNQUoFDEXFLhTiL vDO8Sbe/2Do77bXrNWHGEU/mQqZeutysIF4/W5XSqwPp94lajOQCdFdahrIILSHU 2Q+8f2KEnYSuD5vHQN950PfikMJK5wkM17YIKb3El6UlDzTz9RjUrVibI3fhw9I= =ReA4 -----END PGP SIGNATURE----- --RVm0MjC0thOmHr88sl6wChhhBnuHvlltH--