From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available
Date: Mon, 8 Aug 2016 16:45:53 +0200 [thread overview]
Message-ID: <57A89B21.7020206@denx.de> (raw)
In-Reply-To: <CAEUhbmXfdh2SwctQQfYfEH0p1gPEkMF1MEkvoQpVhi1hP_5+pg@mail.gmail.com>
Hello Simon,
Am 07.08.2016 um 08:54 schrieb Bin Meng:
> On Sat, Aug 6, 2016 at 11:35 AM, Simon Glass <sjg@chromium.org> wrote:
>> If intel_i2c_bind() is called before relocation there is no BSS section
>> available. Use the data section instead, which is always available.
>>
>> A better fix might be to use global_data, perhaps a new member in
>> x86's struct arch_global_data. Comments welcome.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>> drivers/i2c/intel_i2c.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hmm... I see no i2c_bind() in mainline U-Boot drivers/i2c/intel_i2c.c
driver ?
Is this patch and also patch:
http://patchwork.ozlabs.org/patch/656335/
dependend on another patch(or patchserie) ?
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-08-08 14:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 3:35 [U-Boot] [PATCH 1/2] i2c: Drop redundant platform data setting in drivers Simon Glass
2016-08-06 3:35 ` [U-Boot] [PATCH 2/2] x86: i2c: Avoid using BSS before it is available Simon Glass
2016-08-07 6:54 ` Bin Meng
2016-08-08 14:45 ` Heiko Schocher [this message]
2016-08-08 21:44 ` Simon Glass
2016-08-09 5:37 ` Stefan Roese
2016-08-07 6:52 ` [U-Boot] [PATCH 1/2] i2c: Drop redundant platform data setting in drivers Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A89B21.7020206@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.