From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller Date: Wed, 10 Aug 2016 13:29:14 +0900 Message-ID: <57AAAD9A.1090201@samsung.com> References: <1470799604-12877-1-git-send-email-hl@rock-chips.com> <1470799604-12877-5-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1470799604-12877-5-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Lin Huang , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org Cc: tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, typ-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-pm@vger.kernel.org SGkgTGluLAoKT24gMjAxNuuFhCAwOOyblCAxMOydvCAxMjoyNiwgTGluIEh1YW5nIHdyb3RlOgo+ IFRoaXMgcGF0Y2ggYWRkcyB0aGUgZG9jdW1lbnRhdGlvbiBmb3Igcm9ja2NoaXAgZGZpIGRldmZy ZXEtZXZlbnQgZHJpdmVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IExpbiBIdWFuZyA8aGxAcm9jay1j aGlwcy5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2NToKPiAtTm9uZQo+IAo+IENoYW5nZXMgaW4g djQ6Cj4gLU5vbmUKPiAKPiBDaGFuZ2VzIGluIHYzOgo+IC1Ob25lCj4gCj4gQ2hhbmdlcyBpbiB2 MjoKPiAtTm9uZSAKPiAKPiBDaGFuZ2VzIGluIHYxOgo+IC1Ob25lCj4gCj4gIC4uLi9iaW5kaW5n cy9kZXZmcmVxL2V2ZW50L3JvY2tjaGlwLWRmaS50eHQgICAgICAgICAgfCAyMCArKysrKysrKysr KysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUg bW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RldmZyZXEvZXZl bnQvcm9ja2NoaXAtZGZpLnR4dAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZGV2ZnJlcS9ldmVudC9yb2NrY2hpcC1kZmkudHh0IGIvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RldmZyZXEvZXZlbnQvcm9ja2NoaXAtZGZpLnR4dAo+ IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMC4uYmY0MjI1NQo+IC0tLSAvZGV2 L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGV2ZnJlcS9l dmVudC9yb2NrY2hpcC1kZmkudHh0Cj4gQEAgLTAsMCArMSwyMCBAQAo+ICsKPiArKiBSb2NrY2hp cCByazMzOTkgREZJIGRldmljZQo+ICsKPiArUmVxdWlyZWQgcHJvcGVydGllczoKPiArLSBjb21w YXRpYmxlOiBNdXN0IGJlICJyb2NrY2hpcCxyazMzOTktZGZpIi4KPiArLSByZWc6IHBoeXNpY2Fs IGJhc2UgYWRkcmVzcyBvZiBlYWNoIERGSSBhbmQgbGVuZ3RoIG9mIG1lbW9yeSBtYXBwZWQgcmVn aW9uCj4gKy0gcm9ja2NoaXAscG11OiBwaGFuZGxlIHRvIHRoZSBzeXNjb24gbWFuYWdpbmcgdGhl ICJwbXUgZ2VuZXJhbCByZWdpc3RlciBmaWxlcyIKPiArLSBjbG9ja3M6IHBoYW5kbGVzIGZvciBj bG9jayBzcGVjaWZpZWQgaW4gImNsb2NrLW5hbWVzIiBwcm9wZXJ0eQo+ICstIGNsb2NrLW5hbWVz IDogdGhlIG5hbWUgb2YgY2xvY2sgdXNlZCBieSB0aGUgREZJLCBtdXN0IGJlICJwY2xrX2Rkcl9t b24iOwo+ICsKPiArRXhhbXBsZToKPiArCWRmaTogZGZpQDB4ZmY2MzAwMDAgewo+ICsJCXJlZyA9 IDwweDAwIDB4ZmY2MzAwMDAgMHgwMCAweDQwMDA+Owo+ICsJCWNvbXBhdGlibGUgPSAicm9ja2No aXAscmszMzk5LWRmaSI7CgpVc3VhbGx5LCB0aGUgY29tcGF0aWJsZSBpcyBmaXJzdCBlbnRyeSB3 aXRoaW4gRGV2aWNlLXRyZWUgbm9kZS4KCj4gKwkJcm9ja2NoaXAscG11ID0gPCZwbXVncmY+Owo+ ICsJCWNsb2NrcyA9IDwmY3J1IFBDTEtfRERSX01PTj47Cj4gKwkJY2xvY2stbmFtZXMgPSAicGNs a19kZHJfbW9uIjsKPiArCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsJfTsKPiArCj4gCgpMb29r cyBnb29kIHRvIG1lLiBKdXN0IEkgd2FudCB0byBjaGFuZ2UgdGhlIHNlcXVlbmNlCmJldHdlZW4g J2NvbXBhdGlibGUnIGFuZCAncmVnJyBwcm9wZXJ0eS4KCkFja2VkLWJ5OiBDaGFud29vIENob2kg PGN3MDAuY2hvaUBzYW1zdW5nLmNvbT4KClJlZ2FyZHMsCkNoYXdub28gQ2hvaQoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1h aWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 10 Aug 2016 13:29:14 +0900 Subject: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller In-Reply-To: <1470799604-12877-5-git-send-email-hl@rock-chips.com> References: <1470799604-12877-1-git-send-email-hl@rock-chips.com> <1470799604-12877-5-git-send-email-hl@rock-chips.com> Message-ID: <57AAAD9A.1090201@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Lin, On 2016? 08? 10? 12:26, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v5: > -None > > Changes in v4: > -None > > Changes in v3: > -None > > Changes in v2: > -None > > Changes in v1: > -None > > .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..bf42255 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,20 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi at 0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; Usually, the compatible is first entry within Device-tree node. > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + > Looks good to me. Just I want to change the sequence between 'compatible' and 'reg' property. Acked-by: Chanwoo Choi Regards, Chawnoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752602AbcHJEkY (ORCPT ); Wed, 10 Aug 2016 00:40:24 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:40006 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbcHJEkT (ORCPT ); Wed, 10 Aug 2016 00:40:19 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79cb6d000006cfe-2e-57aaad9b2e8f Content-transfer-encoding: 8BIT Message-id: <57AAAD9A.1090201@samsung.com> Date: Wed, 10 Aug 2016 13:29:14 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de Cc: myungjoo.ham@samsung.com, mark.yao@rock-chips.com, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, linux-rockchip@lists.infradead.org, kyungmin.park@samsung.com, linux-arm-kernel@lists.infradead.org, tixy@linaro.org, typ@rock-chips.com, sudeep.holla@arm.com, mark.rutland@arm.com, linux-pm@vger.kernel.org Subject: Re: [PATCH v5 4/8] Documentation: bindings: add dt documentation for dfi controller References: <1470799604-12877-1-git-send-email-hl@rock-chips.com> <1470799604-12877-5-git-send-email-hl@rock-chips.com> In-reply-to: <1470799604-12877-5-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmleLIzCtJLcpLzFFi42JZI2JSoDt77apwg0+POS16z51ksni1eQ+b xdllB9ksrnx9z2bx/9FrVosfG04xW5xtesNusenxNVaLy7vmsFl87j3CaPHpwX9mi6XXLzJZ 7JhygMni4ilXi9uNK9gsfpzpZrFYfmoHi8XC+ffZLWavrnMQ9lgzbw2jx/sbrewesxsusnhc 7utl8rhzbQ+bx/ZvD1g97ncfZ/LYvKTe4++s/SwefVtWMXpsvzaP2ePzJrkAnigum5TUnMyy 1CJ9uwSujON777MXzOerOPLgN3sD4y7uLkZODgkBE4m5Mx+zQNhiEhfurWfrYuTiEBJYwSjR tPYCC0zRjoNXGSESSxkl1j47yASS4BUQlPgx+R5QEQcHs4C8xJFL2SBhZgF1iUnzFjFD1D9g lNj45gQLRL2WRNve12wgNouAqsTGBUfB5rABxfe/uAEW5xdQlLj64zEjyExRgQiJ7hOVIGER ASOJs1/mM4HMZBY4wCwx/1c/O0hCWCBO4t2iZewQy84ySnS/uQS2jFPASWLX1V1gHRICHzgk Dj3YygKxWUDi2+RDYFdLCMhKbDrADPGlpMTBFTdYJjCKz0Ly2yyE32Yh+W0BI/MqRtHUguSC 4qT0IiO94sTc4tK8dL3k/NxNjMA0cvrfs74djDcPWB9iFOBgVOLh1chZFS7EmlhWXJl7iNEU 6IiJzFKiyfnAZJVXEm9obGZkYWpiamxkbmmmJM6bIPUzWEggPbEkNTs1tSC1KL6oNCe1+BAj EwenVANjdcPSzKZHb55VRMX3yF475/XWhqklsTPr7guOKR1CgnFnF+4XrrvodTH4xi6NB+yv ty0QT2LO5U77ffmN0UGxowvidkzdaXtJU8/c6908Jufctr8f/XUcpVYabd16YmKr8uy1e4ub CjMn3fW6xS3yZ8lhRh8ng/uHpH9emr8tU+b6jndzWH91K7EUZyQaajEXFScCAAP7LiAeAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBKsWRmVeSWpSXmKPExsVy+t9jAd3Za1eFG/QtZrLoPXeSyeLV5j1s FmeXHWSzuPL1PZvF/0evWS1+bDjFbHG26Q27xabH11gtLu+aw2bxufcIo8WnB/+ZLZZev8hk sWPKASaLi6dcLW43rmCz+HGmm8Vi+akdLBYL599nt5i9us5B2GPNvDWMHu9vtLJ7zG64yOJx ua+XyePOtT1sHtu/PWD1uN99nMlj85J6j7+z9rN49G1Zxeix/do8Zo/Pm+QCeKIaGG0yUhNT UosUUvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgH5UUihLzCkFCgUk Fhcr6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGYc33ufvWA+X8WRB7/ZGxh3cXcxcnJICJhI 7Dh4lRHCFpO4cG89WxcjF4eQwFJGibXPDjKBJHgFBCV+TL7H0sXIwcEsIC9x5FI2SJhZQF1i 0rxFzBD1DxglNr45wQJRryXRtvc1G4jNIqAqsXHBUbA5bEDx/S9ugMX5BRQlrv54zAgyU1Qg QqL7RCVIWETASOLsl/lMIDOZBQ4wS8z/1c8OkhAWiJN4t2gZO8Sys4wS3W8ugS3jFHCS2HV1 F9MERsFZSG6dhXDrLCS3LmBkXsUokVqQXFCclJ5rlJdarlecmFtcmpeul5yfu4kRnKqeSe9g PLzL/RCjAAejEg/vDs5V4UKsiWXFlbmHGCU4mJVEeA1XAYV4UxIrq1KL8uOLSnNSiw8xmgI9 O5FZSjQ5H5hG80riDY1NzIwsjcwNLYyMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwKhZ LGqTUe3zftGKbscpN06Kb1b/dNei9cOl8qj/sUsatugnRzglvjsTK/WP6xJrTWKXve7X47cb QhJML069erxijmnF680mz1/aNrz9YnHp26zHSybKKErfZ9N2VU+5sUJjpbHZi4AbhUeYFts+ d52zcUW9SsBEA12/5zOrSu1/39b7Ma/N3kyJpTgj0VCLuag4EQAHp37EawMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lin, On 2016년 08월 10일 12:26, Lin Huang wrote: > This patch adds the documentation for rockchip dfi devfreq-event driver. > > Signed-off-by: Lin Huang > --- > Changes in v5: > -None > > Changes in v4: > -None > > Changes in v3: > -None > > Changes in v2: > -None > > Changes in v1: > -None > > .../bindings/devfreq/event/rockchip-dfi.txt | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > new file mode 100644 > index 0000000..bf42255 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.txt > @@ -0,0 +1,20 @@ > + > +* Rockchip rk3399 DFI device > + > +Required properties: > +- compatible: Must be "rockchip,rk3399-dfi". > +- reg: physical base address of each DFI and length of memory mapped region > +- rockchip,pmu: phandle to the syscon managing the "pmu general register files" > +- clocks: phandles for clock specified in "clock-names" property > +- clock-names : the name of clock used by the DFI, must be "pclk_ddr_mon"; > + > +Example: > + dfi: dfi@0xff630000 { > + reg = <0x00 0xff630000 0x00 0x4000>; > + compatible = "rockchip,rk3399-dfi"; Usually, the compatible is first entry within Device-tree node. > + rockchip,pmu = <&pmugrf>; > + clocks = <&cru PCLK_DDR_MON>; > + clock-names = "pclk_ddr_mon"; > + status = "disabled"; > + }; > + > Looks good to me. Just I want to change the sequence between 'compatible' and 'reg' property. Acked-by: Chanwoo Choi Regards, Chawnoo Choi