From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299AbcHKLHa (ORCPT ); Thu, 11 Aug 2016 07:07:30 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:41751 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004AbcHKLH2 (ORCPT ); Thu, 11 Aug 2016 07:07:28 -0400 Message-ID: <57AC5C6B.2090608@osg.samsung.com> Date: Thu, 11 Aug 2016 12:07:23 +0100 From: Luis de Bethencourt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: Salah Triki , akpm@linux-foundation.org, viro@zeniv.linux.org.uk CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] befs: remove unnecessary initialization References: <8f7f9b76ead677bdc834867e549ea6c4d1c04ccd.1470867071.git.salah.triki@gmail.com> <9e9a627c26b78a273162f84afe4d2f6e22340e2c.1470867071.git.salah.triki@gmail.com> In-Reply-To: <9e9a627c26b78a273162f84afe4d2f6e22340e2c.1470867071.git.salah.triki@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/16 23:12, Salah Triki wrote: > There is no need to init block, since it will be overwitten later by > iaddr2blockno(). > > Signed-off-by: Salah Triki > --- > fs/befs/io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/io.c b/fs/befs/io.c > index f9790f5..39d0dce 100644 > --- a/fs/befs/io.c > +++ b/fs/befs/io.c > @@ -27,7 +27,7 @@ struct buffer_head * > befs_bread_iaddr(struct super_block *sb, befs_inode_addr iaddr) > { > struct buffer_head *bh; > - befs_blocknr_t block = 0; > + befs_blocknr_t block; > > befs_debug(sb, "---> Enter %s " > "[%u, %hu, %hu]", __func__, iaddr.allocation_group, > Applied and merged to: https://github.com/luisbg/linux-befs/commits/for-next Thanks Salah :) Luis