From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH 6/6] i2c: tegra: Add pinctrl support Date: Thu, 11 Aug 2016 20:31:40 +0530 Message-ID: <57AC9354.1080603@nvidia.com> References: <1470910620-9898-1-git-send-email-jonathanh@nvidia.com> <1470910620-9898-7-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1470910620-9898-7-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter , Wolfram Sang , Stephen Warren , Thierry Reding , Alexandre Courbot Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Thursday 11 August 2016 03:47 PM, Jon Hunter wrote: > On Tegra124/132 the pins for I2C6 are shared with the Display Port AUX > (DPAUX) channel and on Tegra210 the pins for I2C4 and I2C6 are shared > with DPAUX1 and DPAUX0, respectively. The multiplexing of the pins is > handled by a register in the DPAUX and so the Tegra DPAUX driver has > been updated to register a pinctrl device for managing these pins. > > The pins for these particular I2C devices are bound to the I2C device > prior to probing. However, these I2C devices are in a different power > partition to the DPAUX devices that own the pins. Hence, it is desirable > to place the pins in the 'idle' state and allow the DPAUX power > partition to switch off, when these I2C devices is not in use. > Therefore, add calls to place the I2C pins in the 'default' and 'idle' > states when the I2C device is runtime resumed and suspended, > respectively. > > Please note that the pinctrl functions that set the state of the pins > check to see if the devices has pins associated and will return zero > if they do not. Therefore, it is safe to call these pinctrl functions > even for I2C devices that do not have any pins associated. > > Signed-off-by: Jon Hunter > Acked-by: Laxman Dewangan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611AbcHKPRi (ORCPT ); Thu, 11 Aug 2016 11:17:38 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:5152 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbcHKPRf (ORCPT ); Thu, 11 Aug 2016 11:17:35 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 11 Aug 2016 08:14:03 -0700 Message-ID: <57AC9354.1080603@nvidia.com> Date: Thu, 11 Aug 2016 20:31:40 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jon Hunter , Wolfram Sang , Stephen Warren , Thierry Reding , Alexandre Courbot CC: , , Subject: Re: [PATCH 6/6] i2c: tegra: Add pinctrl support References: <1470910620-9898-1-git-send-email-jonathanh@nvidia.com> <1470910620-9898-7-git-send-email-jonathanh@nvidia.com> In-Reply-To: <1470910620-9898-7-git-send-email-jonathanh@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 11 August 2016 03:47 PM, Jon Hunter wrote: > On Tegra124/132 the pins for I2C6 are shared with the Display Port AUX > (DPAUX) channel and on Tegra210 the pins for I2C4 and I2C6 are shared > with DPAUX1 and DPAUX0, respectively. The multiplexing of the pins is > handled by a register in the DPAUX and so the Tegra DPAUX driver has > been updated to register a pinctrl device for managing these pins. > > The pins for these particular I2C devices are bound to the I2C device > prior to probing. However, these I2C devices are in a different power > partition to the DPAUX devices that own the pins. Hence, it is desirable > to place the pins in the 'idle' state and allow the DPAUX power > partition to switch off, when these I2C devices is not in use. > Therefore, add calls to place the I2C pins in the 'default' and 'idle' > states when the I2C device is runtime resumed and suspended, > respectively. > > Please note that the pinctrl functions that set the state of the pins > check to see if the devices has pins associated and will return zero > if they do not. Therefore, it is safe to call these pinctrl functions > even for I2C devices that do not have any pins associated. > > Signed-off-by: Jon Hunter > Acked-by: Laxman Dewangan