From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Date: Fri, 12 Aug 2016 10:14:39 +0000 Subject: Re: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool Message-Id: <57AD9EBF.3020104@ti.com> List-Id: References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-8-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Friday 05 August 2016 04:55 PM, Julia Lawall wrote: > Use of_property_read_bool to check for the existence of a property. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e1,e2,x; > @@ > - if (of_get_property(e1,e2,NULL)) > - x = true; > - else > - x = false; > + x = of_property_read_bool(e1,e2); > // > > Signed-off-by: Julia Lawall merged, thanks. -Kishon > > --- > v2: special case for propagating true and false > > drivers/phy/phy-qcom-ufs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c > index 107cb57..18a5b49 100644 > --- a/drivers/phy/phy-qcom-ufs.c > +++ b/drivers/phy/phy-qcom-ufs.c > @@ -283,10 +283,8 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy, > err = 0; > } > snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name); > - if (of_get_property(dev->of_node, prop_name, NULL)) > - vreg->is_always_on = true; > - else > - vreg->is_always_on = false; > + vreg->is_always_on = of_property_read_bool(dev->of_node, > + prop_name); > } > > if (!strcmp(name, "vdda-pll")) { > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752661AbcHLKDS (ORCPT ); Fri, 12 Aug 2016 06:03:18 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46334 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752504AbcHLKCs (ORCPT ); Fri, 12 Aug 2016 06:02:48 -0400 Subject: Re: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool To: Julia Lawall References: <1470387411-15879-1-git-send-email-Julia.Lawall@lip6.fr> <1470387411-15879-8-git-send-email-Julia.Lawall@lip6.fr> CC: , From: Kishon Vijay Abraham I Message-ID: <57AD9EBF.3020104@ti.com> Date: Fri, 12 Aug 2016 15:32:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 05 August 2016 04:55 PM, Julia Lawall wrote: > Use of_property_read_bool to check for the existence of a property. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e1,e2,x; > @@ > - if (of_get_property(e1,e2,NULL)) > - x = true; > - else > - x = false; > + x = of_property_read_bool(e1,e2); > // > > Signed-off-by: Julia Lawall merged, thanks. -Kishon > > --- > v2: special case for propagating true and false > > drivers/phy/phy-qcom-ufs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c > index 107cb57..18a5b49 100644 > --- a/drivers/phy/phy-qcom-ufs.c > +++ b/drivers/phy/phy-qcom-ufs.c > @@ -283,10 +283,8 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy, > err = 0; > } > snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name); > - if (of_get_property(dev->of_node, prop_name, NULL)) > - vreg->is_always_on = true; > - else > - vreg->is_always_on = false; > + vreg->is_always_on = of_property_read_bool(dev->of_node, > + prop_name); > } > > if (!strcmp(name, "vdda-pll")) { >