From mboxrd@z Thu Jan 1 00:00:00 1970 From: xuwei5@hisilicon.com (Wei Xu) Date: Fri, 12 Aug 2016 14:34:10 +0100 Subject: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode In-Reply-To: References: <1470697426-16426-1-git-send-email-john.stultz@linaro.org> <1470697426-16426-3-git-send-email-john.stultz@linaro.org> <20160810043424.GH26240@tuxbot> Message-ID: <57ADD052.9030000@hisilicon.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi All, On 10/08/2016 05:58, John Stultz wrote: > On Tue, Aug 9, 2016 at 9:34 PM, Bjorn Andersson > wrote: >> On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote: >> >> [..] >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> [..] >>> memory at 0 { >>> device_type = "memory"; >>> reg = <0x00000000 0x00000000 0x00000000 0x05e00000>, >>> - <0x00000000 0x05f00000 0x00000000 0x00eff000>, >>> + <0x00000000 0x05f00000 0x00000000 0x00001000>, >>> + <0x00000000 0x05f02000 0x00000000 0x00efd000>, >>> <0x00000000 0x06e00000 0x00000000 0x0060f000>, >>> <0x00000000 0x07410000 0x00000000 0x36bf0000>; >>> }; >> >> As I said when talked about this, I don't think you should punch holes >> in the /memory node, but rather add these regions as no-map in a >> /reserved-memory node. But that's a unrelated matter. > > Yea. I need to sync w/ Wei and Guodong to see about reworking all of > those to use /reserved-memory, but for now I'd like to stay in sync w/ > how they have it setup. > Both are fine to me. I remember before we had a discussion [1]. How about we add these functions this time and clean the memory node in the future if needed? [1] http://patches.linaro.org/patch/54682/ Best Regards, Wei >>> >>> + reboot-mode-syscon at 5f01000 { >>> + compatible = "syscon", "simple-mfd"; >>> + reg = <0x0 0x05f01000 0x0 0x00001000>; >>> + >>> + reboot-mode at 0 { >> >> Drop the @0 > > Will do. > > >> >> Other than that: >> Acked-by: Bjorn Andersson > > Thanks! > -john > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Xu Subject: Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode Date: Fri, 12 Aug 2016 14:34:10 +0100 Message-ID: <57ADD052.9030000@hisilicon.com> References: <1470697426-16426-1-git-send-email-john.stultz@linaro.org> <1470697426-16426-3-git-send-email-john.stultz@linaro.org> <20160810043424.GH26240@tuxbot> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: John Stultz , Bjorn Andersson Cc: lkml , Andy Yan , Haojian Zhuang , Guodong Xu , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi All, On 10/08/2016 05:58, John Stultz wrote: > On Tue, Aug 9, 2016 at 9:34 PM, Bjorn Andersson > wrote: >> On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote: >> >> [..] >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> [..] >>> memory@0 { >>> device_type = "memory"; >>> reg = <0x00000000 0x00000000 0x00000000 0x05e00000>, >>> - <0x00000000 0x05f00000 0x00000000 0x00eff000>, >>> + <0x00000000 0x05f00000 0x00000000 0x00001000>, >>> + <0x00000000 0x05f02000 0x00000000 0x00efd000>, >>> <0x00000000 0x06e00000 0x00000000 0x0060f000>, >>> <0x00000000 0x07410000 0x00000000 0x36bf0000>; >>> }; >> >> As I said when talked about this, I don't think you should punch holes >> in the /memory node, but rather add these regions as no-map in a >> /reserved-memory node. But that's a unrelated matter. > > Yea. I need to sync w/ Wei and Guodong to see about reworking all of > those to use /reserved-memory, but for now I'd like to stay in sync w/ > how they have it setup. > Both are fine to me. I remember before we had a discussion [1]. How about we add these functions this time and clean the memory node in the future if needed? [1] http://patches.linaro.org/patch/54682/ Best Regards, Wei >>> >>> + reboot-mode-syscon@5f01000 { >>> + compatible = "syscon", "simple-mfd"; >>> + reg = <0x0 0x05f01000 0x0 0x00001000>; >>> + >>> + reboot-mode@0 { >> >> Drop the @0 > > Will do. > > >> >> Other than that: >> Acked-by: Bjorn Andersson > > Thanks! > -john > > . > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbcHLNek (ORCPT ); Fri, 12 Aug 2016 09:34:40 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:64030 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbcHLNei (ORCPT ); Fri, 12 Aug 2016 09:34:38 -0400 Subject: Re: [RFC][PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode To: John Stultz , Bjorn Andersson References: <1470697426-16426-1-git-send-email-john.stultz@linaro.org> <1470697426-16426-3-git-send-email-john.stultz@linaro.org> <20160810043424.GH26240@tuxbot> CC: lkml , Andy Yan , Haojian Zhuang , Guodong Xu , Rob Herring , Mark Rutland , Catalin Marinas , "Will Deacon" , "linux-arm-kernel@lists.infradead.org" , From: Wei Xu Message-ID: <57ADD052.9030000@hisilicon.com> Date: Fri, 12 Aug 2016 14:34:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.181.152] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.57ADD067.00E5,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b840814b15c0bada2f41fd491d374ffd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi All, On 10/08/2016 05:58, John Stultz wrote: > On Tue, Aug 9, 2016 at 9:34 PM, Bjorn Andersson > wrote: >> On Mon 08 Aug 16:03 PDT 2016, John Stultz wrote: >> >> [..] >>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts >> [..] >>> memory@0 { >>> device_type = "memory"; >>> reg = <0x00000000 0x00000000 0x00000000 0x05e00000>, >>> - <0x00000000 0x05f00000 0x00000000 0x00eff000>, >>> + <0x00000000 0x05f00000 0x00000000 0x00001000>, >>> + <0x00000000 0x05f02000 0x00000000 0x00efd000>, >>> <0x00000000 0x06e00000 0x00000000 0x0060f000>, >>> <0x00000000 0x07410000 0x00000000 0x36bf0000>; >>> }; >> >> As I said when talked about this, I don't think you should punch holes >> in the /memory node, but rather add these regions as no-map in a >> /reserved-memory node. But that's a unrelated matter. > > Yea. I need to sync w/ Wei and Guodong to see about reworking all of > those to use /reserved-memory, but for now I'd like to stay in sync w/ > how they have it setup. > Both are fine to me. I remember before we had a discussion [1]. How about we add these functions this time and clean the memory node in the future if needed? [1] http://patches.linaro.org/patch/54682/ Best Regards, Wei >>> >>> + reboot-mode-syscon@5f01000 { >>> + compatible = "syscon", "simple-mfd"; >>> + reg = <0x0 0x05f01000 0x0 0x00001000>; >>> + >>> + reboot-mode@0 { >> >> Drop the @0 > > Will do. > > >> >> Other than that: >> Acked-by: Bjorn Andersson > > Thanks! > -john > > . >