From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/20] drm/i915: Optimization to reduce the sampling time of GuC log buffer Date: Fri, 12 Aug 2016 15:42:28 +0100 Message-ID: <57ADE054.2030501@linux.intel.com> References: <1470983123-22127-1-git-send-email-akash.goel@intel.com> <1470983123-22127-12-git-send-email-akash.goel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A5536E04F for ; Fri, 12 Aug 2016 14:42:30 +0000 (UTC) In-Reply-To: <1470983123-22127-12-git-send-email-akash.goel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: akash.goel@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA4LzE2IDA3OjI1LCBha2FzaC5nb2VsQGludGVsLmNvbSB3cm90ZToKPiBGcm9tOiBB a2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPgo+IEd1QyBmaXJtd2FyZSBzZW5kcyBh biBpbnRlcnJ1cHQgdG8gZmx1c2ggdGhlIGxvZyBidWZmZXIgd2hlbiBpdCBiZWNvbWVzCj4gaGFs ZiBmdWxsLCBzbyBEcml2ZXIgZG9lc24ndCByZWFsbHkgbmVlZCB0byBzYW1wbGUgdGhlIGNvbXBs ZXRlIGJ1ZmZlcgo+IGFuZCBjYW4ganVzdCBjb3B5IG9ubHkgdGhlIG5ld2x5IHdyaXR0ZW4gZGF0 YSBieSBHdUMgaW50byB0aGUgbG9jYWwKPiBidWZmZXIsIGkuZS4gYXMgcGVyIHRoZSByZWFkICYg d3JpdGUgcG9pbnRlciB2YWx1ZXMuCj4gTW9yZW92ZXIgdGhlIGZsdXNoIGludGVycnVwdCB3b3Vs ZCBnZW5lcmFsbHkgY29tZSBmb3Igb25lIHR5cGUgb2YgbG9nCj4gYnVmZmVyLCB3aGVuIGl0IGJl Y29tZXMgaGFsZiBmdWxsLCBzbyBhdCB0aGF0IHRpbWUgdGhlIG90aGVyIDIgdHlwZXMgb2YKPiBs b2cgYnVmZmVyIHdvdWxkIGNvbXBhcmF0aXZlbHkgaGF2ZSBtdWNoIGxlc3NlciB1bnJlYWQgZGF0 YSBpbiB0aGVtLgo+IEluIGNhc2Ugb2Ygb3ZlcmZsb3cgcmVwb3J0ZWQgYnkgR3VDLCBEcml2ZXIg ZG8gbmVlZCB0byBjb3B5IHRoZSBlbnRpcmUKPiBidWZmZXIgYXMgdGhlIHdob2xlIGJ1ZmZlciB3 b3VsZCBjb250YWluIHRoZSB1bnJlYWQgZGF0YS4KPgo+IHYyOiBSZWJhc2UuCj4KPiBTaWduZWQt b2ZmLWJ5OiBBa2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDQwICsrKysrKysrKysrKysr KysrKysrKysrKystLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDYg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n dWNfc3VibWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jCj4gaW5kZXggMWNhMTg2Ni4uOGUwZjM2MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPiBAQCAtODg5LDcgKzg4OSw4IEBAIHN0YXRpYyB2b2lk IGd1Y19yZWFkX3VwZGF0ZV9sb2dfYnVmZmVyKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAlz dHJ1Y3QgZ3VjX2xvZ19idWZmZXJfc3RhdGUgKmxvZ19idWZmZXJfc3RhdGUsICpsb2dfYnVmZmVy X3NuYXBzaG90X3N0YXRlOwo+ICAgCXN0cnVjdCBndWNfbG9nX2J1ZmZlcl9zdGF0ZSBsb2dfYnVm ZmVyX3N0YXRlX2xvY2FsOwo+ICAgCXZvaWQgKnNyY19kYXRhX3B0ciwgKmRzdF9kYXRhX3B0cjsK PiAtCXUzMiBpLCBidWZmZXJfc2l6ZTsKPiArCWJvb2wgbmV3X292ZXJmbG93Owo+ICsJdTMyIGks IGJ1ZmZlcl9zaXplLCByZWFkX29mZnNldCwgd3JpdGVfb2Zmc2V0LCBieXRlc190b19jb3B5Owo+ Cj4gICAJaWYgKCFndWMtPmxvZy5idWZfYWRkcikKPiAgIAkJcmV0dXJuOwo+IEBAIC05MTIsMTAg KzkxMywxMyBAQCBzdGF0aWMgdm9pZCBndWNfcmVhZF91cGRhdGVfbG9nX2J1ZmZlcihzdHJ1Y3Qg aW50ZWxfZ3VjICpndWMpCj4gICAJCW1lbWNweSgmbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbCwgbG9n X2J1ZmZlcl9zdGF0ZSwKPiAgIAkJCQlzaXplb2Yoc3RydWN0IGd1Y19sb2dfYnVmZmVyX3N0YXRl KSk7Cj4gICAJCWJ1ZmZlcl9zaXplID0gbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbC5zaXplOwo+ICsJ CXJlYWRfb2Zmc2V0ID0gbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbC5yZWFkX3B0cjsKPiArCQl3cml0 ZV9vZmZzZXQgPSBsb2dfYnVmZmVyX3N0YXRlX2xvY2FsLnNhbXBsZWRfd3JpdGVfcHRyOwo+Cj4g ICAJCWd1Yy0+bG9nLmZsdXNoX2NvdW50W2ldICs9IGxvZ19idWZmZXJfc3RhdGVfbG9jYWwuZmx1 c2hfdG9fZmlsZTsKPiAgIAkJaWYgKGxvZ19idWZmZXJfc3RhdGVfbG9jYWwuYnVmZmVyX2Z1bGxf Y250ICE9Cj4gICAJCQkJCWd1Yy0+bG9nLnByZXZfb3ZlcmZsb3dfY291bnRbaV0pIHsKCldyb25n IGFsaWdubWVudC4gWW91IGNhbiB0cnkgY2hlY2twYXRjaC5wbCBmb3IgYWxsIG9mIHRob3NlLgoK PiArCQkJbmV3X292ZXJmbG93ID0gMTsKCnRydWUvZmFsc2Ugc2luY2UgaXQgaXMgYSBib29sCgo+ ICAgCQkJZ3VjLT5sb2cudG90YWxfb3ZlcmZsb3dfY291bnRbaV0gKz0KPiAgIAkJCQkobG9nX2J1 ZmZlcl9zdGF0ZV9sb2NhbC5idWZmZXJfZnVsbF9jbnQgLQo+ICAgCQkJCSBndWMtPmxvZy5wcmV2 X292ZXJmbG93X2NvdW50W2ldKTsKPiBAQCAtOTI5LDcgKzkzMyw4IEBAIHN0YXRpYyB2b2lkIGd1 Y19yZWFkX3VwZGF0ZV9sb2dfYnVmZmVyKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAkJCWd1 Yy0+bG9nLnByZXZfb3ZlcmZsb3dfY291bnRbaV0gPQo+ICAgCQkJCQlsb2dfYnVmZmVyX3N0YXRl X2xvY2FsLmJ1ZmZlcl9mdWxsX2NudDsKPiAgIAkJCURSTV9FUlJPUl9SQVRFTElNSVRFRCgiR3VD IGxvZyBidWZmZXIgb3ZlcmZsb3dcbiIpOwo+IC0JCX0KPiArCQl9IGVsc2UKPiArCQkJbmV3X292 ZXJmbG93ID0gMDsKPgo+ICAgCQlpZiAobG9nX2J1ZmZlcl9zbmFwc2hvdF9zdGF0ZSkgewo+ICAg CQkJLyogRmlyc3QgY29weSB0aGUgc3RhdGUgc3RydWN0dXJlIGluIGxvY2FsIGJ1ZmZlciAqLwo+ IEBAIC05NDEsMTMgKzk0NiwzNyBAQCBzdGF0aWMgdm9pZCBndWNfcmVhZF91cGRhdGVfbG9nX2J1 ZmZlcihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAJCQkgKiBmb3IgY29uc2lzdGVuY3kgc2V0 IHRoZSB3cml0ZSBwb2ludGVyIHZhbHVlIHRvIHNhbWUKPiAgIAkJCSAqIHZhbHVlIG9mIHNhbXBs ZWRfd3JpdGVfcHRyIGluIHRoZSBzbmFwc2hvdCBidWZmZXIuCj4gICAJCQkgKi8KPiAtCQkJbG9n X2J1ZmZlcl9zbmFwc2hvdF9zdGF0ZS0+d3JpdGVfcHRyID0KPiAtCQkJCWxvZ19idWZmZXJfc25h cHNob3Rfc3RhdGUtPnNhbXBsZWRfd3JpdGVfcHRyOwo+ICsJCQlsb2dfYnVmZmVyX3NuYXBzaG90 X3N0YXRlLT53cml0ZV9wdHIgPSB3cml0ZV9vZmZzZXQ7Cj4KPiAgIAkJCWxvZ19idWZmZXJfc25h cHNob3Rfc3RhdGUrKzsKPgo+ICAgCQkJLyogTm93IGNvcHkgdGhlIGFjdHVhbCBsb2dzICovCj4g ICAJCQltZW1jcHkoZHN0X2RhdGFfcHRyLCBzcmNfZGF0YV9wdHIsIGJ1ZmZlcl9zaXplKTsKClRo ZSBjb25mdXNpbmcgYml0IC0gdGhlIG1lbWNweSBhYm92ZSBzdGlsbCBjb3BpZXMgdGhlIHdob2xl IGJ1ZmZlciwgbm8/Cgo+ICsJCQlpZiAodW5saWtlbHkobmV3X292ZXJmbG93KSkgewo+ICsJCQkJ LyogY29weSB0aGUgd2hvbGUgYnVmZmVyIGluIGNhc2Ugb2Ygb3ZlcmZsb3cgKi8KPiArCQkJCXJl YWRfb2Zmc2V0ID0gMDsKPiArCQkJCXdyaXRlX29mZnNldCA9IGJ1ZmZlcl9zaXplOwo+ICsJCQl9 IGVsc2UgaWYgKHVubGlrZWx5KChyZWFkX29mZnNldCA+IGJ1ZmZlcl9zaXplKSB8fAo+ICsJCQkJ CSAgICAod3JpdGVfb2Zmc2V0ID4gYnVmZmVyX3NpemUpKSkgewo+ICsJCQkJRFJNX0VSUk9SKCJp bnZhbGlkIGxvZyBidWZmZXIgc3RhdGVcbiIpOwo+ICsJCQkJLyogY29weSB3aG9sZSBidWZmZXIg YXMgb2Zmc2V0cyBhcmUgdW5yZWxpYWJsZSAqLwo+ICsJCQkJcmVhZF9vZmZzZXQgPSAwOwo+ICsJ CQkJd3JpdGVfb2Zmc2V0ID0gYnVmZmVyX3NpemU7Cj4gKwkJCX0KPiArCj4gKwkJCS8qIEp1c3Qg Y29weSB0aGUgbmV3bHkgd3JpdHRlbiBkYXRhICovCj4gKwkJCWlmIChyZWFkX29mZnNldCA8PSB3 cml0ZV9vZmZzZXQpIHsKPiArCQkJCWJ5dGVzX3RvX2NvcHkgPSB3cml0ZV9vZmZzZXQgLSByZWFk X29mZnNldDsKPiArCQkJCW1lbWNweShkc3RfZGF0YV9wdHIgKyByZWFkX29mZnNldCwKPiArCQkJ CSAgICAgc3JjX2RhdGFfcHRyICsgcmVhZF9vZmZzZXQsIGJ5dGVzX3RvX2NvcHkpOwo+ICsJCQl9 IGVsc2Ugewo+ICsJCQkJYnl0ZXNfdG9fY29weSA9IGJ1ZmZlcl9zaXplIC0gcmVhZF9vZmZzZXQ7 Cj4gKwkJCQltZW1jcHkoZHN0X2RhdGFfcHRyICsgcmVhZF9vZmZzZXQsCj4gKwkJCQkgICAgIHNy Y19kYXRhX3B0ciArIHJlYWRfb2Zmc2V0LCBieXRlc190b19jb3B5KTsKPiArCj4gKwkJCQlieXRl c190b19jb3B5ID0gd3JpdGVfb2Zmc2V0Owo+ICsJCQkJbWVtY3B5KGRzdF9kYXRhX3B0ciwgc3Jj X2RhdGFfcHRyLCBieXRlc190b19jb3B5KTsKPiArCQkJfQo+Cj4gICAJCQlzcmNfZGF0YV9wdHIg Kz0gYnVmZmVyX3NpemU7Cj4gICAJCQlkc3RfZGF0YV9wdHIgKz0gYnVmZmVyX3NpemU7Cj4gQEAg LTk1Niw4ICs5ODUsNyBAQCBzdGF0aWMgdm9pZCBndWNfcmVhZF91cGRhdGVfbG9nX2J1ZmZlcihz dHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAJCS8qIEZJWE1FOiBpbnZhbGlkYXRlL2ZsdXNoIGZv ciBsb2cgYnVmZmVyIG5lZWRlZCAqLwo+Cj4gICAJCS8qIFVwZGF0ZSB0aGUgcmVhZCBwb2ludGVy IGluIHRoZSBzaGFyZWQgbG9nIGJ1ZmZlciAqLwo+IC0JCWxvZ19idWZmZXJfc3RhdGUtPnJlYWRf cHRyID0KPiAtCQkJbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbC5zYW1wbGVkX3dyaXRlX3B0cjsKPiAr CQlsb2dfYnVmZmVyX3N0YXRlLT5yZWFkX3B0ciA9IHdyaXRlX29mZnNldDsKPgo+ICAgCQkvKiBD bGVhciB0aGUgJ2ZsdXNoIHRvIGZpbGUnIGZsYWcgKi8KPiAgIAkJbG9nX2J1ZmZlcl9zdGF0ZS0+ Zmx1c2hfdG9fZmlsZSA9IDA7Cj4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==