From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 05/20] drm/i915: Support for GuC interrupts Date: Fri, 12 Aug 2016 16:05:09 +0100 Message-ID: <57ADE5A5.7090505@linux.intel.com> References: <1470983123-22127-1-git-send-email-akash.goel@intel.com> <1470983123-22127-6-git-send-email-akash.goel@intel.com> <57ADB8F7.1070001@linux.intel.com> <8a99de0d-6547-8158-55a4-8ad6777bd428@intel.com> <57ADCFB8.9090603@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id BB48A6EBCB for ; Fri, 12 Aug 2016 15:05:17 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Goel, Akash" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA4LzE2IDE1OjMxLCBHb2VsLCBBa2FzaCB3cm90ZToKPiBPbiA4LzEyLzIwMTYgNzow MSBQTSwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Pj4+ICtzdGF0aWMgdm9pZCBnZW45X2d1YzJo b3N0X2V2ZW50c193b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPj4+Pj4gK3sKPj4+Pj4g KyAgICBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPQo+Pj4+PiArICAgICAgICBj b250YWluZXJfb2Yod29yaywgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUsIGd1Yy5ldmVudHNfd29y ayk7Cj4+Pj4+ICsKPj4+Pj4gKyAgICBzcGluX2xvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2sp Owo+Pj4+PiArICAgIC8qIFNwZWVkIHVwIHdvcmsgY2FuY2VsbGF0aW9uIGR1cmluZyBkaXNhYmxp bmcgZ3VjIGludGVycnVwdHMuICovCj4+Pj4+ICsgICAgaWYgKCFkZXZfcHJpdi0+Z3VjLmludGVy cnVwdHNfZW5hYmxlZCkgewo+Pj4+PiArICAgICAgICBzcGluX3VubG9ja19pcnEoJmRldl9wcml2 LT5pcnFfbG9jayk7Cj4+Pj4+ICsgICAgICAgIHJldHVybjsKPj4+Pgo+Pj4+IEkgc3VwcG9zZSBs b2NraW5nIGZvciBlYXJseSBleGl0IGlzIHNvbWV0aGluZyBhYm91dCBlbnN1cmluZyB0aGUgd29y a2VyCj4+Pj4gc2VlcyB0aGUgdXBkYXRlIHRvIGRldl9wcml2LT5ndWMuaW50ZXJydXB0c19lbmFi bGVkIGRvbmUgb24gYW5vdGhlcgo+Pj4+IENQVT8KPj4+Cj4+PiBZZXMgbG9ja2luZyAocHJvdmlk aW5nIGltcGxpY2l0IGJhcnJpZXIpIHdpbGwgZW5zdXJlIHRoYXQgdXBkYXRlIG1hZGUKPj4+IGZy b20gYW5vdGhlciBDUFUgaXMgaW1tZWRpYXRlbHkgdmlzaWJsZSB0byB0aGUgd29ya2VyLgo+Pgo+ PiBXaGF0IGlmIHRoZSBkaXNhYmxlIGhhcHBlbnMgYWZ0ZXIgdGhlIHVubG9jayBhYm92ZT8gSXQg d291bGQgd2FpdCBpbgo+PiBkaXNhYmxlIHVudGlsIHRoZSBpcnEgaGFuZGxlciBleGl0cy4KPiBN b3N0IHByb2JhYmx5IGl0IHdpbGwgbm90IGhhdmUgdG8gd2FpdCwgYXMgaXJxIGhhbmRsZXIgd291 bGQgaGF2ZQo+IGNvbXBsZXRlZCBpZiB3b3JrIGl0ZW0gYmVnYW4gdGhlIGV4ZWN1dGlvbi4KPiBJ cnEgaGFuZGxlciBqdXN0IHF1ZXVlcyB0aGUgd29yayBpdGVtLCB3aGljaCBnZXRzIHNjaGVkdWxl ZCBsYXRlciBvbi4KPgo+IFVzaW5nIHRoZSBsb2NrIGlzIGJlbmVmaWNpYWwgZm9yIHRoZSBjYXNl IHdoZXJlIHRoZSBleGVjdXRpb24gb2Ygd29yawo+IGl0ZW0gYW5kIGludGVycnVwdCBkaXNhYmxp bmcgaXMgZG9uZSBhcm91bmQgdGhlIHNhbWUgdGltZS4KCk9rIG1heWJlIEkgYW0gbWlzc2luZyBz b21ldGhpbmcuCgpXaGVuIGNhbiB0aGUgaW50ZXJydXB0IGRpc2FibGluZyBoYXBwZW4/IFdpbGwg aXQgYmUgY29udHJvbGxlZCBieSB0aGUgCmRlYnVnZnMgZmlsZSBvciBpcyBpdCBkcml2ZXIgbG9h ZC91bmxvYWQgYW5kIHN1c3BlbmQvcmVzdW1lPwoKPj4+Pj4gK3N0YXRpYyB2b2lkIGdlbjlfZ3Vj X2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4+Pj4gdTMy IGd0X2lpcikKPj4+Pj4gK3sKPj4+Pj4gKyAgICBib29sIGludGVycnVwdHNfZW5hYmxlZDsKPj4+ Pj4gKwo+Pj4+PiArICAgIGlmIChndF9paXIgJiBHRU45X0dVQ19UT19IT1NUX0lOVF9FVkVOVCkg ewo+Pj4+PiArICAgICAgICBzcGluX2xvY2soJmRldl9wcml2LT5pcnFfbG9jayk7Cj4+Pj4+ICsg ICAgICAgIGludGVycnVwdHNfZW5hYmxlZCA9IGRldl9wcml2LT5ndWMuaW50ZXJydXB0c19lbmFi bGVkOwo+Pj4+PiArICAgICAgICBzcGluX3VubG9jaygmZGV2X3ByaXYtPmlycV9sb2NrKTsKPj4+ Pgo+Pj4+IE5vdCBzdXJlIHRoYXQgdGFraW5nIGEgbG9jayBhcm91bmQgb25seSB0aGlzIHJlYWQg aXMgbmVlZGVkLgo+Pj4+Cj4+PiBBZ2FpbiBzYW1lIHJlYXNvbiBhcyBhYm92ZSwgdG8gbWFrZSBz dXJlIGFuIHVwZGF0ZSBtYWRlIG9uIGFub3RoZXIgQ1BVCj4+PiBpcyBpbW1lZGlhdGVseSB2aXNp YmxlIHRvIHRoZSBpcnEgaGFuZGxlci4KPj4KPj4gSSBkb24ndCBnZXQgaXQsIHNlZSBhYm92ZS4g OikKPgo+IEhlcmUgYWxzbyBJZiBpbnRlcnJ1cHQgZGlzYWJsaW5nICYgSVNSIGV4ZWN1dGlvbiBo YXBwZW5zIGFyb3VuZCB0aGUgc2FtZQo+IHRpbWUgdGhlbiBJU1IgbWlnaHQgbWlzcyB0aGUgcmVz ZXQgb2YgJ2ludGVycnVwdHNfZW5hYmxlZCcgZmxhZyBhbmQKPiBxdWV1ZSB0aGUgbmV3IHdvcmsu CgpXaGF0IGlmIHJlc2V0IG9mIGludGVycnVwdHNfZW5hYmxlZCBoYXBwZW5zIGp1c3QgYXMgdGhl IElTUiByZWxlYXNlcyB0aGUgCmxvY2s/Cgo+IEFuZCBzYW1lIGFwcGxpZXMgdG8gdGhlIGNhc2Ug d2hlbiBpbnRlcnJ1cHQgaXMgcmUtZW5hYmxlZCwgSVNSIG1pZ2h0Cj4gc3RpbGwgc2VlIHRoZSAn aW50ZXJydXB0c19lbmFibGVkJyBmbGFnIGFzIGZhbHNlLgo+IEl0IHdpbGwgZXZlbnR1YWxseSBz ZWUgdGhlIHVwZGF0ZSB0aG91Z2guCj4KPj4KPj4+Pj4gKyAgICAgICAgaWYgKGludGVycnVwdHNf ZW5hYmxlZCkgewo+Pj4+PiArICAgICAgICAgICAgLyogU2FtcGxlIHRoZSBsb2cgYnVmZmVyIGZs dXNoIHJlbGF0ZWQgYml0cyAmIGNsZWFyIHRoZW0KPj4+Pj4gKyAgICAgICAgICAgICAqIG91dCBu b3cgaXRzZWxmIGZyb20gdGhlIG1lc3NhZ2UgaWRlbnRpdHkgcmVnaXN0ZXIgdG8KPj4+Pj4gKyAg ICAgICAgICAgICAqIG1pbmltaXplIHRoZSBwcm9iYWJpbGl0eSBvZiBsb3NpbmcgYSBmbHVzaCBp bnRlcnJ1cHQsCj4+Pj4+ICsgICAgICAgICAgICAgKiB3aGVuIHRoZXJlIGFyZSBiYWNrIHRvIGJh Y2sgZmx1c2ggaW50ZXJydXB0cy4KPj4+Pj4gKyAgICAgICAgICAgICAqIFRoZXJlIGNhbiBiZSBh IG5ldyBmbHVzaCBpbnRlcnJ1cHQsIGZvciBkaWZmZXJlbnQgbG9nCj4+Pj4+ICsgICAgICAgICAg ICAgKiBidWZmZXIgdHlwZSAobGlrZSBmb3IgSVNSKSwgd2hpbHN0IEhvc3QgaXMgaGFuZGxpbmcK Pj4+Pj4gKyAgICAgICAgICAgICAqIG9uZSAoZm9yIERQQykuIFNpbmNlIHNhbWUgYml0IGlzIHVz ZWQgaW4gbWVzc2FnZQo+Pj4+PiArICAgICAgICAgICAgICogcmVnaXN0ZXIgZm9yIElTUiAmIERQ QywgaXQgY291bGQgaGFwcGVuIHRoYXQgR3VDCj4+Pj4+ICsgICAgICAgICAgICAgKiBzZXRzIHRo ZSBiaXQgZm9yIDJuZCBpbnRlcnJ1cHQgYnV0IEhvc3QgY2xlYXJzIG91dAo+Pj4+PiArICAgICAg ICAgICAgICogdGhlIGJpdCBvbiBoYW5kbGluZyB0aGUgMXN0IGludGVycnVwdC4KPj4+Pj4gKyAg ICAgICAgICAgICAqLwo+Pj4+PiArICAgICAgICAgICAgdTMyIG1zZyA9IEk5MTVfUkVBRChTT0ZU X1NDUkFUQ0goMTUpKSAmCj4+Pj4+ICsgICAgICAgICAgICAgICAgICAgIChHVUMySE9TVF9NU0df Q1JBU0hfRFVNUF9QT1NURUQgfAo+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgR1VDMkhPU1Rf TVNHX0ZMVVNIX0xPR19CVUZGRVIpOwo+Pj4+PiArICAgICAgICAgICAgaWYgKG1zZykgewo+Pj4+ PiArICAgICAgICAgICAgICAgIC8qIENsZWFyIHRoZSBtZXNzYWdlIGJpdHMgdGhhdCBhcmUgaGFu ZGxlZCAqLwo+Pj4+PiArICAgICAgICAgICAgICAgIEk5MTVfV1JJVEUoU09GVF9TQ1JBVENIKDE1 KSwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgSTkxNV9SRUFEKFNPRlRfU0NSQVRDSCgxNSkp ICYgfm1zZyk7Cj4+Pj4KPj4+PiBDYWNoZSBmdWxsIHZhbHVlIG9mIFNPRlRfU0NSQVRDSCgxNSkg c28geW91IGRvbid0IGhhdmUgdG8gbW1pbyByZWFkIGl0Cj4+Pj4gdHdpY2U/Cj4+Pj4KPj4+IFRo b3VnaHQgcmVhZGluZyBpdCBhZ2FpbiAoanVzdCBiZWZvcmUgdGhlIHVwZGF0ZSkgaXMgYml0IHNh ZmVyIGNvbXBhcmVkCj4+PiB0byByZWFkaW5nIGl0IG9uY2UsIGFzIHRoZXJlIGlzIGEgcG90ZW50 aWFsIHJhY2UgcHJvYmxlbSBoZXJlLgo+Pj4gR3VDIGNvdWxkIGFsc28gd3JpdGUgdG8gdGhlIFNP RlRfU0NSQVRDSCgxNSkgcmVnaXN0ZXIsIHNldCBuZXcgZXZlbnRzCj4+PiBiaXQsIHdoaWxlIEhv c3QgY2xlYXJzIG9mZiB0aGUgYml0IG9mIGhhbmRsZWQgZXZlbnRzLgo+Pgo+PiBEb24ndCBnZXQg aXQuIElmIHRoZXJlIGlzIGEgcmFjZSBiZXR3ZWVuIHJlYWQgYW5kIHdyaXRlIHRoZXJlIHN0aWxs IGlzLAo+PiBkb24ndCBzZWUgaG93IGEgc2Vjb25kIHJlYWQgbWFrZXMgaXQgc2FmZXIuCj4+Cj4g WWVzIGNhbid0IGF2b2lkIHRoZSByYWNlIGNvbXBsZXRlbHkgYnkgZG91YmxlIHJlYWRzLCBidXQg Y2FuIHJlZHVjZSB0aGUKPiByYWNlIHdpbmRvdyBzaXplLgoKVGhlcmUgd2FzIG9ubHkgb25lIHRo aW5nIGJldHdlZW4gdGhlIHR3byByZWFkcywgYW5kIHRoYXQgd2FzICJpZiAobXNnKSI6CgogICsg ICAgICAgICAgICB1MzIgbXNnID0gSTkxNV9SRUFEKFNPRlRfU0NSQVRDSCgxNSkpICYKICArICAg ICAgICAgICAgICAgICAgICAoR1VDMkhPU1RfTVNHX0NSQVNIX0RVTVBfUE9TVEVEIHwKICArICAg ICAgICAgICAgICAgICAgICAgR1VDMkhPU1RfTVNHX0ZMVVNIX0xPR19CVUZGRVIpOwoKICArICAg ICAgICAgICAgaWYgKG1zZykgewoKICArICAgICAgICAgICAgICAgIC8qIENsZWFyIHRoZSBtZXNz YWdlIGJpdHMgdGhhdCBhcmUgaGFuZGxlZCAqLwogICsgICAgICAgICAgICAgICAgSTkxNV9XUklU RShTT0ZUX1NDUkFUQ0goMTUpLAogICsgICAgICAgICAgICAgICAgICAgIEk5MTVfUkVBRChTT0ZU X1NDUkFUQ0goMTUpKSAmIH5tc2cpOwoKPgo+IEFsc28gSSBmZWx0IGNvZGUgbG9va2VkIGJldHRl ciBpbiBjdXJyZW50IGZvcm0sIGFzIG1hY3Jvcwo+IEdVQzJIT1NUX01TR19DUkFTSF9EVU1QX1BP U1RFRCAmIEdVQzJIT1NUX01TR19GTFVTSF9MT0dfQlVGRkVSIHdlcmUgdXNlZAo+IG9ubHkgb25j ZS4KPgo+IFdpbGwgY2hhbmdlIGFzIHBlciB0aGUgaW5pdGlhbCBpbXBsZW1lbnRhdGlvbi4KPgo+ ICAgICAgdTMyIG1zZyA9IEk5MTVfUkVBRChTT0ZUX1NDUkFUQ0goMTUpKTsKPiAgICAgIGlmICht c2cgJiAoR1VDMkhPU1RfTVNHX0NSQVNIX0RVTVBfUE9TVEVEIHwKPiAgICAgICAgICAgICBHVUMy SE9TVF9NU0dfRkxVU0hfTE9HX0JVRkZFUikgewo+ICAgICAgICAgIG1zZyAmPSB+KEdVQzJIT1NU X01TR19DUkFTSF9EVU1QX1BPU1RFRCB8Cj4gICAgICAgICAgICAgICBHVUMySE9TVF9NU0dfRkxV U0hfTE9HX0JVRkZFUik7Cj4gICAgICAgICAgSTkxNV9XUklURShTT0ZUX1NDUkFUQ0goMTUpLCBt c2cpOwo+ICAgICAgfQoKT3I6Cgl1MzIgbXNnLCBmbHVzaDsKCgltc2cgPSBJOTE1X1JFQUQoU09G VF9TQ1JBVENIKDE1KSk7CglmbHVzaCA9IG1zZyAmIChHVUMySE9TVF9NU0dfQ1JBU0hfRFVNUF9Q T1NURUQgfCAKR1VDMkhPU1RfTVNHX0ZMVVNIX0xPR19CVUZGRVIpOwoJaWYgKGZsdXNoKSB7CgkJ STkxNV9XUklURShTT0ZUX1NDUkFUQ0goMTUpLCB+Zmx1c2gpOwoJCS4uLiBxdWV1ZSB3b2tlciAu Li4KCj8KCj4KPj4+PiBBbHNvLCBpcyB0aGUgUk1XIG91dHNpZGUgYW55IGxvY2tzIHNhZmU/Cj4+ Pj4KPj4+Cj4+PiBJZGVhbGx5IG5lZWQgYSB3YXkgdG8gYXRvbWljYWxseSBkbyB0aGUgUk1XLCBp LmUuIHJlYWQgdGhlIHJlZ2lzdGVyCj4+PiB2YWx1ZSwgY2xlYXIgb2ZmIHRoZSBoYW5kbGVkIGV2 ZW50cyBiaXQgYW5kIHVwZGF0ZSB0aGUgcmVnaXN0ZXIgd2l0aCB0aGUKPj4+IG1vZGlmaWVkIHZh bHVlLgo+Pj4KPj4+IFBsZWFzZSBraW5kbHkgc3VnZ2VzdCBob3cgdG8gYWRkcmVzcyB0aGUgYWJv dmUuCj4+PiBPciBjYW4gdGhpcyBiZSBsZWZ0IGFzIGEgVE9ETywgd2hlbiB3ZSBkbyBzdGFydCBo YW5kbGluZyBvdGhlciBldmVudHMKPj4+IGFsc28uCj4+Cj4+IEZyb20gdGhlIGNvbW1lbnQgaW4g Y29kZSBhYm92ZSBpdCBzb3VuZHMgbGlrZSBhIEd1QyBmdyBpbnRlcmZhY2UKPj4gc2hvcnRjb21p bmcgLSB0aGF0IHRoZXJlIGlzIGEgc2luZ2xlIGJpdCBmb3IgdHdvIGRpZmZlcmVudCBpbnRlcnJ1 cHQKPj4gc291cmNlcywgaXMgdGhhdCByaWdodD8KPiBZZXMgdGhhdCBzaG9ydGNvbWluZyBpcyB0 aGVyZSwgR1VDMkhPU1RfTVNHX0ZMVVNIX0xPR19CVUZGRVIgYml0IGlzIHVzZWQKPiBmb3IgY29u dmV5aW5nIHRoZSBmbHVzaCBmb3IgSVNSICYgRFBDIGxvZyBidWZmZXJzLgo+Cj4+IElzIHRoZXJl IGFueSBvdGhlciByZWdpc3RlciBvciBzb21ldGhpbmcgdGhhdAo+PiB5b3UgY2FuIHJlYWQgdG8g ZGV0ZWN0IHRoYXQgdGhlIGludGVycnVwdCBoYXMgYmVlbiByZS1hc3NlcnRlZCB3aGlsZSBpbgo+ PiB0aGUgaXJxIGhhbmRsZXI/Cj4KPgo+PiBBbHRob3VnaCBJIHRob3VnaHQgeW91IHNhaWQgYmVm b3JlIHRoYXQgdGhlIEd1QyB3aWxsCj4+IG5vdCBkbyB0aGF0IC0gdGhhdCBpdCB3b24ndCByZS1h c3NlcnQgdGhlIGludGVycnVwdCBiZWZvcmUgd2Ugc2VuZCB0aGUKPj4gZmx1c2ggY29tbWFuZC4K PiBZZXMgdGhhdCBpcyB0aGUgY2FzZSwgYnV0IHdpdGggcmVzcGVjdCB0byBvbmUgdHlwZSBvZiBh IGxvZyBidWZmZXIsIGxpa2UKPiBmb3IgZXhhbXBsZSB1bmxlc3MgR3VDIGZpcm13YXJlIHJlY2Vp dmVzIHRoZSBhY2sgZm9yIERQQyBsb2cKPiBidWZmZXIgaXQgd29uJ3Qgc2VuZCBhIG5ldyBmbHVz aCBmb3IgRFBDIGJ1ZmZlciwgYnV0IGlmIG1lYW53aGlsZSBJU1IKPiBidWZmZXIgYmVjb21lcyBo YWxmIGZ1bGwgaXQgd2lsbCBzZW5kIGEgZmx1c2ggaW50ZXJydXB0LgoKU28gdGhlIHBvdGVudGlh bCBmb3IgbG9zaW5nIGludGVycnVwdHMgaXMgdW5hdm9pZGFibGUgaXQgc2VlbXMuIDooIElmIEkg CmFtIHVuZGVyc3RhbmRpbmcgdGhpcyBjb3JyZWN0bHkuCgpSZWdhcmRzLAoKVHZydGtvCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=