From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 11/20] drm/i915: Optimization to reduce the sampling time of GuC log buffer Date: Fri, 12 Aug 2016 16:06:38 +0100 Message-ID: <57ADE5FE.9090302@linux.intel.com> References: <1470983123-22127-1-git-send-email-akash.goel@intel.com> <1470983123-22127-12-git-send-email-akash.goel@intel.com> <57ADE054.2030501@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D5636EBCB for ; Fri, 12 Aug 2016 15:06:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Goel, Akash" , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzA4LzE2IDE1OjQ4LCBHb2VsLCBBa2FzaCB3cm90ZToKPiBPbiA4LzEyLzIwMTYgODox MiBQTSwgVHZydGtvIFVyc3VsaW4gd3JvdGU6Cj4+Cj4+IE9uIDEyLzA4LzE2IDA3OjI1LCBha2Fz aC5nb2VsQGludGVsLmNvbSB3cm90ZToKPj4+IEZyb206IEFrYXNoIEdvZWwgPGFrYXNoLmdvZWxA aW50ZWwuY29tPgo+Pj4KPj4+IEd1QyBmaXJtd2FyZSBzZW5kcyBhbiBpbnRlcnJ1cHQgdG8gZmx1 c2ggdGhlIGxvZyBidWZmZXIgd2hlbiBpdCBiZWNvbWVzCj4+PiBoYWxmIGZ1bGwsIHNvIERyaXZl ciBkb2Vzbid0IHJlYWxseSBuZWVkIHRvIHNhbXBsZSB0aGUgY29tcGxldGUgYnVmZmVyCj4+PiBh bmQgY2FuIGp1c3QgY29weSBvbmx5IHRoZSBuZXdseSB3cml0dGVuIGRhdGEgYnkgR3VDIGludG8g dGhlIGxvY2FsCj4+PiBidWZmZXIsIGkuZS4gYXMgcGVyIHRoZSByZWFkICYgd3JpdGUgcG9pbnRl ciB2YWx1ZXMuCj4+PiBNb3Jlb3ZlciB0aGUgZmx1c2ggaW50ZXJydXB0IHdvdWxkIGdlbmVyYWxs eSBjb21lIGZvciBvbmUgdHlwZSBvZiBsb2cKPj4+IGJ1ZmZlciwgd2hlbiBpdCBiZWNvbWVzIGhh bGYgZnVsbCwgc28gYXQgdGhhdCB0aW1lIHRoZSBvdGhlciAyIHR5cGVzIG9mCj4+PiBsb2cgYnVm ZmVyIHdvdWxkIGNvbXBhcmF0aXZlbHkgaGF2ZSBtdWNoIGxlc3NlciB1bnJlYWQgZGF0YSBpbiB0 aGVtLgo+Pj4gSW4gY2FzZSBvZiBvdmVyZmxvdyByZXBvcnRlZCBieSBHdUMsIERyaXZlciBkbyBu ZWVkIHRvIGNvcHkgdGhlIGVudGlyZQo+Pj4gYnVmZmVyIGFzIHRoZSB3aG9sZSBidWZmZXIgd291 bGQgY29udGFpbiB0aGUgdW5yZWFkIGRhdGEuCj4+Pgo+Pj4gdjI6IFJlYmFzZS4KPj4+Cj4+PiBT aWduZWQtb2ZmLWJ5OiBBa2FzaCBHb2VsIDxha2FzaC5nb2VsQGludGVsLmNvbT4KPj4+IC0tLQo+ Pj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCA0MAo+Pj4g KysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzNCBp bnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4+IGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+PiBpbmRleCAxY2ExODY2Li44ZTBmMzYwIDEw MDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5j Cj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMKPj4+ IEBAIC04ODksNyArODg5LDggQEAgc3RhdGljIHZvaWQgZ3VjX3JlYWRfdXBkYXRlX2xvZ19idWZm ZXIoc3RydWN0Cj4+PiBpbnRlbF9ndWMgKmd1YykKPj4+ICAgICAgIHN0cnVjdCBndWNfbG9nX2J1 ZmZlcl9zdGF0ZSAqbG9nX2J1ZmZlcl9zdGF0ZSwKPj4+ICpsb2dfYnVmZmVyX3NuYXBzaG90X3N0 YXRlOwo+Pj4gICAgICAgc3RydWN0IGd1Y19sb2dfYnVmZmVyX3N0YXRlIGxvZ19idWZmZXJfc3Rh dGVfbG9jYWw7Cj4+PiAgICAgICB2b2lkICpzcmNfZGF0YV9wdHIsICpkc3RfZGF0YV9wdHI7Cj4+ PiAtICAgIHUzMiBpLCBidWZmZXJfc2l6ZTsKPj4+ICsgICAgYm9vbCBuZXdfb3ZlcmZsb3c7Cj4+ PiArICAgIHUzMiBpLCBidWZmZXJfc2l6ZSwgcmVhZF9vZmZzZXQsIHdyaXRlX29mZnNldCwgYnl0 ZXNfdG9fY29weTsKPj4+Cj4+PiAgICAgICBpZiAoIWd1Yy0+bG9nLmJ1Zl9hZGRyKQo+Pj4gICAg ICAgICAgIHJldHVybjsKPj4+IEBAIC05MTIsMTAgKzkxMywxMyBAQCBzdGF0aWMgdm9pZCBndWNf cmVhZF91cGRhdGVfbG9nX2J1ZmZlcihzdHJ1Y3QKPj4+IGludGVsX2d1YyAqZ3VjKQo+Pj4gICAg ICAgICAgIG1lbWNweSgmbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbCwgbG9nX2J1ZmZlcl9zdGF0ZSwK Pj4+ICAgICAgICAgICAgICAgICAgIHNpemVvZihzdHJ1Y3QgZ3VjX2xvZ19idWZmZXJfc3RhdGUp KTsKPj4+ICAgICAgICAgICBidWZmZXJfc2l6ZSA9IGxvZ19idWZmZXJfc3RhdGVfbG9jYWwuc2l6 ZTsKPj4+ICsgICAgICAgIHJlYWRfb2Zmc2V0ID0gbG9nX2J1ZmZlcl9zdGF0ZV9sb2NhbC5yZWFk X3B0cjsKPj4+ICsgICAgICAgIHdyaXRlX29mZnNldCA9IGxvZ19idWZmZXJfc3RhdGVfbG9jYWwu c2FtcGxlZF93cml0ZV9wdHI7Cj4+Pgo+Pj4gICAgICAgICAgIGd1Yy0+bG9nLmZsdXNoX2NvdW50 W2ldICs9Cj4+PiBsb2dfYnVmZmVyX3N0YXRlX2xvY2FsLmZsdXNoX3RvX2ZpbGU7Cj4+PiAgICAg ICAgICAgaWYgKGxvZ19idWZmZXJfc3RhdGVfbG9jYWwuYnVmZmVyX2Z1bGxfY250ICE9Cj4+PiAg ICAgICAgICAgICAgICAgICAgICAgZ3VjLT5sb2cucHJldl9vdmVyZmxvd19jb3VudFtpXSkgewo+ Pgo+PiBXcm9uZyBhbGlnbm1lbnQuIFlvdSBjYW4gdHJ5IGNoZWNrcGF0Y2gucGwgZm9yIGFsbCBv ZiB0aG9zZS4KPj4KPiBTb3JyeSBmb3IgYWxsIHRoZSBhbGlnbm1lbnQgJiBpbmRlbnRhdGlvbiBp c3N1ZXMuCj4KPiBTaG91bGQgdGhlIGFib3ZlIGNvbmRpdGlvbiBiZSB3cml0dGVuIGxpa2UgdGhp cyA/Cj4KPiAgICAgIGlmIChsb2dfYnVmZmVyX3N0YXRlX2xvY2FsLmJ1ZmZlcl9mdWxsX2NudCAh PQo+ICAgICAgICAgIGd1Yy0+bG9nLnByZXZfb3ZlcmZsb3dfY291bnRbaV0pIHsKClllcywgYnV0 IGNoZWNrcGF0Y2gucGwgaXMgeW91ciBmcmllbmQuIDopCgo+Pj4gKyAgICAgICAgICAgIG5ld19v dmVyZmxvdyA9IDE7Cj4+Cj4+IHRydWUvZmFsc2Ugc2luY2UgaXQgaXMgYSBib29sCj4gZmluZSB3 aWxsIGRvIHRoYXQuCj4+Cj4+PiAgICAgICAgICAgICAgIGd1Yy0+bG9nLnRvdGFsX292ZXJmbG93 X2NvdW50W2ldICs9Cj4+PiAgICAgICAgICAgICAgICAgICAobG9nX2J1ZmZlcl9zdGF0ZV9sb2Nh bC5idWZmZXJfZnVsbF9jbnQgLQo+Pj4gICAgICAgICAgICAgICAgICAgIGd1Yy0+bG9nLnByZXZf b3ZlcmZsb3dfY291bnRbaV0pOwo+Pj4gQEAgLTkyOSw3ICs5MzMsOCBAQCBzdGF0aWMgdm9pZCBn dWNfcmVhZF91cGRhdGVfbG9nX2J1ZmZlcihzdHJ1Y3QKPj4+IGludGVsX2d1YyAqZ3VjKQo+Pj4g ICAgICAgICAgICAgICBndWMtPmxvZy5wcmV2X292ZXJmbG93X2NvdW50W2ldID0KPj4+ICAgICAg ICAgICAgICAgICAgICAgICBsb2dfYnVmZmVyX3N0YXRlX2xvY2FsLmJ1ZmZlcl9mdWxsX2NudDsK Pj4+ICAgICAgICAgICAgICAgRFJNX0VSUk9SX1JBVEVMSU1JVEVEKCJHdUMgbG9nIGJ1ZmZlciBv dmVyZmxvd1xuIik7Cj4+PiAtICAgICAgICB9Cj4+PiArICAgICAgICB9IGVsc2UKPj4+ICsgICAg ICAgICAgICBuZXdfb3ZlcmZsb3cgPSAwOwo+Pj4KPj4+ICAgICAgICAgICBpZiAobG9nX2J1ZmZl cl9zbmFwc2hvdF9zdGF0ZSkgewo+Pj4gICAgICAgICAgICAgICAvKiBGaXJzdCBjb3B5IHRoZSBz dGF0ZSBzdHJ1Y3R1cmUgaW4gbG9jYWwgYnVmZmVyICovCj4+PiBAQCAtOTQxLDEzICs5NDYsMzcg QEAgc3RhdGljIHZvaWQgZ3VjX3JlYWRfdXBkYXRlX2xvZ19idWZmZXIoc3RydWN0Cj4+PiBpbnRl bF9ndWMgKmd1YykKPj4+ICAgICAgICAgICAgICAgICogZm9yIGNvbnNpc3RlbmN5IHNldCB0aGUg d3JpdGUgcG9pbnRlciB2YWx1ZSB0byBzYW1lCj4+PiAgICAgICAgICAgICAgICAqIHZhbHVlIG9m IHNhbXBsZWRfd3JpdGVfcHRyIGluIHRoZSBzbmFwc2hvdCBidWZmZXIuCj4+PiAgICAgICAgICAg ICAgICAqLwo+Pj4gLSAgICAgICAgICAgIGxvZ19idWZmZXJfc25hcHNob3Rfc3RhdGUtPndyaXRl X3B0ciA9Cj4+PiAtICAgICAgICAgICAgICAgIGxvZ19idWZmZXJfc25hcHNob3Rfc3RhdGUtPnNh bXBsZWRfd3JpdGVfcHRyOwo+Pj4gKyAgICAgICAgICAgIGxvZ19idWZmZXJfc25hcHNob3Rfc3Rh dGUtPndyaXRlX3B0ciA9IHdyaXRlX29mZnNldDsKPj4+Cj4+PiAgICAgICAgICAgICAgIGxvZ19i dWZmZXJfc25hcHNob3Rfc3RhdGUrKzsKPj4+Cj4+PiAgICAgICAgICAgICAgIC8qIE5vdyBjb3B5 IHRoZSBhY3R1YWwgbG9ncyAqLwo+Pj4gICAgICAgICAgICAgICBtZW1jcHkoZHN0X2RhdGFfcHRy LCBzcmNfZGF0YV9wdHIsIGJ1ZmZlcl9zaXplKTsKPj4KPj4gVGhlIGNvbmZ1c2luZyBiaXQgLSB0 aGUgbWVtY3B5IGFib3ZlIHN0aWxsIGNvcGllcyB0aGUgd2hvbGUgYnVmZmVyLCBubz8KPj4KPiBS ZWFsbHkgdmVyeSBzb3JyeSBmb3IgdGhpcyBibG9vcGVyLgoKTm8gd29ycmllcywgaXQgaGFwcGVu cyB0byBldmVyeW9uZSEKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==