From: Waiman Long <waiman.long@hpe.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
<linux-kernel@vger.kernel.org>, <x86@kernel.org>,
Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Scott J Norton <scott.norton@hpe.com>,
Douglas Hatch <doug.hatch@hpe.com>,
Randy Wright <rwright@hpe.com>
Subject: Re: [PATCH v5] x86/hpet: Reduce HPET counter read contention
Date: Fri, 12 Aug 2016 18:50:54 -0400 [thread overview]
Message-ID: <57AE52CE.3040302@hpe.com> (raw)
In-Reply-To: <57AE41F3.6030107@intel.com>
On 08/12/2016 05:38 PM, Dave Hansen wrote:
> On 08/12/2016 02:25 PM, Waiman Long wrote:
>> + * The lock and the hpet value are stored together and can be read in a
>> + * single atomic 64-bit read. It is explicitly assumed that the raw spinlock
>> + * size is 32-bit.
> So what happens when we have all the fun debugging options on?
>
>> typedef struct raw_spinlock {
>> arch_spinlock_t raw_lock;
>> #ifdef CONFIG_GENERIC_LOCKBREAK
>> unsigned int break_lock;
>> #endif
>> #ifdef CONFIG_DEBUG_SPINLOCK
>> unsigned int magic, owner_cpu;
>> void *owner;
>> #endif
>> #ifdef CONFIG_DEBUG_LOCK_ALLOC
>> struct lockdep_map dep_map;
>> #endif
>> } raw_spinlock_t;
Sorry, it should be arch_spinlock_t instead. Will fix that.
Cheers,
Longman
next prev parent reply other threads:[~2016-08-12 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 21:25 [PATCH v5] x86/hpet: Reduce HPET counter read contention Waiman Long
2016-08-12 21:38 ` Dave Hansen
2016-08-12 22:50 ` Waiman Long [this message]
2016-08-12 21:44 ` Dave Hansen
2016-08-12 22:58 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57AE52CE.3040302@hpe.com \
--to=waiman.long@hpe.com \
--cc=bp@suse.de \
--cc=dave.hansen@intel.com \
--cc=doug.hatch@hpe.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=rwright@hpe.com \
--cc=scott.norton@hpe.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.