From: Chanwoo Choi <cw00.choi@samsung.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org, Guenter Roeck <groeck@chromium.org>,
Chris Zhong <zyw@rock-chips.com>
Subject: Re: [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property
Date: Tue, 16 Aug 2016 09:55:23 +0900 [thread overview]
Message-ID: <57B2647B.4010203@samsung.com> (raw)
In-Reply-To: <1471266935-25287-1-git-send-email-linux@roeck-us.net>
Hi Guenter,
Looks good to me.
I'll add the reference[1] information on patch description and applied it.
[1] https://en.wikipedia.org/wiki/USB#Overview
Thanks,
Chanwoo Choi
On 2016년 08월 15일 22:15, Guenter Roeck wrote:
> From: Guenter Roeck <groeck@chromium.org>
>
> EXTCON_PROP_USB_SUPERSPEED is necessary to distinguish between USB/USB2
> and USB3 connections on USB Type-C cables.
>
> Cc: Chris Zhong <zyw@rock-chips.com>
> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> ---
> Applies on top of extcon-next.
>
> include/linux/extcon.h | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/extcon.h b/include/linux/extcon.h
> index ad7a1606a7f3..38d2c0dec2c1 100644
> --- a/include/linux/extcon.h
> +++ b/include/linux/extcon.h
> @@ -107,12 +107,18 @@
> * @type: integer (intval)
> * @value: 0 (normal) or 1 (flip)
> * @default: 0 (normal)
> + * - EXTCON_PROP_USB_SUPERSPEED
> + * @type: integer (intval)
> + * @value: 0 (USB/USB2) or 1 (USB3)
> + * @default: 0 (USB/USB2)
> + *
> */
> #define EXTCON_PROP_USB_VBUS 0
> #define EXTCON_PROP_USB_TYPEC_POLARITY 1
> +#define EXTCON_PROP_USB_SUPERSPEED 2
>
> #define EXTCON_PROP_USB_MIN 0
> -#define EXTCON_PROP_USB_MAX 1
> +#define EXTCON_PROP_USB_MAX 2
> #define EXTCON_PROP_USB_CNT (EXTCON_PROP_USB_MAX - EXTCON_PROP_USB_MIN + 1)
>
> /* Properties of EXTCON_TYPE_CHG. */
>
next prev parent reply other threads:[~2016-08-16 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160815131555epcas1p2866c4a7f64e521c7b7aea2b7a8acc0e4@epcas1p2.samsung.com>
2016-08-15 13:15 ` [PATCH] extcon: Introduce EXTCON_PROP_USB_SUPERSPEED property Guenter Roeck
2016-08-16 0:55 ` Chanwoo Choi [this message]
2016-08-16 1:41 ` Guenter Roeck
2016-08-18 0:37 ` Chanwoo Choi
2016-08-18 0:41 ` Guenter Roeck
2016-08-18 1:25 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B2647B.4010203@samsung.com \
--to=cw00.choi@samsung.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=myungjoo.ham@samsung.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.