From: Yong, Jonathan <jonathan.yong@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v6 0/3] PCI: Precision Time Measurement support
Date: Tue, 16 Aug 2016 09:27:05 +0800 [thread overview]
Message-ID: <57B26BE9.3060902@intel.com> (raw)
In-Reply-To: <20160815185111.GC9790@localhost>
On 08/16/2016 02:51, Bjorn Helgaas wrote:
>>
>> This line:
>> ctrl = PCI_PTM_CTRL_ENABLE | PCI_PTM_CTRL_ROOT;
>>
>> should also set the responder capable bit (7.32.2):
>> If PTM Root Capable is Set, this bit must be Set to 1b.
>
> The PTM Responder Capable bit (bit 1 in Table 7-145) is a HwInit bit
> in the PTM Capability register, so it's read-only from the kernel's
> perspective.
>
> The line you mention ("ctrl = PCI_PTM_CTRL_ENABLE | PCI_PTM_CTRL_ROOT")
> is turning on bits in the PTM Control register, not the Capability
> register.
>
My bad, there is no "responder enable" bit control, patch looks good.
WARNING: multiple messages have this Message-ID (diff)
From: "Yong, Jonathan" <jonathan.yong@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/3] PCI: Precision Time Measurement support
Date: Tue, 16 Aug 2016 09:27:05 +0800 [thread overview]
Message-ID: <57B26BE9.3060902@intel.com> (raw)
In-Reply-To: <20160815185111.GC9790@localhost>
On 08/16/2016 02:51, Bjorn Helgaas wrote:
>>
>> This line:
>> ctrl = PCI_PTM_CTRL_ENABLE | PCI_PTM_CTRL_ROOT;
>>
>> should also set the responder capable bit (7.32.2):
>> If PTM Root Capable is Set, this bit must be Set to 1b.
>
> The PTM Responder Capable bit (bit 1 in Table 7-145) is a HwInit bit
> in the PTM Capability register, so it's read-only from the kernel's
> perspective.
>
> The line you mention ("ctrl = PCI_PTM_CTRL_ENABLE | PCI_PTM_CTRL_ROOT")
> is turning on bits in the PTM Control register, not the Capability
> register.
>
My bad, there is no "responder enable" bit control, patch looks good.
next prev parent reply other threads:[~2016-08-16 1:27 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 19:05 [Intel-wired-lan] [PATCH v6 0/3] PCI: Precision Time Measurement support Bjorn Helgaas
2016-06-13 19:05 ` Bjorn Helgaas
2016-06-13 19:05 ` [Intel-wired-lan] [PATCH v6 1/3] PCI: Add Precision Time Measurement (PTM) support Bjorn Helgaas
2016-06-13 19:05 ` Bjorn Helgaas
2016-08-10 2:58 ` [Intel-wired-lan] " Yong, Jonathan
2016-08-10 2:58 ` Yong, Jonathan
2016-08-15 18:59 ` [Intel-wired-lan] " Bjorn Helgaas
2016-08-15 18:59 ` Bjorn Helgaas
2016-08-16 8:04 ` [Intel-wired-lan] " Yong, Jonathan
2016-08-16 8:04 ` Yong, Jonathan
2016-08-16 13:37 ` [Intel-wired-lan] " Bjorn Helgaas
2016-08-16 13:37 ` Bjorn Helgaas
2016-08-17 8:51 ` [Intel-wired-lan] " Yong, Jonathan
2016-08-17 8:51 ` Yong, Jonathan
2016-08-22 17:01 ` [Intel-wired-lan] " Bjorn Helgaas
2016-08-22 17:01 ` Bjorn Helgaas
2016-08-23 0:13 ` [Intel-wired-lan] " Yong, Jonathan
2016-08-23 0:13 ` Yong, Jonathan
2016-06-13 19:05 ` [Intel-wired-lan] [PATCH v6 2/3] PCI: Add pci_enable_ptm() for drivers to enable PTM on endpoints Bjorn Helgaas
2016-06-13 19:05 ` Bjorn Helgaas
2016-06-13 19:05 ` [Intel-wired-lan] [PATCH v6 3/3] PCI: Add PTM clock granularity information Bjorn Helgaas
2016-06-13 19:05 ` Bjorn Helgaas
2016-06-13 19:42 ` [Intel-wired-lan] " kbuild test robot
2016-06-13 19:42 ` kbuild test robot
2016-07-19 21:19 ` [Intel-wired-lan] [PATCH v6 0/3] PCI: Precision Time Measurement support Bjorn Helgaas
2016-07-19 21:19 ` Bjorn Helgaas
2016-07-19 23:49 ` [Intel-wired-lan] " Yong, Jonathan
2016-07-19 23:49 ` Yong, Jonathan
2016-08-15 18:51 ` [Intel-wired-lan] " Bjorn Helgaas
2016-08-15 18:51 ` Bjorn Helgaas
2016-08-16 1:27 ` Yong, Jonathan [this message]
2016-08-16 1:27 ` Yong, Jonathan
2016-08-23 21:42 ` [Intel-wired-lan] " Bjorn Helgaas
2016-08-23 21:42 ` Bjorn Helgaas
2016-08-24 1:09 ` [Intel-wired-lan] " Yong, Jonathan
2016-08-24 1:09 ` Yong, Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B26BE9.3060902@intel.com \
--to=jonathan.yong@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.