From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v6 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc Date: Wed, 17 Aug 2016 09:37:54 +0900 Message-ID: <57B3B1E2.3040505@samsung.com> References: <1471386989-9541-1-git-send-email-hl@rock-chips.com> <1471386989-9541-8-git-send-email-hl@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1471386989-9541-8-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Lin Huang , heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Cc: tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, dbasehore-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, typ-TNX95d0MmH7DzftRWevZcw@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mark.yao-TNX95d0MmH7DzftRWevZcw@public.gmane.org List-Id: linux-pm@vger.kernel.org SGkgTGluLAoKSSBhZGQganVzdCBvbmUgY29tbWVudCB0byByZW1vdmUgdGhlIGJsYW5rIGxpbmUu CgpPbiAyMDE264WEIDA47JuUIDE37J28IDA3OjM2LCBMaW4gSHVhbmcgd3JvdGU6Cj4gYmFzZSBv biBkZmkgcmVzdWx0LCB3ZSBkbyBkZHIgZnJlcXVlbmN5IHNjYWxpbmcsIHJlZ2lzdGVyCj4gZG1j IGRyaXZlciB0byBkZXZmcmVxIGZyYW1ld29yaywgYW5kIHVzZSBzaW1wbGUtb25kZW1hbmQKPiBw b2xpY3kuCj4gCj4gU2lnbmVkLW9mZi1ieTogTGluIEh1YW5nIDxobEByb2NrLWNoaXBzLmNvbT4K PiBSZXZpZXdlZC1ieTogQ2hhbndvbyBDaG9pIDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+Cj4gLS0t Cj4gQ2hhbmdlcyBpbiB2NjoKPiAtIGZpeCBzb21lIG5pdCBzdWdnZXN0IGJ5IENoYW53b28gQ2hv aQo+IAo+IENoYW5nZXMgaW4gdjU6Cj4gLSBpbXByb3ZlIGRtYyBkcml2ZXIgc3VnZ2VzdCBieSBD aGFud29vIENob2kKPiAKPiBDaGFuZ2VzIGluIHY0Ogo+IC0gdXNlIGFybV9zbWNjY19zbWMoKSBm dW5jdGlvbiB0YWxrIHRvIGJsMzEKPiAtIGRlbGV0ZSByb2NrY2hpcF9kbWMuYyBmaWxlIGFuZCBj b25maWcKPiAtIGRlbGV0ZSBkbWNfbm90aWZ5Cj4gLSBhZGp1c3QgcHJvYmUgb3JkZXIKPiAKPiBD aGFuZ2VzIGluIHYzOgo+IC0gb3BlcmF0ZSBkcmFtIHNldHRpbmcgdGhyb3VnaCBzaXAgY2FsbAo+ IC0gaW1wb3J2ZSBzZXQgcmF0ZSBmbG93Cj4gCj4gQ2hhbmdlcyBpbiB2MjoKPiAtIE5vbmUKPiAK PiBDaGFuZ2VzIGluIHYxOgo+IC0gbW92ZSBkZmkgY29udHJvbGxlciB0byBldmVudAo+IC0gZml4 IHNldCB2b2x0YWdlIHNlcXVlbmNlIHdoZW4gc2V0IHJhdGUgZmFpbAo+IC0gY2hhbmdlIEtjb25m aWcgdHlwZSBmcm9tIHRyaXN0YXRlIHRvIGJvb2wKPiAtIG1vdmUgdW51c2UgRVhQT1JUX1NZTUJP TF9HUEwoKQo+IAo+ICBkcml2ZXJzL2RldmZyZXEvS2NvbmZpZyAgICAgIHwgIDExICsKPiAgZHJp dmVycy9kZXZmcmVxL01ha2VmaWxlICAgICB8ICAgMSArCj4gIGRyaXZlcnMvZGV2ZnJlcS9yazMz OTlfZG1jLmMgfCA0OTcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ICAzIGZpbGVzIGNoYW5nZWQsIDUwOSBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL2RldmZyZXEvcmszMzk5X2RtYy5jCj4gCgpbc25pcF0KCj4gKwo+ICtzdGF0 aWMgaW50IHJrMzM5OV9kbWNmcmVxX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp Cj4gK3sKPiArCXN0cnVjdCBhcm1fc21jY2NfcmVzIHJlczsKPiArCXN0cnVjdCBkZXZpY2UgKmRl diA9ICZwZGV2LT5kZXY7Cj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wID0gcGRldi0+ZGV2Lm9m X25vZGU7Cj4gKwlzdHJ1Y3QgcmszMzk5X2RtY2ZyZXEgKmRhdGE7Cj4gKwlpbnQgcmV0LCBpcnEs IGluZGV4LCBzaXplOwo+ICsJdWludDMyX3QgKnRpbWluZzsKPiArCXN0cnVjdCBkZXZfcG1fb3Bw ICpvcHA7Cj4gKwo+ICsJaXJxID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsKPiArCWlmIChp cnEgPCAwKSB7Cj4gKwkJZGV2X2VycigmcGRldi0+ZGV2LCAiQ2Fubm90IGdldCB0aGUgZG1jIGlu dGVycnVwdCByZXNvdXJjZVxuIik7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwl9Cj4gKwlkYXRh ID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKHN0cnVjdCByazMzOTlfZG1jZnJlcSksIEdGUF9L RVJORUwpOwo+ICsJaWYgKCFkYXRhKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCW11dGV4 X2luaXQoJmRhdGEtPmxvY2spOwo+ICsKPiArCWRhdGEtPnZkZF9jZW50ZXIgPSBkZXZtX3JlZ3Vs YXRvcl9nZXQoZGV2LCAiY2VudGVyIik7Cj4gKwlpZiAoSVNfRVJSKGRhdGEtPnZkZF9jZW50ZXIp KSB7Cj4gKwkJZGV2X2VycihkZXYsICJDYW5ub3QgZ2V0IHRoZSByZWd1bGF0b3IgXCJjZW50ZXJc IlxuIik7Cj4gKwkJcmV0dXJuIFBUUl9FUlIoZGF0YS0+dmRkX2NlbnRlcik7Cj4gKwl9Cj4gKwo+ ICsJZGF0YS0+ZG1jX2NsayA9IGRldm1fY2xrX2dldChkZXYsICJkbWNfY2xrIik7Cj4gKwlpZiAo SVNfRVJSKGRhdGEtPmRtY19jbGspKSB7Cj4gKwkJZGV2X2VycihkZXYsICJDYW5ub3QgZ2V0IHRo ZSBjbGsgZG1jX2Nsa1xuIik7Cj4gKwkJcmV0dXJuIFBUUl9FUlIoZGF0YS0+ZG1jX2Nsayk7Cj4g Kwl9Owo+ICsKPiArCWRhdGEtPmlycSA9IGlycTsKPiArCXJldCA9IGRldm1fcmVxdWVzdF9pcnEo ZGV2LCBpcnEsIHJrMzM5OV9kbWNfaXJxLCAwLAo+ICsJCQkgICAgICAgZGV2X25hbWUoZGV2KSwg ZGF0YSk7Cj4gKwlpZiAocmV0KSB7Cj4gKwkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gcmVxdWVz dCBkbWMgaXJxOiAlZFxuIiwgcmV0KTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICsKPiArCQoK UmVtb3ZlIHRoZSB1bm5lZWRlZCBibGFuayBsaW5lLgoKW3NuaXBdCgpSZWdhcmRzLApDaGFud29v IENob2kKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9j a2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 17 Aug 2016 09:37:54 +0900 Subject: [PATCH v6 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc In-Reply-To: <1471386989-9541-8-git-send-email-hl@rock-chips.com> References: <1471386989-9541-1-git-send-email-hl@rock-chips.com> <1471386989-9541-8-git-send-email-hl@rock-chips.com> Message-ID: <57B3B1E2.3040505@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Lin, I add just one comment to remove the blank line. On 2016? 08? 17? 07:36, Lin Huang wrote: > base on dfi result, we do ddr frequency scaling, register > dmc driver to devfreq framework, and use simple-ondemand > policy. > > Signed-off-by: Lin Huang > Reviewed-by: Chanwoo Choi > --- > Changes in v6: > - fix some nit suggest by Chanwoo Choi > > Changes in v5: > - improve dmc driver suggest by Chanwoo Choi > > Changes in v4: > - use arm_smccc_smc() function talk to bl31 > - delete rockchip_dmc.c file and config > - delete dmc_notify > - adjust probe order > > Changes in v3: > - operate dram setting through sip call > - imporve set rate flow > > Changes in v2: > - None > > Changes in v1: > - move dfi controller to event > - fix set voltage sequence when set rate fail > - change Kconfig type from tristate to bool > - move unuse EXPORT_SYMBOL_GPL() > > drivers/devfreq/Kconfig | 11 + > drivers/devfreq/Makefile | 1 + > drivers/devfreq/rk3399_dmc.c | 497 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 509 insertions(+) > create mode 100644 drivers/devfreq/rk3399_dmc.c > [snip] > + > +static int rk3399_dmcfreq_probe(struct platform_device *pdev) > +{ > + struct arm_smccc_res res; > + struct device *dev = &pdev->dev; > + struct device_node *np = pdev->dev.of_node; > + struct rk3399_dmcfreq *data; > + int ret, irq, index, size; > + uint32_t *timing; > + struct dev_pm_opp *opp; > + > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > + dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); > + return -EINVAL; > + } > + data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + mutex_init(&data->lock); > + > + data->vdd_center = devm_regulator_get(dev, "center"); > + if (IS_ERR(data->vdd_center)) { > + dev_err(dev, "Cannot get the regulator \"center\"\n"); > + return PTR_ERR(data->vdd_center); > + } > + > + data->dmc_clk = devm_clk_get(dev, "dmc_clk"); > + if (IS_ERR(data->dmc_clk)) { > + dev_err(dev, "Cannot get the clk dmc_clk\n"); > + return PTR_ERR(data->dmc_clk); > + }; > + > + data->irq = irq; > + ret = devm_request_irq(dev, irq, rk3399_dmc_irq, 0, > + dev_name(dev), data); > + if (ret) { > + dev_err(dev, "Failed to request dmc irq: %d\n", ret); > + return ret; > + } > + > + Remove the unneeded blank line. [snip] Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbcHQAim (ORCPT ); Tue, 16 Aug 2016 20:38:42 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:54199 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752867AbcHQAij (ORCPT ); Tue, 16 Aug 2016 20:38:39 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68d-f79286d000007a9a-8d-57b3b1e30f20 Content-transfer-encoding: 8BIT Message-id: <57B3B1E2.3040505@samsung.com> Date: Wed, 17 Aug 2016 09:37:54 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Lin Huang , heiko@sntech.de, myungjoo.ham@samsung.com Cc: tixy@linaro.org, mark.rutland@arm.com, typ@rock-chips.com, linux-rockchip@lists.infradead.org, airlied@linux.ie, mturquette@baylibre.com, dbasehore@chromium.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, kyungmin.park@samsung.com, sudeep.holla@arm.com, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com Subject: Re: [PATCH v6 7/8] PM / devfreq: rockchip: add devfreq driver for rk3399 dmc References: <1471386989-9541-1-git-send-email-hl@rock-chips.com> <1471386989-9541-8-git-send-email-hl@rock-chips.com> In-reply-to: <1471386989-9541-8-git-send-email-hl@rock-chips.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42JZI2JSqPt44+Zwg4b9/Ba9504yWbzavIfN 4uyyg2wWV76+Z7P4/+g1q8WPDaeYLc42vWG32PT4GqvF5V1z2Cw+9x5htPj04D+zxdLrF5ks dkw5wGRx8ZSrxe3GFWwWP850s1gsP7WDxWLh/PvsFrNX1zkIe6yZt4bR4/2NVnaP2Q0XWTwu 9/Uyedy5tofNY/u3B6we97uPM3lsXlLv8XfWfhaPvi2rGD22X5vH7PF5k1wATxSXTUpqTmZZ apG+XQJXxv19fcwFP4UrZl+8zNjAeJy/i5GDQ0LAROLxBMEuRk4gU0ziwr31bF2MXBxCAisY JZYcusMIkTCRmNSxkREiMYtR4uL6mewgCV4BQYkfk++xgAxiFpCXOHIpGyTMLKAuMWneImYQ W0jgAaPE/GvSICW8AloS61fWgYRZBFQlprZ1sIHYbEDh/S9ugNn8AooSV388ZgQpFxWIkOg+ UQkSFhHwkdi67zTYacwCS5glLr77BXaBsEC4xIule1ggTjvNKLHwzTmwmzkFHCX2bT7ICpKQ EPjAIfHsxxFWiM0CEt8mH2KBeF5WYtMBZogfJSUOrrjBMoFRfBaSz2YhfDYLyWcLGJlXMYqm FiQXFCelFxnqFSfmFpfmpesl5+duYgQmkNP/nvXuYLx9wPoQowAHoxIPb4PF5nAh1sSy4src Q4ymQEdMZJYSTc4Hpqm8knhDYzMjC1MTU2Mjc0szJXFeRamfwUIC6YklqdmpqQWpRfFFpTmp xYcYmTg4pRoYbW+HO77VOv3IRdovZK6P4n2tY9N9X+8Qnfw8N3XV3w2/X6rtOuvRvHfm8ckP imrn1qulyN8N/rfm2KnW5KS45HNG9TOKf205+NjrhNwthyyVuUdL53l5ndVK226Ur3vqdGHY xsYr308qMM4J+Kb6k/u7ihWH+taAdX86+FYquv651nnm3nsPUSWW4oxEQy3mouJEAM4Zc7Mb AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGKsWRmVeSWpSXmKPExsVy+t9jQd3HGzeHG5y4xm7Re+4kk8WrzXvY LM4uO8hmceXrezaL/49es1r82HCK2eJs0xt2i02Pr7FaXN41h83ic+8RRotPD/4zWyy9fpHJ YseUA0wWF0+5WtxuXMFm8eNMN4vF8lM7WCwWzr/PbjF7dZ2DsMeaeWsYPd7faGX3mN1wkcXj cl8vk8eda3vYPLZ/e8Dqcb/7OJPH5iX1Hn9n7Wfx6NuyitFj+7V5zB6fN8kF8EQ1MNpkpCam pBYppOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAP2opFCWmFMKFApI LC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcy4v6+PueCncMXsi5cZGxiP83cxcnJICJhI TOrYyAhhi0lcuLeerYuRi0NIYBajxMX1M9lBErwCghI/Jt9j6WLk4GAWkJc4cikbJMwsoC4x ad4iZhBbSOABo8T8a9IgJbwCWhLrV9aBhFkEVCWmtnWwgdhsQOH9L26A2fwCihJXfzxmBCkX FYiQ6D5RCRIWEfCR2LrvNNgFzAJLmCUuvvsFdoGwQLjEi6V7WCBOO80osfDNObCbOQUcJfZt Psg6gVFwFpJLZyFcOgvJpQsYmVcxSqQWJBcUJ6XnGuallusVJ+YWl+al6yXn525iBKepZ1I7 GA/ucj/EKMDBqMTDe6J8c7gQa2JZcWXuIUYJDmYlEd6XG4BCvCmJlVWpRfnxRaU5qcWHGE2B np3ILCWanA9MoXkl8YbGJmZGlkbmhhZGxuZK4ryP/68LExJITyxJzU5NLUgtgulj4uCUamA8 /Dfg4FxZ5xm8m1e1eSW7zLoW+CjfZtMy86371/nEMOfK11VHrLZk6pvPefqlH//9RqZoA7ej 12WV5j99Ky09M37NJ4W4uZNzZjP/F1ov+TPgj2OU29k3wpkH5ttdeZRcv//Utqfn3SwnF5kk 3Yve6zqt5cUuvZBdT/auKNt0hfm+5sq7jCm1SizFGYmGWsxFxYkA4/qvj2kDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lin, I add just one comment to remove the blank line. On 2016년 08월 17일 07:36, Lin Huang wrote: > base on dfi result, we do ddr frequency scaling, register > dmc driver to devfreq framework, and use simple-ondemand > policy. > > Signed-off-by: Lin Huang > Reviewed-by: Chanwoo Choi > --- > Changes in v6: > - fix some nit suggest by Chanwoo Choi > > Changes in v5: > - improve dmc driver suggest by Chanwoo Choi > > Changes in v4: > - use arm_smccc_smc() function talk to bl31 > - delete rockchip_dmc.c file and config > - delete dmc_notify > - adjust probe order > > Changes in v3: > - operate dram setting through sip call > - imporve set rate flow > > Changes in v2: > - None > > Changes in v1: > - move dfi controller to event > - fix set voltage sequence when set rate fail > - change Kconfig type from tristate to bool > - move unuse EXPORT_SYMBOL_GPL() > > drivers/devfreq/Kconfig | 11 + > drivers/devfreq/Makefile | 1 + > drivers/devfreq/rk3399_dmc.c | 497 +++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 509 insertions(+) > create mode 100644 drivers/devfreq/rk3399_dmc.c > [snip] > + > +static int rk3399_dmcfreq_probe(struct platform_device *pdev) > +{ > + struct arm_smccc_res res; > + struct device *dev = &pdev->dev; > + struct device_node *np = pdev->dev.of_node; > + struct rk3399_dmcfreq *data; > + int ret, irq, index, size; > + uint32_t *timing; > + struct dev_pm_opp *opp; > + > + irq = platform_get_irq(pdev, 0); > + if (irq < 0) { > + dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); > + return -EINVAL; > + } > + data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); > + if (!data) > + return -ENOMEM; > + > + mutex_init(&data->lock); > + > + data->vdd_center = devm_regulator_get(dev, "center"); > + if (IS_ERR(data->vdd_center)) { > + dev_err(dev, "Cannot get the regulator \"center\"\n"); > + return PTR_ERR(data->vdd_center); > + } > + > + data->dmc_clk = devm_clk_get(dev, "dmc_clk"); > + if (IS_ERR(data->dmc_clk)) { > + dev_err(dev, "Cannot get the clk dmc_clk\n"); > + return PTR_ERR(data->dmc_clk); > + }; > + > + data->irq = irq; > + ret = devm_request_irq(dev, irq, rk3399_dmc_irq, 0, > + dev_name(dev), data); > + if (ret) { > + dev_err(dev, "Failed to request dmc irq: %d\n", ret); > + return ret; > + } > + > + Remove the unneeded blank line. [snip] Regards, Chanwoo Choi