From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Bill Randle <william.c.randle@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] testimage: allow using kvm when running qemux86* machines
Date: Wed, 17 Aug 2016 17:11:30 -0500 [thread overview]
Message-ID: <57B4E112.6000506@linux.intel.com> (raw)
In-Reply-To: <1471388891-839-1-git-send-email-william.c.randle@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3614 bytes --]
On 08/16/2016 06:08 PM, Bill Randle wrote:
> Using kvm can provide significant speedups when running qemux86* machines
> on an x86* host. Enabled by using the new QEMU_USE_KVM variable.
>
> [YOCTO #9298]
>
> Signed-off-by: Bill Randle <william.c.randle@intel.com>
Acked-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/lib/oeqa/targetcontrol.py | 7 +++++++
> meta/lib/oeqa/utils/qemurunner.py | 11 +++++++++--
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/meta/lib/oeqa/targetcontrol.py b/meta/lib/oeqa/targetcontrol.py
> index 768c463..3209ef0 100644
> --- a/meta/lib/oeqa/targetcontrol.py
> +++ b/meta/lib/oeqa/targetcontrol.py
> @@ -125,6 +125,12 @@ class QemuTarget(BaseTarget):
> dump_target_cmds = d.getVar("testimage_dump_target", True)
> dump_host_cmds = d.getVar("testimage_dump_host", True)
> dump_dir = d.getVar("TESTIMAGE_DUMP_DIR", True)
> + if d.getVar("QEMU_USE_KVM", False) is not None \
> + and d.getVar("QEMU_USE_KVM", False) == "True" \
> + and "x86" in d.getVar("MACHINE", True):
> + use_kvm = True
> + else:
> + use_kvm = False
>
> # Log QemuRunner log output to a file
> import oe.path
> @@ -153,6 +159,7 @@ class QemuTarget(BaseTarget):
> display = d.getVar("BB_ORIGENV", False).getVar("DISPLAY", True),
> logfile = self.qemulog,
> boottime = int(d.getVar("TEST_QEMUBOOT_TIMEOUT", True)),
> + use_kvm = use_kvm,
> dump_dir = dump_dir,
> dump_host_cmds = d.getVar("testimage_dump_host", True))
>
> diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py
> index df73120..77e506f 100644
> --- a/meta/lib/oeqa/utils/qemurunner.py
> +++ b/meta/lib/oeqa/utils/qemurunner.py
> @@ -29,7 +29,7 @@ re_control_char = re.compile('[%s]' % re.escape("".join(control_chars)))
>
> class QemuRunner:
>
> - def __init__(self, machine, rootfs, display, tmpdir, deploy_dir_image, logfile, boottime, dump_dir, dump_host_cmds):
> + def __init__(self, machine, rootfs, display, tmpdir, deploy_dir_image, logfile, boottime, dump_dir, dump_host_cmds, use_kvm):
>
> # Popen object for runqemu
> self.runqemu = None
> @@ -49,6 +49,7 @@ class QemuRunner:
> self.boottime = boottime
> self.logged = False
> self.thread = None
> + self.use_kvm = use_kvm
>
> self.runqemutime = 60
> self.host_dumper = HostDumper(dump_host_cmds, dump_dir)
> @@ -133,7 +134,13 @@ class QemuRunner:
> self.origchldhandler = signal.getsignal(signal.SIGCHLD)
> signal.signal(signal.SIGCHLD, self.handleSIGCHLD)
>
> - launch_cmd = 'runqemu tcpserial=%s %s %s %s' % (self.serverport, self.machine, self.rootfs, self.qemuparams)
> + launch_cmd = 'runqemu '
> + if self.use_kvm:
> + logger.info('Using kvm for runqemu')
> + launch_cmd += 'kvm '
> + else:
> + logger.info('Not using kvm for runqemu')
> + launch_cmd += 'tcpserial=%s %s %s %s' % (self.serverport, self.machine, self.rootfs, self.qemuparams)
> # FIXME: We pass in stdin=subprocess.PIPE here to work around stty
> # blocking at the end of the runqemu script when using this within
> # oe-selftest (this makes stty error out immediately). There ought
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2016-08-17 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 23:08 [PATCH] testimage: allow using kvm when running qemux86* machines Bill Randle
2016-08-17 22:11 ` Aníbal Limón [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B4E112.6000506@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=william.c.randle@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.