Re: [PATCH 5/5] drm/amdgpu: fix timeout value check in amd_sched_job_recovery

From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 5/5] drm/amdgpu: fix timeout value check in amd_sched_job_recovery
Date: Thu, 18 Aug 2016 09:39:16 +0800	[thread overview]
Message-ID: <57B511C4.7050107@amd.com> (raw)
In-Reply-To: <1471436784-13252-5-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>


On 2016年08月17日 20:26, Christian König wrote:
> From: Christian König <christian.koenig@amd.com>
>
> Could be that we don't actually have a timeout set.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
>   drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> index f96aa82..f3fc10f 100644
> --- a/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> +++ b/drivers/gpu/drm/amd/scheduler/gpu_scheduler.c
> @@ -407,7 +407,7 @@ void amd_sched_job_recovery(struct amd_gpu_scheduler *sched)
>   	spin_lock(&sched->job_list_lock);
>   	s_job = list_first_entry_or_null(&sched->ring_mirror_list,
>   					 struct amd_sched_job, node);
> -	if (s_job)
> +	if (s_job && sched->timeout != MAX_SCHEDULE_TIMEOUT)
>   		schedule_delayed_work(&s_job->work_tdr, sched->timeout);
>   
>   	list_for_each_entry_safe(s_job, tmp, &sched->ring_mirror_list, node) {

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx