From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baHu5-0007pF-TA for qemu-devel@nongnu.org; Thu, 18 Aug 2016 03:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1baHu2-0002CL-NR for qemu-devel@nongnu.org; Thu, 18 Aug 2016 03:38:17 -0400 Received: from [59.151.112.132] (port=60892 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1baHu2-0002CE-85 for qemu-devel@nongnu.org; Thu, 18 Aug 2016 03:38:14 -0400 References: <1471444747-6277-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1471444747-6277-2-git-send-email-caoj.fnst@cn.fujitsu.com> <87h9aift0s.fsf@dusky.pond.sub.org> From: Cao jin Message-ID: <57B567E4.6000703@cn.fujitsu.com> Date: Thu, 18 Aug 2016 15:46:44 +0800 MIME-Version: 1.0 In-Reply-To: <87h9aift0s.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/6] msix_init: assert programming error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , "Michael S. Tsirkin" On 08/18/2016 03:14 PM, Markus Armbruster wrote: > Cao jin writes: > > > Please explain in the commit message why these are programming errors. > If you're unsure how, give it a try in a reply to this message, and > we'll hammer out something together. > Ok, how about this: The input parameters is used for creating the msix capable device, so they must obey the PCI spec, or else, it should be programming error. -- Yours Sincerely, Cao jin