From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number Date: Thu, 18 Aug 2016 17:08:14 +0800 Message-ID: <57B57AFE.2030706@rock-chips.com> References: <1471454452-2151-1-git-send-email-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1471454452-2151-1-git-send-email-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul , tfiga@chromium.org, dri-devel@lists.freedesktop.org Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgU2VhbgoKVGhhbmtzIGZvciBzZW5kIHYzIHBhdGNoIGZvciByazMzOTkgdm9wIHN1cHBvcnQu CgpCdXQgc29ycnkgZm9yIHRoYXQsIEkgaGFkIGNoYW5nZWQgbXkgbWluZCwgdGhvc2UgcGF0Y2hl cyBhcmUgZGVwcmVjYXRlZCwKSSBoYXZlIG5ldyByazMzOTkgcGF0Y2ggb24gbXkgZG93bnN0cmVh bSBrZXJuZWwsIEkgd2lsbCB1cHN0cmVhbSBzb29uLgoKVGhhbmtzLgoKT24gMjAxNuW5tDA45pyI MTjml6UgMDE6MjAsIFNlYW4gUGF1bCB3cm90ZToKPiBGcm9tOiBNYXJrIFlhbyA8bWFyay55YW9A cm9jay1jaGlwcy5jb20+Cj4KPiBObyBmdW5jdGlvbmFsIGNoYW5nZXMsIHNvcnQgdGhlIHZvcCBy ZWdpc3RlcnMgdG8gbWFrZQo+IGNvZGUgbW9yZSByZWFkYWJsZS4KPgo+IFNpZ25lZC1vZmYtYnk6 IE1hcmsgWWFvIDxtYXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4KPiBbc2VhbnBhdWwgcmVzb2x2ZWQg Y29uZmxpY3Qgd2l0aCBuYW1lIGNoYW5nZSBmcm9tIF8zMDY2IHRvIF8zMDM2XQo+IFNpZ25lZC1v ZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IC0tLQo+Cj4gQ2hhbmdl cyBpbiB2MzoKPiAJLSBGaXggdHlwbyBmcm9tIF8zMDY2IF8zMDM2IChUb21hc3ogRmlnYSkKPgo+ ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYyB8IDE2OCArKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgODQgaW5zZXJ0aW9u cygrKSwgODQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL3JvY2tjaGlwX3ZvcF9yZWcuYyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2Nr Y2hpcF92b3BfcmVnLmMKPiBpbmRleCA5MTk5OTJjLi40NGNhZjE0IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF92b3BfcmVnLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfdm9wX3JlZy5jCj4gQEAgLTUwLDYgKzUwLDg4IEBA IHN0YXRpYyBjb25zdCB1aW50MzJfdCBmb3JtYXRzX3dpbl9saXRlW10gPSB7Cj4gICAJRFJNX0ZP Uk1BVF9CR1I1NjUsCj4gICB9Owo+ICAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX3NjbF9y ZWdzIHJrMzAzNl93aW5fc2NsID0gewo+ICsJLnNjYWxlX3lyZ2JfeCA9IFZPUF9SRUcoUkszMDM2 X1dJTjBfU0NMX0ZBQ1RPUl9ZUkdCLCAweGZmZmYsIDB4MCksCj4gKwkuc2NhbGVfeXJnYl95ID0g Vk9QX1JFRyhSSzMwMzZfV0lOMF9TQ0xfRkFDVE9SX1lSR0IsIDB4ZmZmZiwgMTYpLAo+ICsJLnNj YWxlX2NiY3JfeCA9IFZPUF9SRUcoUkszMDM2X1dJTjBfU0NMX0ZBQ1RPUl9DQlIsIDB4ZmZmZiwg MHgwKSwKPiArCS5zY2FsZV9jYmNyX3kgPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1NDTF9GQUNUT1Jf Q0JSLCAweGZmZmYsIDE2KSwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX3dp bl9waHkgcmszMDM2X3dpbjBfZGF0YSA9IHsKPiArCS5zY2wgPSAmcmszMDM2X3dpbl9zY2wsCj4g KwkuZGF0YV9mb3JtYXRzID0gZm9ybWF0c193aW5fZnVsbCwKPiArCS5uZm9ybWF0cyA9IEFSUkFZ X1NJWkUoZm9ybWF0c193aW5fZnVsbCksCj4gKwkuZW5hYmxlID0gVk9QX1JFRyhSSzMwMzZfU1lT X0NUUkwsIDB4MSwgMCksCj4gKwkuZm9ybWF0ID0gVk9QX1JFRyhSSzMwMzZfU1lTX0NUUkwsIDB4 NywgMyksCj4gKwkucmJfc3dhcCA9IFZPUF9SRUcoUkszMDM2X1NZU19DVFJMLCAweDEsIDE1KSwK PiArCS5hY3RfaW5mbyA9IFZPUF9SRUcoUkszMDM2X1dJTjBfQUNUX0lORk8sIDB4MWZmZjFmZmYs IDApLAo+ICsJLmRzcF9pbmZvID0gVk9QX1JFRyhSSzMwMzZfV0lOMF9EU1BfSU5GTywgMHgwZmZm MGZmZiwgMCksCj4gKwkuZHNwX3N0ID0gVk9QX1JFRyhSSzMwMzZfV0lOMF9EU1BfU1QsIDB4MWZm ZjFmZmYsIDApLAo+ICsJLnlyZ2JfbXN0ID0gVk9QX1JFRyhSSzMwMzZfV0lOMF9ZUkdCX01TVCwg MHhmZmZmZmZmZiwgMCksCj4gKwkudXZfbXN0ID0gVk9QX1JFRyhSSzMwMzZfV0lOMF9DQlJfTVNU LCAweGZmZmZmZmZmLCAwKSwKPiArCS55cmdiX3ZpciA9IFZPUF9SRUcoUkszMDM2X1dJTjBfVklS LCAweGZmZmYsIDApLAo+ICsJLnV2X3ZpciA9IFZPUF9SRUcoUkszMDM2X1dJTjBfVklSLCAweDFm ZmYsIDE2KSwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX3dpbl9waHkgcmsz MDM2X3dpbjFfZGF0YSA9IHsKPiArCS5kYXRhX2Zvcm1hdHMgPSBmb3JtYXRzX3dpbl9saXRlLAo+ ICsJLm5mb3JtYXRzID0gQVJSQVlfU0laRShmb3JtYXRzX3dpbl9saXRlKSwKPiArCS5lbmFibGUg PSBWT1BfUkVHKFJLMzAzNl9TWVNfQ1RSTCwgMHgxLCAxKSwKPiArCS5mb3JtYXQgPSBWT1BfUkVH KFJLMzAzNl9TWVNfQ1RSTCwgMHg3LCA2KSwKPiArCS5yYl9zd2FwID0gVk9QX1JFRyhSSzMwMzZf U1lTX0NUUkwsIDB4MSwgMTkpLAo+ICsJLmFjdF9pbmZvID0gVk9QX1JFRyhSSzMwMzZfV0lOMV9B Q1RfSU5GTywgMHgxZmZmMWZmZiwgMCksCj4gKwkuZHNwX2luZm8gPSBWT1BfUkVHKFJLMzAzNl9X SU4xX0RTUF9JTkZPLCAweDBmZmYwZmZmLCAwKSwKPiArCS5kc3Bfc3QgPSBWT1BfUkVHKFJLMzAz Nl9XSU4xX0RTUF9TVCwgMHgxZmZmMWZmZiwgMCksCj4gKwkueXJnYl9tc3QgPSBWT1BfUkVHKFJL MzAzNl9XSU4xX01TVCwgMHhmZmZmZmZmZiwgMCksCj4gKwkueXJnYl92aXIgPSBWT1BfUkVHKFJL MzAzNl9XSU4xX1ZJUiwgMHhmZmZmLCAwKSwKPiArfTsKPiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1 Y3Qgdm9wX3dpbl9kYXRhIHJrMzAzNl92b3Bfd2luX2RhdGFbXSA9IHsKPiArCXsgLmJhc2UgPSAw eDAwLCAucGh5ID0gJnJrMzAzNl93aW4wX2RhdGEsCj4gKwkgIC50eXBlID0gRFJNX1BMQU5FX1RZ UEVfUFJJTUFSWSB9LAo+ICsJeyAuYmFzZSA9IDB4MDAsIC5waHkgPSAmcmszMDM2X3dpbjFfZGF0 YSwKPiArCSAgLnR5cGUgPSBEUk1fUExBTkVfVFlQRV9DVVJTT1IgfSwKPiArfTsKPiArCj4gK3N0 YXRpYyBjb25zdCBpbnQgcmszMDM2X3ZvcF9pbnRyc1tdID0gewo+ICsJRFNQX0hPTERfVkFMSURf SU5UUiwKPiArCUZTX0lOVFIsCj4gKwlMSU5FX0ZMQUdfSU5UUiwKPiArCUJVU19FUlJPUl9JTlRS LAo+ICt9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCB2b3BfaW50ciByazMwMzZfaW50ciA9 IHsKPiArCS5pbnRycyA9IHJrMzAzNl92b3BfaW50cnMsCj4gKwkubmludHJzID0gQVJSQVlfU0la RShyazMwMzZfdm9wX2ludHJzKSwKPiArCS5zdGF0dXMgPSBWT1BfUkVHKFJLMzAzNl9JTlRfU1RB VFVTLCAweGYsIDApLAo+ICsJLmVuYWJsZSA9IFZPUF9SRUcoUkszMDM2X0lOVF9TVEFUVVMsIDB4 ZiwgNCksCj4gKwkuY2xlYXIgPSBWT1BfUkVHKFJLMzAzNl9JTlRfU1RBVFVTLCAweGYsIDgpLAo+ ICt9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCB2b3BfY3RybCByazMwMzZfY3RybF9kYXRh ID0gewo+ICsJLnN0YW5kYnkgPSBWT1BfUkVHKFJLMzAzNl9TWVNfQ1RSTCwgMHgxLCAzMCksCj4g Kwkub3V0X21vZGUgPSBWT1BfUkVHKFJLMzAzNl9EU1BfQ1RSTDAsIDB4ZiwgMCksCj4gKwkucGlu X3BvbCA9IFZPUF9SRUcoUkszMDM2X0RTUF9DVFJMMCwgMHhmLCA0KSwKPiArCS5odG90YWxfcHcg PSBWT1BfUkVHKFJLMzAzNl9EU1BfSFRPVEFMX0hTX0VORCwgMHgxZmZmMWZmZiwgMCksCj4gKwku aGFjdF9zdF9lbmQgPSBWT1BfUkVHKFJLMzAzNl9EU1BfSEFDVF9TVF9FTkQsIDB4MWZmZjFmZmYs IDApLAo+ICsJLnZ0b3RhbF9wdyA9IFZPUF9SRUcoUkszMDM2X0RTUF9WVE9UQUxfVlNfRU5ELCAw eDFmZmYxZmZmLCAwKSwKPiArCS52YWN0X3N0X2VuZCA9IFZPUF9SRUcoUkszMDM2X0RTUF9WQUNU X1NUX0VORCwgMHgxZmZmMWZmZiwgMCksCj4gKwkuY2ZnX2RvbmUgPSBWT1BfUkVHKFJLMzAzNl9S RUdfQ0ZHX0RPTkUsIDB4MSwgMCksCj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHZv cF9yZWdfZGF0YSByazMwMzZfdm9wX2luaXRfcmVnX3RhYmxlW10gPSB7Cj4gKwl7UkszMDM2X0RT UF9DVFJMMSwgMHgwMDAwMDAwMH0sCj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHZv cF9kYXRhIHJrMzAzNl92b3AgPSB7Cj4gKwkuaW5pdF90YWJsZSA9IHJrMzAzNl92b3BfaW5pdF9y ZWdfdGFibGUsCj4gKwkudGFibGVfc2l6ZSA9IEFSUkFZX1NJWkUocmszMDM2X3ZvcF9pbml0X3Jl Z190YWJsZSksCj4gKwkuY3RybCA9ICZyazMwMzZfY3RybF9kYXRhLAo+ICsJLmludHIgPSAmcmsz MDM2X2ludHIsCj4gKwkud2luID0gcmszMDM2X3ZvcF93aW5fZGF0YSwKPiArCS53aW5fc2l6ZSA9 IEFSUkFZX1NJWkUocmszMDM2X3ZvcF93aW5fZGF0YSksCj4gK307Cj4gKwo+ICAgc3RhdGljIGNv bnN0IHN0cnVjdCB2b3Bfc2NsX2V4dGVuc2lvbiByazMyODhfd2luX2Z1bGxfc2NsX2V4dCA9IHsK PiAgIAkuY2Jjcl92c2RfbW9kZSA9IFZPUF9SRUcoUkszMjg4X1dJTjBfQ1RSTDEsIDB4MSwgMzEp LAo+ICAgCS5jYmNyX3ZzdV9tb2RlID0gVk9QX1JFRyhSSzMyODhfV0lOMF9DVFJMMSwgMHgxLCAz MCksCj4gQEAgLTE5MCw5MyArMjcyLDExIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX2RhdGEg cmszMjg4X3ZvcCA9IHsKPiAgIAkud2luX3NpemUgPSBBUlJBWV9TSVpFKHJrMzI4OF92b3Bfd2lu X2RhdGEpLAo+ICAgfTsKPiAgIAo+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHZvcF9zY2xfcmVncyBy azMwMzZfd2luX3NjbCA9IHsKPiAtCS5zY2FsZV95cmdiX3ggPSBWT1BfUkVHKFJLMzAzNl9XSU4w X1NDTF9GQUNUT1JfWVJHQiwgMHhmZmZmLCAweDApLAo+IC0JLnNjYWxlX3lyZ2JfeSA9IFZPUF9S RUcoUkszMDM2X1dJTjBfU0NMX0ZBQ1RPUl9ZUkdCLCAweGZmZmYsIDE2KSwKPiAtCS5zY2FsZV9j YmNyX3ggPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1NDTF9GQUNUT1JfQ0JSLCAweGZmZmYsIDB4MCks Cj4gLQkuc2NhbGVfY2Jjcl95ID0gVk9QX1JFRyhSSzMwMzZfV0lOMF9TQ0xfRkFDVE9SX0NCUiwg MHhmZmZmLCAxNiksCj4gLX07Cj4gLQo+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHZvcF93aW5fcGh5 IHJrMzAzNl93aW4wX2RhdGEgPSB7Cj4gLQkuc2NsID0gJnJrMzAzNl93aW5fc2NsLAo+IC0JLmRh dGFfZm9ybWF0cyA9IGZvcm1hdHNfd2luX2Z1bGwsCj4gLQkubmZvcm1hdHMgPSBBUlJBWV9TSVpF KGZvcm1hdHNfd2luX2Z1bGwpLAo+IC0JLmVuYWJsZSA9IFZPUF9SRUcoUkszMDM2X1NZU19DVFJM LCAweDEsIDApLAo+IC0JLmZvcm1hdCA9IFZPUF9SRUcoUkszMDM2X1NZU19DVFJMLCAweDcsIDMp LAo+IC0JLnJiX3N3YXAgPSBWT1BfUkVHKFJLMzAzNl9TWVNfQ1RSTCwgMHgxLCAxNSksCj4gLQku YWN0X2luZm8gPSBWT1BfUkVHKFJLMzAzNl9XSU4wX0FDVF9JTkZPLCAweDFmZmYxZmZmLCAwKSwK PiAtCS5kc3BfaW5mbyA9IFZPUF9SRUcoUkszMDM2X1dJTjBfRFNQX0lORk8sIDB4MGZmZjBmZmYs IDApLAo+IC0JLmRzcF9zdCA9IFZPUF9SRUcoUkszMDM2X1dJTjBfRFNQX1NULCAweDFmZmYxZmZm LCAwKSwKPiAtCS55cmdiX21zdCA9IFZPUF9SRUcoUkszMDM2X1dJTjBfWVJHQl9NU1QsIDB4ZmZm ZmZmZmYsIDApLAo+IC0JLnV2X21zdCA9IFZPUF9SRUcoUkszMDM2X1dJTjBfQ0JSX01TVCwgMHhm ZmZmZmZmZiwgMCksCj4gLQkueXJnYl92aXIgPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1ZJUiwgMHhm ZmZmLCAwKSwKPiAtCS51dl92aXIgPSBWT1BfUkVHKFJLMzAzNl9XSU4wX1ZJUiwgMHgxZmZmLCAx NiksCj4gLX07Cj4gLQo+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHZvcF93aW5fcGh5IHJrMzAzNl93 aW4xX2RhdGEgPSB7Cj4gLQkuZGF0YV9mb3JtYXRzID0gZm9ybWF0c193aW5fbGl0ZSwKPiAtCS5u Zm9ybWF0cyA9IEFSUkFZX1NJWkUoZm9ybWF0c193aW5fbGl0ZSksCj4gLQkuZW5hYmxlID0gVk9Q X1JFRyhSSzMwMzZfU1lTX0NUUkwsIDB4MSwgMSksCj4gLQkuZm9ybWF0ID0gVk9QX1JFRyhSSzMw MzZfU1lTX0NUUkwsIDB4NywgNiksCj4gLQkucmJfc3dhcCA9IFZPUF9SRUcoUkszMDM2X1NZU19D VFJMLCAweDEsIDE5KSwKPiAtCS5hY3RfaW5mbyA9IFZPUF9SRUcoUkszMDM2X1dJTjFfQUNUX0lO Rk8sIDB4MWZmZjFmZmYsIDApLAo+IC0JLmRzcF9pbmZvID0gVk9QX1JFRyhSSzMwMzZfV0lOMV9E U1BfSU5GTywgMHgwZmZmMGZmZiwgMCksCj4gLQkuZHNwX3N0ID0gVk9QX1JFRyhSSzMwMzZfV0lO MV9EU1BfU1QsIDB4MWZmZjFmZmYsIDApLAo+IC0JLnlyZ2JfbXN0ID0gVk9QX1JFRyhSSzMwMzZf V0lOMV9NU1QsIDB4ZmZmZmZmZmYsIDApLAo+IC0JLnlyZ2JfdmlyID0gVk9QX1JFRyhSSzMwMzZf V0lOMV9WSVIsIDB4ZmZmZiwgMCksCj4gLX07Cj4gLQo+IC1zdGF0aWMgY29uc3Qgc3RydWN0IHZv cF93aW5fZGF0YSByazMwMzZfdm9wX3dpbl9kYXRhW10gPSB7Cj4gLQl7IC5iYXNlID0gMHgwMCwg LnBoeSA9ICZyazMwMzZfd2luMF9kYXRhLAo+IC0JICAudHlwZSA9IERSTV9QTEFORV9UWVBFX1BS SU1BUlkgfSwKPiAtCXsgLmJhc2UgPSAweDAwLCAucGh5ID0gJnJrMzAzNl93aW4xX2RhdGEsCj4g LQkgIC50eXBlID0gRFJNX1BMQU5FX1RZUEVfQ1VSU09SIH0sCj4gLX07Cj4gLQo+IC1zdGF0aWMg Y29uc3QgaW50IHJrMzAzNl92b3BfaW50cnNbXSA9IHsKPiAtCURTUF9IT0xEX1ZBTElEX0lOVFIs Cj4gLQlGU19JTlRSLAo+IC0JTElORV9GTEFHX0lOVFIsCj4gLQlCVVNfRVJST1JfSU5UUiwKPiAt fTsKPiAtCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX2ludHIgcmszMDM2X2ludHIgPSB7Cj4g LQkuaW50cnMgPSByazMwMzZfdm9wX2ludHJzLAo+IC0JLm5pbnRycyA9IEFSUkFZX1NJWkUocmsz MDM2X3ZvcF9pbnRycyksCj4gLQkuc3RhdHVzID0gVk9QX1JFRyhSSzMwMzZfSU5UX1NUQVRVUywg MHhmLCAwKSwKPiAtCS5lbmFibGUgPSBWT1BfUkVHKFJLMzAzNl9JTlRfU1RBVFVTLCAweGYsIDQp LAo+IC0JLmNsZWFyID0gVk9QX1JFRyhSSzMwMzZfSU5UX1NUQVRVUywgMHhmLCA4KSwKPiAtfTsK PiAtCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX2N0cmwgcmszMDM2X2N0cmxfZGF0YSA9IHsK PiAtCS5zdGFuZGJ5ID0gVk9QX1JFRyhSSzMwMzZfU1lTX0NUUkwsIDB4MSwgMzApLAo+IC0JLm91 dF9tb2RlID0gVk9QX1JFRyhSSzMwMzZfRFNQX0NUUkwwLCAweGYsIDApLAo+IC0JLnBpbl9wb2wg PSBWT1BfUkVHKFJLMzAzNl9EU1BfQ1RSTDAsIDB4ZiwgNCksCj4gLQkuaHRvdGFsX3B3ID0gVk9Q X1JFRyhSSzMwMzZfRFNQX0hUT1RBTF9IU19FTkQsIDB4MWZmZjFmZmYsIDApLAo+IC0JLmhhY3Rf c3RfZW5kID0gVk9QX1JFRyhSSzMwMzZfRFNQX0hBQ1RfU1RfRU5ELCAweDFmZmYxZmZmLCAwKSwK PiAtCS52dG90YWxfcHcgPSBWT1BfUkVHKFJLMzAzNl9EU1BfVlRPVEFMX1ZTX0VORCwgMHgxZmZm MWZmZiwgMCksCj4gLQkudmFjdF9zdF9lbmQgPSBWT1BfUkVHKFJLMzAzNl9EU1BfVkFDVF9TVF9F TkQsIDB4MWZmZjFmZmYsIDApLAo+IC0JLmNmZ19kb25lID0gVk9QX1JFRyhSSzMwMzZfUkVHX0NG R19ET05FLCAweDEsIDApLAo+IC19Owo+IC0KPiAtc3RhdGljIGNvbnN0IHN0cnVjdCB2b3BfcmVn X2RhdGEgcmszMDM2X3ZvcF9pbml0X3JlZ190YWJsZVtdID0gewo+IC0Je1JLMzAzNl9EU1BfQ1RS TDEsIDB4MDAwMDAwMDB9LAo+IC19Owo+IC0KPiAtc3RhdGljIGNvbnN0IHN0cnVjdCB2b3BfZGF0 YSByazMwMzZfdm9wID0gewo+IC0JLmluaXRfdGFibGUgPSByazMwMzZfdm9wX2luaXRfcmVnX3Rh YmxlLAo+IC0JLnRhYmxlX3NpemUgPSBBUlJBWV9TSVpFKHJrMzAzNl92b3BfaW5pdF9yZWdfdGFi bGUpLAo+IC0JLmN0cmwgPSAmcmszMDM2X2N0cmxfZGF0YSwKPiAtCS5pbnRyID0gJnJrMzAzNl9p bnRyLAo+IC0JLndpbiA9IHJrMzAzNl92b3Bfd2luX2RhdGEsCj4gLQkud2luX3NpemUgPSBBUlJB WV9TSVpFKHJrMzAzNl92b3Bfd2luX2RhdGEpLAo+IC19Owo+IC0KPiAgIHN0YXRpYyBjb25zdCBz dHJ1Y3Qgb2ZfZGV2aWNlX2lkIHZvcF9kcml2ZXJfZHRfbWF0Y2hbXSA9IHsKPiAtCXsgLmNvbXBh dGlibGUgPSAicm9ja2NoaXAscmszMjg4LXZvcCIsCj4gLQkgIC5kYXRhID0gJnJrMzI4OF92b3Ag fSwKPiAgIAl7IC5jb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzAzNi12b3AiLAo+ICAgCSAgLmRh dGEgPSAmcmszMDM2X3ZvcCB9LAo+ICsJeyAuY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMyODgt dm9wIiwKPiArCSAgLmRhdGEgPSAmcmszMjg4X3ZvcCB9LAo+ICAgCXt9LAo+ICAgfTsKPiAgIE1P RFVMRV9ERVZJQ0VfVEFCTEUob2YsIHZvcF9kcml2ZXJfZHRfbWF0Y2gpOwoKCi0tIArvvK1hcmsg WWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Thu, 18 Aug 2016 17:08:14 +0800 Subject: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number In-Reply-To: <1471454452-2151-1-git-send-email-seanpaul@chromium.org> References: <1471454452-2151-1-git-send-email-seanpaul@chromium.org> Message-ID: <57B57AFE.2030706@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Sean Thanks for send v3 patch for rk3399 vop support. But sorry for that, I had changed my mind, those patches are deprecated, I have new rk3399 patch on my downstream kernel, I will upstream soon. Thanks. On 2016?08?18? 01:20, Sean Paul wrote: > From: Mark Yao > > No functional changes, sort the vop registers to make > code more readable. > > Signed-off-by: Mark Yao > [seanpaul resolved conflict with name change from _3066 to _3036] > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Fix typo from _3066 _3036 (Tomasz Figa) > > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 168 ++++++++++++++-------------- > 1 file changed, 84 insertions(+), 84 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > index 919992c..44caf14 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > @@ -50,6 +50,88 @@ static const uint32_t formats_win_lite[] = { > DRM_FORMAT_BGR565, > }; > > +static const struct vop_scl_regs rk3036_win_scl = { > + .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0), > + .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16), > + .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0), > + .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16), > +}; > + > +static const struct vop_win_phy rk3036_win0_data = { > + .scl = &rk3036_win_scl, > + .data_formats = formats_win_full, > + .nformats = ARRAY_SIZE(formats_win_full), > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0), > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3), > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15), > + .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0), > + .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0), > + .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0), > + .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0), > + .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0), > + .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0), > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16), > +}; > + > +static const struct vop_win_phy rk3036_win1_data = { > + .data_formats = formats_win_lite, > + .nformats = ARRAY_SIZE(formats_win_lite), > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1), > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6), > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19), > + .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0), > + .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0), > + .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0), > + .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0), > + .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0), > +}; > + > +static const struct vop_win_data rk3036_vop_win_data[] = { > + { .base = 0x00, .phy = &rk3036_win0_data, > + .type = DRM_PLANE_TYPE_PRIMARY }, > + { .base = 0x00, .phy = &rk3036_win1_data, > + .type = DRM_PLANE_TYPE_CURSOR }, > +}; > + > +static const int rk3036_vop_intrs[] = { > + DSP_HOLD_VALID_INTR, > + FS_INTR, > + LINE_FLAG_INTR, > + BUS_ERROR_INTR, > +}; > + > +static const struct vop_intr rk3036_intr = { > + .intrs = rk3036_vop_intrs, > + .nintrs = ARRAY_SIZE(rk3036_vop_intrs), > + .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0), > + .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4), > + .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8), > +}; > + > +static const struct vop_ctrl rk3036_ctrl_data = { > + .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30), > + .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0), > + .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4), > + .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0), > + .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0), > + .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0), > + .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0), > + .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0), > +}; > + > +static const struct vop_reg_data rk3036_vop_init_reg_table[] = { > + {RK3036_DSP_CTRL1, 0x00000000}, > +}; > + > +static const struct vop_data rk3036_vop = { > + .init_table = rk3036_vop_init_reg_table, > + .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table), > + .ctrl = &rk3036_ctrl_data, > + .intr = &rk3036_intr, > + .win = rk3036_vop_win_data, > + .win_size = ARRAY_SIZE(rk3036_vop_win_data), > +}; > + > static const struct vop_scl_extension rk3288_win_full_scl_ext = { > .cbcr_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 31), > .cbcr_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 30), > @@ -190,93 +272,11 @@ static const struct vop_data rk3288_vop = { > .win_size = ARRAY_SIZE(rk3288_vop_win_data), > }; > > -static const struct vop_scl_regs rk3036_win_scl = { > - .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0), > - .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16), > - .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0), > - .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16), > -}; > - > -static const struct vop_win_phy rk3036_win0_data = { > - .scl = &rk3036_win_scl, > - .data_formats = formats_win_full, > - .nformats = ARRAY_SIZE(formats_win_full), > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0), > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3), > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15), > - .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0), > - .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0), > - .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0), > - .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0), > - .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0), > - .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0), > - .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16), > -}; > - > -static const struct vop_win_phy rk3036_win1_data = { > - .data_formats = formats_win_lite, > - .nformats = ARRAY_SIZE(formats_win_lite), > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1), > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6), > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19), > - .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0), > - .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0), > - .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0), > - .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0), > - .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0), > -}; > - > -static const struct vop_win_data rk3036_vop_win_data[] = { > - { .base = 0x00, .phy = &rk3036_win0_data, > - .type = DRM_PLANE_TYPE_PRIMARY }, > - { .base = 0x00, .phy = &rk3036_win1_data, > - .type = DRM_PLANE_TYPE_CURSOR }, > -}; > - > -static const int rk3036_vop_intrs[] = { > - DSP_HOLD_VALID_INTR, > - FS_INTR, > - LINE_FLAG_INTR, > - BUS_ERROR_INTR, > -}; > - > -static const struct vop_intr rk3036_intr = { > - .intrs = rk3036_vop_intrs, > - .nintrs = ARRAY_SIZE(rk3036_vop_intrs), > - .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0), > - .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4), > - .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8), > -}; > - > -static const struct vop_ctrl rk3036_ctrl_data = { > - .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30), > - .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0), > - .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4), > - .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0), > - .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0), > - .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0), > - .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0), > - .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0), > -}; > - > -static const struct vop_reg_data rk3036_vop_init_reg_table[] = { > - {RK3036_DSP_CTRL1, 0x00000000}, > -}; > - > -static const struct vop_data rk3036_vop = { > - .init_table = rk3036_vop_init_reg_table, > - .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table), > - .ctrl = &rk3036_ctrl_data, > - .intr = &rk3036_intr, > - .win = rk3036_vop_win_data, > - .win_size = ARRAY_SIZE(rk3036_vop_win_data), > -}; > - > static const struct of_device_id vop_driver_dt_match[] = { > - { .compatible = "rockchip,rk3288-vop", > - .data = &rk3288_vop }, > { .compatible = "rockchip,rk3036-vop", > .data = &rk3036_vop }, > + { .compatible = "rockchip,rk3288-vop", > + .data = &rk3288_vop }, > {}, > }; > MODULE_DEVICE_TABLE(of, vop_driver_dt_match); -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbcHRJIY (ORCPT ); Thu, 18 Aug 2016 05:08:24 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:58094 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752864AbcHRJIW (ORCPT ); Thu, 18 Aug 2016 05:08:22 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: heiko@sntech.de X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <315c250f207cd0035c3056689b8ebe86> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v3 1/5] drm/rockchip: sort registers define by chip's number To: Sean Paul , tfiga@chromium.org, dri-devel@lists.freedesktop.org References: <1471454452-2151-1-git-send-email-seanpaul@chromium.org> Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, heiko@sntech.de From: Mark yao Message-ID: <57B57AFE.2030706@rock-chips.com> Date: Thu, 18 Aug 2016 17:08:14 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1471454452-2151-1-git-send-email-seanpaul@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean Thanks for send v3 patch for rk3399 vop support. But sorry for that, I had changed my mind, those patches are deprecated, I have new rk3399 patch on my downstream kernel, I will upstream soon. Thanks. On 2016年08月18日 01:20, Sean Paul wrote: > From: Mark Yao > > No functional changes, sort the vop registers to make > code more readable. > > Signed-off-by: Mark Yao > [seanpaul resolved conflict with name change from _3066 to _3036] > Signed-off-by: Sean Paul > --- > > Changes in v3: > - Fix typo from _3066 _3036 (Tomasz Figa) > > drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 168 ++++++++++++++-------------- > 1 file changed, 84 insertions(+), 84 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > index 919992c..44caf14 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > +++ b/drivers/gpu/drm/rockchip/rockchip_vop_reg.c > @@ -50,6 +50,88 @@ static const uint32_t formats_win_lite[] = { > DRM_FORMAT_BGR565, > }; > > +static const struct vop_scl_regs rk3036_win_scl = { > + .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0), > + .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16), > + .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0), > + .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16), > +}; > + > +static const struct vop_win_phy rk3036_win0_data = { > + .scl = &rk3036_win_scl, > + .data_formats = formats_win_full, > + .nformats = ARRAY_SIZE(formats_win_full), > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0), > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3), > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15), > + .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0), > + .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0), > + .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0), > + .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0), > + .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0), > + .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0), > + .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16), > +}; > + > +static const struct vop_win_phy rk3036_win1_data = { > + .data_formats = formats_win_lite, > + .nformats = ARRAY_SIZE(formats_win_lite), > + .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1), > + .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6), > + .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19), > + .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0), > + .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0), > + .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0), > + .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0), > + .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0), > +}; > + > +static const struct vop_win_data rk3036_vop_win_data[] = { > + { .base = 0x00, .phy = &rk3036_win0_data, > + .type = DRM_PLANE_TYPE_PRIMARY }, > + { .base = 0x00, .phy = &rk3036_win1_data, > + .type = DRM_PLANE_TYPE_CURSOR }, > +}; > + > +static const int rk3036_vop_intrs[] = { > + DSP_HOLD_VALID_INTR, > + FS_INTR, > + LINE_FLAG_INTR, > + BUS_ERROR_INTR, > +}; > + > +static const struct vop_intr rk3036_intr = { > + .intrs = rk3036_vop_intrs, > + .nintrs = ARRAY_SIZE(rk3036_vop_intrs), > + .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0), > + .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4), > + .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8), > +}; > + > +static const struct vop_ctrl rk3036_ctrl_data = { > + .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30), > + .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0), > + .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4), > + .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0), > + .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0), > + .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0), > + .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0), > + .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0), > +}; > + > +static const struct vop_reg_data rk3036_vop_init_reg_table[] = { > + {RK3036_DSP_CTRL1, 0x00000000}, > +}; > + > +static const struct vop_data rk3036_vop = { > + .init_table = rk3036_vop_init_reg_table, > + .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table), > + .ctrl = &rk3036_ctrl_data, > + .intr = &rk3036_intr, > + .win = rk3036_vop_win_data, > + .win_size = ARRAY_SIZE(rk3036_vop_win_data), > +}; > + > static const struct vop_scl_extension rk3288_win_full_scl_ext = { > .cbcr_vsd_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 31), > .cbcr_vsu_mode = VOP_REG(RK3288_WIN0_CTRL1, 0x1, 30), > @@ -190,93 +272,11 @@ static const struct vop_data rk3288_vop = { > .win_size = ARRAY_SIZE(rk3288_vop_win_data), > }; > > -static const struct vop_scl_regs rk3036_win_scl = { > - .scale_yrgb_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 0x0), > - .scale_yrgb_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_YRGB, 0xffff, 16), > - .scale_cbcr_x = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 0x0), > - .scale_cbcr_y = VOP_REG(RK3036_WIN0_SCL_FACTOR_CBR, 0xffff, 16), > -}; > - > -static const struct vop_win_phy rk3036_win0_data = { > - .scl = &rk3036_win_scl, > - .data_formats = formats_win_full, > - .nformats = ARRAY_SIZE(formats_win_full), > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 0), > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 3), > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 15), > - .act_info = VOP_REG(RK3036_WIN0_ACT_INFO, 0x1fff1fff, 0), > - .dsp_info = VOP_REG(RK3036_WIN0_DSP_INFO, 0x0fff0fff, 0), > - .dsp_st = VOP_REG(RK3036_WIN0_DSP_ST, 0x1fff1fff, 0), > - .yrgb_mst = VOP_REG(RK3036_WIN0_YRGB_MST, 0xffffffff, 0), > - .uv_mst = VOP_REG(RK3036_WIN0_CBR_MST, 0xffffffff, 0), > - .yrgb_vir = VOP_REG(RK3036_WIN0_VIR, 0xffff, 0), > - .uv_vir = VOP_REG(RK3036_WIN0_VIR, 0x1fff, 16), > -}; > - > -static const struct vop_win_phy rk3036_win1_data = { > - .data_formats = formats_win_lite, > - .nformats = ARRAY_SIZE(formats_win_lite), > - .enable = VOP_REG(RK3036_SYS_CTRL, 0x1, 1), > - .format = VOP_REG(RK3036_SYS_CTRL, 0x7, 6), > - .rb_swap = VOP_REG(RK3036_SYS_CTRL, 0x1, 19), > - .act_info = VOP_REG(RK3036_WIN1_ACT_INFO, 0x1fff1fff, 0), > - .dsp_info = VOP_REG(RK3036_WIN1_DSP_INFO, 0x0fff0fff, 0), > - .dsp_st = VOP_REG(RK3036_WIN1_DSP_ST, 0x1fff1fff, 0), > - .yrgb_mst = VOP_REG(RK3036_WIN1_MST, 0xffffffff, 0), > - .yrgb_vir = VOP_REG(RK3036_WIN1_VIR, 0xffff, 0), > -}; > - > -static const struct vop_win_data rk3036_vop_win_data[] = { > - { .base = 0x00, .phy = &rk3036_win0_data, > - .type = DRM_PLANE_TYPE_PRIMARY }, > - { .base = 0x00, .phy = &rk3036_win1_data, > - .type = DRM_PLANE_TYPE_CURSOR }, > -}; > - > -static const int rk3036_vop_intrs[] = { > - DSP_HOLD_VALID_INTR, > - FS_INTR, > - LINE_FLAG_INTR, > - BUS_ERROR_INTR, > -}; > - > -static const struct vop_intr rk3036_intr = { > - .intrs = rk3036_vop_intrs, > - .nintrs = ARRAY_SIZE(rk3036_vop_intrs), > - .status = VOP_REG(RK3036_INT_STATUS, 0xf, 0), > - .enable = VOP_REG(RK3036_INT_STATUS, 0xf, 4), > - .clear = VOP_REG(RK3036_INT_STATUS, 0xf, 8), > -}; > - > -static const struct vop_ctrl rk3036_ctrl_data = { > - .standby = VOP_REG(RK3036_SYS_CTRL, 0x1, 30), > - .out_mode = VOP_REG(RK3036_DSP_CTRL0, 0xf, 0), > - .pin_pol = VOP_REG(RK3036_DSP_CTRL0, 0xf, 4), > - .htotal_pw = VOP_REG(RK3036_DSP_HTOTAL_HS_END, 0x1fff1fff, 0), > - .hact_st_end = VOP_REG(RK3036_DSP_HACT_ST_END, 0x1fff1fff, 0), > - .vtotal_pw = VOP_REG(RK3036_DSP_VTOTAL_VS_END, 0x1fff1fff, 0), > - .vact_st_end = VOP_REG(RK3036_DSP_VACT_ST_END, 0x1fff1fff, 0), > - .cfg_done = VOP_REG(RK3036_REG_CFG_DONE, 0x1, 0), > -}; > - > -static const struct vop_reg_data rk3036_vop_init_reg_table[] = { > - {RK3036_DSP_CTRL1, 0x00000000}, > -}; > - > -static const struct vop_data rk3036_vop = { > - .init_table = rk3036_vop_init_reg_table, > - .table_size = ARRAY_SIZE(rk3036_vop_init_reg_table), > - .ctrl = &rk3036_ctrl_data, > - .intr = &rk3036_intr, > - .win = rk3036_vop_win_data, > - .win_size = ARRAY_SIZE(rk3036_vop_win_data), > -}; > - > static const struct of_device_id vop_driver_dt_match[] = { > - { .compatible = "rockchip,rk3288-vop", > - .data = &rk3288_vop }, > { .compatible = "rockchip,rk3036-vop", > .data = &rk3036_vop }, > + { .compatible = "rockchip,rk3288-vop", > + .data = &rk3288_vop }, > {}, > }; > MODULE_DEVICE_TABLE(of, vop_driver_dt_match); -- Mark Yao