From: Rahul Bedarkar <Rahul.Bedarkar@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] trousers: fix build issue with musl
Date: Mon, 22 Aug 2016 19:22:55 +0530 [thread overview]
Message-ID: <57BB03B7.2090600@imgtec.com> (raw)
In-Reply-To: <20160820144139.77d3e36a@free-electrons.com>
Hi Thomas,
On Saturday 20 August 2016 06:11 PM, Thomas Petazzoni wrote:
> Hello,
>
>
> This seems like the wrong approach to fix the problem. Indeed, musl
> does have a definition of HOST_NAME_MAX, except it's in <limits.h>.
>
> uClibc and glibc also have HOST_NAME_MAX defined when <limits.h> is
> included, so the right fix is to drop completely the <bits/local_lim.h>
> inclusion, and include <limits.h> instead.
>
> I've tested the following program:
>
> ==
> #include <limits.h>
> #include <stdio.h>
>
> int main(void)
> {
> printf("%d\n", HOST_NAME_MAX);
> return 0;
> }
> ==
>
> and it builds fine with glibc, uClibc and musl.
>
> Could you rework your patch accordingly, and also submit the patch
> upstream to the trousers project?
>
Thanks for comments. Even on Trousers project mailing list someone
proposed similar patch.
https://sourceforge.net/p/trousers/mailman/message/35261558/
Since we can't download it and it's based on upstream master branch, I
will add separate patch here and I don't need to submit it upstream as
it's likely to get merged.
Thanks,
Rahul
next prev parent reply other threads:[~2016-08-22 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-20 11:56 [Buildroot] [PATCH 1/1] trousers: fix build issue with musl Rahul Bedarkar
2016-08-20 12:41 ` Thomas Petazzoni
2016-08-22 13:52 ` Rahul Bedarkar [this message]
2016-08-22 13:59 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BB03B7.2090600@imgtec.com \
--to=rahul.bedarkar@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.