From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:33758 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933234AbcHWAno (ORCPT ); Mon, 22 Aug 2016 20:43:44 -0400 Subject: Re: possible recursive locking detected, 4.8.0-0.rc3.git0.1.fc25.x86_64+debug To: Chris Murphy , Btrfs BTRFS References: From: Jeff Mahoney Message-ID: <57BB9826.6050001@suse.com> Date: Mon, 22 Aug 2016 20:26:14 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="334KsO8AnxuWarFdSbt9HsQM21ckLXRcH" Sender: linux-btrfs-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --334KsO8AnxuWarFdSbt9HsQM21ckLXRcH Content-Type: multipart/mixed; boundary="MKL9VnqeIKFRe5o4pxAQ9UC3hK2nwjSUI" From: Jeff Mahoney To: Chris Murphy , Btrfs BTRFS Message-ID: <57BB9826.6050001@suse.com> Subject: Re: possible recursive locking detected, 4.8.0-0.rc3.git0.1.fc25.x86_64+debug References: In-Reply-To: --MKL9VnqeIKFRe5o4pxAQ9UC3hK2nwjSUI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/22/16 6:51 PM, Chris Murphy wrote: > Trivially reproducible every boot, shortly after mount happens. Also > happened with rc2. >=20 Yep. We've disabled this in our kernels. It can actually deadlock. -Jeff >=20 > [ 13.225891] virbr0: port 1(virbr0-nic) entered blocking state > [ 13.225895] virbr0: port 1(virbr0-nic) entered listening state > [ 13.299806] virbr0: port 1(virbr0-nic) entered disabled state >=20 > [ 13.309179] =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > [ 13.309181] [ INFO: possible recursive locking detected ] > [ 13.309182] 4.8.0-0.rc3.git0.1.fc25.x86_64+debug #1 Not tainted > [ 13.309183] --------------------------------------------- > [ 13.309185] libvirt_leasesh/1174 is trying to acquire lock: > [ 13.309186] (&ei->log_mutex){+.+...}, at: [] > btrfs_log_inode+0x162/0x10f0 [btrfs] > [ 13.309212] > but task is already holding lock: > [ 13.309213] (&ei->log_mutex){+.+...}, at: [] > btrfs_log_inode+0x162/0x10f0 [btrfs] > [ 13.309229] > other info that might help us debug this: > [ 13.309230] Possible unsafe locking scenario: >=20 > [ 13.309231] CPU0 > [ 13.309232] ---- > [ 13.309233] lock(&ei->log_mutex); > [ 13.309235] lock(&ei->log_mutex); > [ 13.309237] > *** DEADLOCK *** >=20 > [ 13.309238] May be due to missing lock nesting notation >=20 > [ 13.309240] 6 locks held by libvirt_leasesh/1174: > [ 13.309241] #0: (sb_writers#8){.+.+.+}, at: [] > __sb_start_write+0xb4/0xf0 > [ 13.309247] #1: (&type->i_mutex_dir_key#3/1){+.+.+.}, at: > [] lock_rename+0xda/0x100 > [ 13.309252] #2: (&sb->s_type->i_mutex_key#14){+.+.+.}, at: > [] lock_two_nondirectories+0x3e/0x70 > [ 13.309258] #3: (&sb->s_type->i_mutex_key#14/4){+.+...}, at: > [] lock_two_nondirectories+0x66/0x70 > [ 13.309263] #4: (sb_internal){.+.+.+}, at: [] > __sb_start_write+0x78/0xf0 > [ 13.309266] #5: (&ei->log_mutex){+.+...}, at: > [] btrfs_log_inode+0x162/0x10f0 [btrfs] > [ 13.309282] > stack backtrace: > [ 13.309284] CPU: 2 PID: 1174 Comm: libvirt_leasesh Not tainted > 4.8.0-0.rc3.git0.1.fc25.x86_64+debug #1 > [ 13.309285] Hardware name: Apple Inc. > MacBookPro8,2/Mac-94245A3940C91C80, BIOS > MBP81.88Z.0047.B2C.1510261540 10/26/15 > [ 13.309287] 0000000000000086 0000000003b4acd5 ffff891b0a1d77a0 > ffffffff9f466723 > [ 13.309290] ffffffffa0b07910 ffff891adcf44000 ffff891b0a1d7868 > ffffffff9f10f01e > [ 13.309294] 00000000dcf44a78 ffffffff00000006 00000000b967c054 > ffffffffa0408900 > [ 13.309297] Call Trace: > [ 13.309301] [] dump_stack+0x86/0xc3 > [ 13.309303] [] __lock_acquire+0x78e/0x1290 > [ 13.309306] [] ? sched_clock+0x9/0x10 > [ 13.309309] [] ? sched_clock_cpu+0xa7/0xc0 > [ 13.309312] [] ? mutex_unlock+0xe/0x10 > [ 13.309314] [] lock_acquire+0xf6/0x1f0 > [ 13.309326] [] ? btrfs_log_inode+0x162/0x10f0 [bt= rfs] > [ 13.309328] [] mutex_lock_nested+0x86/0x3f0 > [ 13.309340] [] ? btrfs_log_inode+0x162/0x10f0 [bt= rfs] > [ 13.309341] [] ? mutex_unlock+0xe/0x10 > [ 13.309353] [] ? btrfs_log_inode+0x162/0x10f0 [bt= rfs] > [ 13.309365] [] btrfs_log_inode+0x162/0x10f0 [btrf= s] > [ 13.309368] [] ? __might_sleep+0x49/0x80 > [ 13.309380] [] btrfs_log_inode+0xc8c/0x10f0 [btrf= s] > [ 13.309382] [] ? sched_clock+0x9/0x10 > [ 13.309394] [] btrfs_log_inode_parent+0x240/0x940= [btrfs] > [ 13.309396] [] ? _raw_spin_unlock+0x27/0x40 > [ 13.309408] [] ? btrfs_update_inode+0xda/0x110 [b= trfs] > [ 13.309420] [] btrfs_log_new_name+0x71/0x90 [btrf= s] > [ 13.309432] [] btrfs_rename2+0x1090/0x17a0 [btrfs= ] > [ 13.309434] [] ? debug_lockdep_rcu_enabled+0x1d/0= x20 > [ 13.309437] [] ? lock_two_nondirectories+0x66/0x7= 0 > [ 13.309439] [] vfs_rename+0x5c2/0x970 > [ 13.309441] [] ? legitimize_path.isra.34+0x20/0x6= 0 > [ 13.309443] [] SyS_rename+0x3a7/0x3d0 > [ 13.309445] [] entry_SYSCALL_64_fastpath+0x1f/0xb= d > [ 13.318819] device virbr0-nic left promiscuous mode > [ 13.318854] virbr0: port 1(virbr0-nic) entered disabled state >=20 --=20 Jeff Mahoney SUSE Labs --MKL9VnqeIKFRe5o4pxAQ9UC3hK2nwjSUI-- --334KsO8AnxuWarFdSbt9HsQM21ckLXRcH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2 iQIcBAEBCAAGBQJXu5gqAAoJEB57S2MheeWytBgP/04y6tf6bNk3xGZkRhGLZgbs Q3weYrpWG6CK3LBXhhf3rkT13U6QBHzVkih3BaIGmEbMsz2wJvA8bC+LeTR8chOn uiP5iCKZAU7gVlCjVx3W+ip0MorC5Oy/5F+uuKz2PXG0/kVpIqBRojTn9MUOCgro op9vw578NMgIZdRKuKeqwig+oTczcizn/bAfyebyMD/PzC5k/Icl/AAAkKXcU6eQ 8Vqy+gmwAKNTFiIobjYqB5JgcuPzupclZx8Yeonax0bOSdrCNolvkB453EV0w4Mi rk6ZxW2qkW7qPo627w7USJCEKb6IqSMu1996POgroWyD0dGCmujnneujZ77tjg/O UWgaq/SSD9c/T5n/IVuk8ACBSDpbHTJLYj5VWHcZYssrr0bOdHCsILu3BoefyMJA Sxc9gTdNXZSBGHnN1Yd7KIa4htZnVr6G74Dzan20dKSysR1bMimu3T1hdyvjcNRM EPb8lghzvALxtIX4CwBh4hetrCbjK14sFiYlxnvZCCC5lXDrhInFaIhDwOh9DNXF lQF/y5DcTp0IdGIVU8CD+xqvDUySajBgE+HIZ1Dm1hgqRhO699aYJ9Q9ObFA+5sM 0FumnbG/DzHxyGQw7Pq98ZIsqjweg4O3oM+LsF9ngkqD5PBDyKNyZns3yJtJ4chG iYnIaRLDrzIFZuNz47Vw =Pozb -----END PGP SIGNATURE----- --334KsO8AnxuWarFdSbt9HsQM21ckLXRcH--