From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Date: Tue, 23 Aug 2016 08:03:03 +0000 Subject: Re: [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code Message-Id: <57BC0337.2080203@xs4all.nl> List-Id: References: <20160812141421.GB1041@n2100.armlinux.org.uk> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russell King , David Airlie , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Hans Verkuil Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Hi Russell, On 08/12/16 16:15, Russell King wrote: > + ret = devm_request_threaded_irq(&pdev->dev, cec->irq, > + dw_hdmi_cec_hardirq, > + dw_hdmi_cec_thread, IRQF_SHARED, > + DEV_NAME, cec->adap); > + if (ret < 0) > + return ret; > + > + ret = cec_register_adapter(cec->adap); > + if (ret < 0) > + return ret; > + > + /* > + * CEC documentation says we must not call cec_delete_adapter > + * after a successful call to cec_register_adapter(). > + */ > + devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec); > + > + hdmi_register_notifier(&cec->nb); The notifier is registered here, but who provides CEC with the initial physical address? As I understand it, it only tells you when things change, not what the initial state is. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: hverkuil@xs4all.nl (Hans Verkuil) Date: Tue, 23 Aug 2016 10:03:03 +0200 Subject: [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code In-Reply-To: References: <20160812141421.GB1041@n2100.armlinux.org.uk> Message-ID: <57BC0337.2080203@xs4all.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell, On 08/12/16 16:15, Russell King wrote: > + ret = devm_request_threaded_irq(&pdev->dev, cec->irq, > + dw_hdmi_cec_hardirq, > + dw_hdmi_cec_thread, IRQF_SHARED, > + DEV_NAME, cec->adap); > + if (ret < 0) > + return ret; > + > + ret = cec_register_adapter(cec->adap); > + if (ret < 0) > + return ret; > + > + /* > + * CEC documentation says we must not call cec_delete_adapter > + * after a successful call to cec_register_adapter(). > + */ > + devm_remove_action(&pdev->dev, dw_hdmi_cec_del, cec); > + > + hdmi_register_notifier(&cec->nb); The notifier is registered here, but who provides CEC with the initial physical address? As I understand it, it only tells you when things change, not what the initial state is. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans Verkuil Subject: Re: [PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code Date: Tue, 23 Aug 2016 10:03:03 +0200 Message-ID: <57BC0337.2080203@xs4all.nl> References: <20160812141421.GB1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lb3-smtp-cloud3.xs4all.net (lb3-smtp-cloud3.xs4all.net [194.109.24.30]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38CDE6E5AB for ; Tue, 23 Aug 2016 08:03:11 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King , David Airlie , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Hans Verkuil Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org SGkgUnVzc2VsbCwKCk9uIDA4LzEyLzE2IDE2OjE1LCBSdXNzZWxsIEtpbmcgd3JvdGU6Cj4gKwly ZXQgPSBkZXZtX3JlcXVlc3RfdGhyZWFkZWRfaXJxKCZwZGV2LT5kZXYsIGNlYy0+aXJxLAo+ICsJ CQkJCWR3X2hkbWlfY2VjX2hhcmRpcnEsCj4gKwkJCQkJZHdfaGRtaV9jZWNfdGhyZWFkLCBJUlFG X1NIQVJFRCwKPiArCQkJCQlERVZfTkFNRSwgY2VjLT5hZGFwKTsKPiArCWlmIChyZXQgPCAwKQo+ ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJcmV0ID0gY2VjX3JlZ2lzdGVyX2FkYXB0ZXIoY2VjLT5h ZGFwKTsKPiArCWlmIChyZXQgPCAwKQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJLyoKPiArCSAq IENFQyBkb2N1bWVudGF0aW9uIHNheXMgd2UgbXVzdCBub3QgY2FsbCBjZWNfZGVsZXRlX2FkYXB0 ZXIKPiArCSAqIGFmdGVyIGEgc3VjY2Vzc2Z1bCBjYWxsIHRvIGNlY19yZWdpc3Rlcl9hZGFwdGVy KCkuCj4gKwkgKi8KPiArCWRldm1fcmVtb3ZlX2FjdGlvbigmcGRldi0+ZGV2LCBkd19oZG1pX2Nl Y19kZWwsIGNlYyk7Cj4gKwo+ICsJaGRtaV9yZWdpc3Rlcl9ub3RpZmllcigmY2VjLT5uYik7CgpU aGUgbm90aWZpZXIgaXMgcmVnaXN0ZXJlZCBoZXJlLCBidXQgd2hvIHByb3ZpZGVzIENFQyB3aXRo IHRoZSBpbml0aWFsCnBoeXNpY2FsIGFkZHJlc3M/IEFzIEkgdW5kZXJzdGFuZCBpdCwgaXQgb25s eSB0ZWxscyB5b3Ugd2hlbiB0aGluZ3MgY2hhbmdlLApub3Qgd2hhdCB0aGUgaW5pdGlhbCBzdGF0 ZSBpcy4KClJlZ2FyZHMsCgoJSGFucwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK