Re: [Qemu-devel] [PATCH] qemu-iotests: Log QMP traffic in debug mode

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

On 08/23/2016 09:46 AM, Kevin Wolf wrote:
> Python tests are already annoying enough to debug. With QMP traffic
> available it's a little bit easier at least.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/iotests.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 03bccdd..3329bc1 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -50,6 +50,7 @@ cachemode = os.environ.get('CACHEMODE')
>  qemu_default_machine = os.environ.get('QEMU_DEFAULT_MACHINE')
>  
>  socket_scm_helper = os.environ.get('SOCKET_SCM_HELPER', 'socket_scm_helper')
> +debug = False
>  
>  def qemu_img(*args):
>      '''Run qemu-img and return the exit code'''
> @@ -134,6 +135,8 @@ class VM(qtest.QEMUQtestMachine):
>      def __init__(self):
>          super(VM, self).__init__(qemu_prog, qemu_opts, test_dir=test_dir,
>                                   socket_scm_helper=socket_scm_helper)
> +        if debug:
> +            self._debug = True
>          self._num_drives = 0
>  

So we already had plumbing for debug...

>      def add_device(self, opts):
> @@ -323,6 +326,8 @@ def verify_quorum():
>  def main(supported_fmts=[], supported_oses=['linux']):
>      '''Run tests'''
>  
> +    global debug

...but just needed to turn it on?

At any rate, I agree that it is useful for figuring out when tests go
wrong, so:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]