All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: 郭鹏飞 <guopengfei160@163.com>, dev@dpdk.org
Subject: Re: [PATCH] kni: bug fix in module_init and module_exit
Date: Thu, 25 Aug 2016 17:19:19 +0100	[thread overview]
Message-ID: <57BF1A87.6030007@intel.com> (raw)
In-Reply-To: <69010abb.168e5.156c18501db.Coremail.guopengfei160@163.com>

Hi Vincent,

On 8/25/2016 12:45 PM, 郭鹏飞 wrote:
> From 932e33f33cf2a19ac5fa4295535b6b0e20c61890 Mon Sep 17 00:00:00 2001
> From: Vincent Guo <guopengfei160@163.com>
> Date: Thu, 25 Aug 2016 17:50:10 +0800
> Subject: [PATCH] kni: bug fix in module_init and module_exit
>  unregister_XXX should be called when module exits or error occurs
>  during module init, but register_XXX is called in case that
>  HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
> 

Patch content is good, thanks for the fix, but patch doesn't apply
cleanly (leading spaces are missing)
Also in commit log, Signed-off-by and Fixes tags are missing.

And commit log can be simpler, something like:
"Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set."

Would you mind sending a new version of the patch?

Thanks,
ferruh

      reply	other threads:[~2016-08-25 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25 11:45 [PATCH] kni: bug fix in module_init and module_exit 郭鹏飞
2016-08-25 16:19 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BF1A87.6030007@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=guopengfei160@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.