From: Timur Tabi <timur@codeaurora.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org,
shankerd@codeaurora.org, vikrams@codeaurora.org,
cov@codeaurora.org, gavidov@codeaurora.org, robh+dt@kernel.org,
andrew@lunn.ch, bjorn.andersson@linaro.org, mlangsdo@redhat.com,
jcm@redhat.com, agross@codeaurora.org, davem@davemloft.net,
LinoSanfilippo@gmx.de
Subject: Re: [PATCH] [v8] net: emac: emac gigabit ethernet controller driver
Date: Thu, 25 Aug 2016 18:38:54 -0500 [thread overview]
Message-ID: <57BF818E.5030302@codeaurora.org> (raw)
In-Reply-To: <e1bdbfa3-c74e-6f08-da36-632224f2bcd9@gmail.com>
Florian Fainelli wrote:
>>> >>Since you have a check on CONFIG_QCOM_EMAC in emac/Makefile, you could
>>> >>always recurse into that directory while building (use obj-y).
>> >
>> >Obviously, having "obj-$(CONFIG_QCOM_EMAC)" in both Makefiles is
>> >redundant, but wouldn't it make more sense to change
>> >"obj-$(CONFIG_QCOM_EMAC)" to "obj-y" in
>> >drivers/net/ethernet/qualcomm/emac/Makefile, so that I only recurse if
>> >necessary?
> Whichever makes the most sense, when there is a directory involved, my
> preference is to always recurse in that directory and selectively
> compile from there, since the Kconfig/Makefile options are all located
> within the same hierarchical level, just a preference.
It turns out that the way I changed it in v9 prevents the driver from
being built as a module. I changed the wrong Makefile. I will have to
post a v10.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-08-25 23:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 21:34 [PATCH] [v8] net: emac: emac gigabit ethernet controller driver Timur Tabi
2016-08-11 22:45 ` Florian Fainelli
2016-08-17 19:38 ` Timur Tabi
2016-08-17 20:03 ` Florian Fainelli
2016-08-25 23:38 ` Timur Tabi [this message]
[not found] ` <57B4BD40.1070703-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-08-17 20:05 ` Andrew Lunn
2016-08-12 18:55 ` Rob Herring
2016-08-12 20:22 ` Aw: " Lino Sanfilippo
2016-08-12 20:39 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BF818E.5030302@codeaurora.org \
--to=timur@codeaurora.org \
--cc=LinoSanfilippo@gmx.de \
--cc=agross@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gavidov@codeaurora.org \
--cc=jcm@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sdharia@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.