From: Chanwoo Choi <cw00.choi@samsung.com>
To: Jisheng Zhang <jszhang@marvell.com>,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: fix Kconfig indent style
Date: Fri, 26 Aug 2016 11:22:10 +0900 [thread overview]
Message-ID: <57BFA7D2.4000807@samsung.com> (raw)
In-Reply-To: <20160825120614.511-1-jszhang@marvell.com>
Hi Jisheng,
Looks good to me. But, you need to rebase it
on latest devfreq.git because the related patch
is already merged[1] for COMPILE_TEST.
So, the merge conflict may happen.
[1] https://git.kernel.org/cgit/linux/kernel/git/mzx/devfreq.git/commit/?h=for-rc&id=c2f9bf4e49c12a3d9fcbee2cd48c9f5d769d8cc8
If you resend it with rebase on devfreq.git,
Feel free to add my reviewed-by tag:
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
On 2016년 08월 25일 21:06, Jisheng Zhang wrote:
> Use tab rather than space to indent, and tab + two spaces to indent
> help message.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/devfreq/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index a5be56e..86d06ab 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -91,14 +91,14 @@ config ARM_EXYNOS_BUS_DEVFREQ
> This does not yet operate with optimal voltages.
>
> config ARM_TEGRA_DEVFREQ
> - tristate "Tegra DEVFREQ Driver"
> - depends on ARCH_TEGRA_124_SOC
> - select DEVFREQ_GOV_SIMPLE_ONDEMAND
> - select PM_OPP
> - help
> - This adds the DEVFREQ driver for the Tegra family of SoCs.
> - It reads ACTMON counters of memory controllers and adjusts the
> - operating frequencies and voltages with OPP support.
> + tristate "Tegra DEVFREQ Driver"
> + depends on ARCH_TEGRA_124_SOC
> + select DEVFREQ_GOV_SIMPLE_ONDEMAND
> + select PM_OPP
> + help
> + This adds the DEVFREQ driver for the Tegra family of SoCs.
> + It reads ACTMON counters of memory controllers and adjusts the
> + operating frequencies and voltages with OPP support.
>
> source "drivers/devfreq/event/Kconfig"
>
>
--
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-08-26 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20160825121110epcas1p4e388645a033341ce2a85e39115e9bb57@epcas1p4.samsung.com>
2016-08-25 12:06 ` [PATCH] PM / devfreq: fix Kconfig indent style Jisheng Zhang
2016-08-25 12:06 ` Jisheng Zhang
2016-08-26 2:22 ` Chanwoo Choi [this message]
2016-08-26 2:42 ` MyungJoo Ham
2016-08-26 2:45 ` Jisheng Zhang
[not found] <CGME20160825121032epcas1p43f3290ba0047692fde5256503badb5bd@epcas1p4.samsung.com>
2016-08-26 1:30 ` MyungJoo Ham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57BFA7D2.4000807@samsung.com \
--to=cw00.choi@samsung.com \
--cc=jszhang@marvell.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.