From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] Bug fix in module_init and module_exit
Date: Mon, 29 Aug 2016 10:38:51 +0100
Message-ID: <57C402AB.6000907@intel.com>
References: <1472436734-5538-1-git-send-email-guopengfei160@163.com>
 <57C40200.6020009@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: Vincent Guo <guopengfei160@163.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 0FA622716
 for <dev@dpdk.org>; Mon, 29 Aug 2016 11:38:53 +0200 (CEST)
In-Reply-To: <57C40200.6020009@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/29/2016 10:36 AM, Ferruh Yigit wrote:
> Hi Vincent,
> 
> On 8/29/2016 3:12 AM, Vincent Guo wrote:
>> Fix pernet calls when HAVE_SIMPLIFIED_PERNET_OPERATIONS is not set.
>>
>> Signed-off-by: Vincent Guo <guopengfei160@163.com>
>> ---
> 
> Thank you for the update, patch applies well this time.
> 
> A few more small details:
> 
> - Patch subject should start with a label/tag, that shows the
> corresponding subsystem. For this patch it is "kni:".
> 
> - In patch subject, after label, sentences starts with lowercase, so
> patch subject becomes:
> 
> kni: bug fix in module_init and module_exit
> 
> 
> - "Fixes:" tag is a line in commit log, to reference the commit that
> generated the error. For this patch it is:
> 
> Fixes: e6734d21b4e1 ("kni: fix build with kernel 2.6.32")
> 
> This line should go above "Signed-off-by", with an empty line between.
> 
> - Replying to previous mail thread help others to see the history of the
> patch. the option --in-reply-to of the "git send-email" can be used for
> this.
> 
> It is possible to get Message ID of the mail that you want to reply via
> patchwork or from mail client. For example for this patch, you can see
> the message id from: http://dpdk.org/dev/patchwork/patch/15506/
> 
> - Adding version number to the patch helps following history. Each
> updated patch increases the version number. "-vN" option of the "git
> format-patch" is useful for this.
> 
> - When a new version of the patch sent, the status of the previous
> version should be updated in patchwork as "Superseded". For this case
> previous version is: http://dpdk.org/dev/patchwork/patch/15506/

Correction: http://dpdk.org/dev/patchwork/patch/15315/

> 
> 
> Thanks,
> ferruh
>