From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values Date: Wed, 31 Aug 2016 09:38:02 +0530 Message-ID: <57C65822.2030301@codeaurora.org> References: <96fd0f06b7ebc2ee5cb8239a99648f3107e24497.1471530573.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BC576E089 for ; Wed, 31 Aug 2016 04:08:09 +0000 (UTC) In-Reply-To: <96fd0f06b7ebc2ee5cb8239a99648f3107e24497.1471530573.git.joabreu@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jose Abreu , dri-devel@lists.freedesktop.org Cc: Russell King , Carlos Palminha , linux-kernel@vger.kernel.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAwOC8yOS8yMDE2IDAzOjAwIFBNLCBKb3NlIEFicmV1IHdyb3RlOgo+IENvbG9yc3Bh Y2UgYW5kIHNjYW4gaW5mb3JtYXRpb24gdmFsdWVzIHdlcmUgYmVpbmcgd3JpdHRlbiBpbiB3cm9u Zwo+IG9mZnNldHMuIFRoaXMgcGF0Y2ggY29ycmVjdHMgdGhpcyBhbmQgd3JpdGVzIHRoZSB2YWx1 ZXMgYXQgdGhlCj4gb2Zmc2V0cyBzcGVjaWZpZWQgaW4gdGhlIGRhdGFib29rLgoKcXVldWVkIHRv IGRybS1taXNjIGFmdGVyIGNsZWFuaW5nIHVwIHNvbWUgY2hlY2twYXRjaAplcnJvcnMuCgpUaGFu a3MsCkFyY2hpdAoKPgo+IFNpZ25lZC1vZmYtYnk6IEpvc2UgQWJyZXUgPGpvYWJyZXVAc3lub3Bz eXMuY29tPgo+IEFja2VkLWJ5OiBSdXNzZWxsIEtpbmcgPHJtaytrZXJuZWxAYXJtbGludXgub3Jn LnVrPgo+IENjOiBDYXJsb3MgUGFsbWluaGEgPHBhbG1pbmhhQHN5bm9wc3lzLmNvbT4KPiBDYzog QXJjaGl0IFRhbmVqYSA8YXJjaGl0dEBjb2RlYXVyb3JhLm9yZz4KPiBDYzogRGF2aWQgQWlybGll IDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBSdXNzZWxsIEtpbmcgPHJtaytrZXJuZWxAYXJtLmxp bnV4Lm9yZy51az4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4K PiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBsaW51eC1rZXJuZWxA dmdlci5rZXJuZWwub3JnCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3LWhkbWku YyB8IDcgKysrKy0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3LWhkbWku YyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHctaGRtaS5jCj4gaW5kZXggNzdhYjQ3My4uY2Rm MzlhYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3LWhkbWkuYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvZHctaGRtaS5jCj4gQEAgLTk0MCwxMCArOTQwLDEx IEBAIHN0YXRpYyB2b2lkIGhkbWlfY29uZmlnX0FWSShzdHJ1Y3QgZHdfaGRtaSAqaGRtaSwgc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCj4gICAJICovCj4KPiAgIAkvKgo+IC0JICogQVZJ IGRhdGEgYnl0ZSAxIGRpZmZlcmVuY2VzOiBDb2xvcnNwYWNlIGluIGJpdHMgNCw1IHJhdGhlciB0 aGFuIDUsNiwKPiAtCSAqIGFjdGl2ZSBhc3BlY3QgcHJlc2VudCBpbiBiaXQgNiByYXRoZXIgdGhh biA0Lgo+ICsJICogQVZJIGRhdGEgYnl0ZSAxIGRpZmZlcmVuY2VzOiBDb2xvcnNwYWNlIGluIGJp dHMgMCwxIHJhdGhlciB0aGFuIDUsNiwKPiArCSAqIHNjYW4gaW5mbyBpbiBiaXRzIDQsNSByYXRo ZXIgdGhhbiAwLDEgYW5kIGFjdGl2ZSBhc3BlY3QgcHJlc2VudCBpbgo+ICsJICogYml0IDYgcmF0 aGVyIHRoYW4gNC4KPiAgIAkgKi8KPiAtCXZhbCA9IChmcmFtZS5jb2xvcnNwYWNlICYgMykgPDwg NCB8IChmcmFtZS5zY2FuX21vZGUgJiAweDMpOwo+ICsJdmFsID0gKGZyYW1lLnNjYW5fbW9kZSAm IDMpIDw8IDQgfCAoZnJhbWUuY29sb3JzcGFjZSAmIDMpOwo+ICAgCWlmIChmcmFtZS5hY3RpdmVf YXNwZWN0ICYgMTUpCj4gICAJCXZhbCB8PSBIRE1JX0ZDX0FWSUNPTkYwX0FDVElWRV9GTVRfSU5G T19QUkVTRU5UOwo+ICAgCWlmIChmcmFtZS50b3BfYmFyIHx8IGZyYW1lLmJvdHRvbV9iYXIpCj4K Ci0tIApRdWFsY29tbSBJbm5vdmF0aW9uIENlbnRlciwgSW5jLiBpcyBhIG1lbWJlciBvZiBDb2Rl IEF1cm9yYSBGb3J1bSwKYSBMaW51eCBGb3VuZGF0aW9uIENvbGxhYm9yYXRpdmUgUHJvamVjdApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752509AbcHaEIm (ORCPT ); Wed, 31 Aug 2016 00:08:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38538 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbcHaEIk (ORCPT ); Wed, 31 Aug 2016 00:08:40 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 4FE1061DB6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH RESEND] drm: bridge/dw-hdmi: Fix colorspace and scan information registers values To: Jose Abreu , dri-devel@lists.freedesktop.org References: <96fd0f06b7ebc2ee5cb8239a99648f3107e24497.1471530573.git.joabreu@synopsys.com> Cc: Carlos Palminha , David Airlie , Russell King , Daniel Vetter , linux-kernel@vger.kernel.org From: Archit Taneja Message-ID: <57C65822.2030301@codeaurora.org> Date: Wed, 31 Aug 2016 09:38:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <96fd0f06b7ebc2ee5cb8239a99648f3107e24497.1471530573.git.joabreu@synopsys.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 08/29/2016 03:00 PM, Jose Abreu wrote: > Colorspace and scan information values were being written in wrong > offsets. This patch corrects this and writes the values at the > offsets specified in the databook. queued to drm-misc after cleaning up some checkpatch errors. Thanks, Archit > > Signed-off-by: Jose Abreu > Acked-by: Russell King > Cc: Carlos Palminha > Cc: Archit Taneja > Cc: David Airlie > Cc: Russell King > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c > index 77ab473..cdf39aa 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -940,10 +940,11 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode) > */ > > /* > - * AVI data byte 1 differences: Colorspace in bits 4,5 rather than 5,6, > - * active aspect present in bit 6 rather than 4. > + * AVI data byte 1 differences: Colorspace in bits 0,1 rather than 5,6, > + * scan info in bits 4,5 rather than 0,1 and active aspect present in > + * bit 6 rather than 4. > */ > - val = (frame.colorspace & 3) << 4 | (frame.scan_mode & 0x3); > + val = (frame.scan_mode & 3) << 4 | (frame.colorspace & 3); > if (frame.active_aspect & 15) > val |= HDMI_FC_AVICONF0_ACTIVE_FMT_INFO_PRESENT; > if (frame.top_bar || frame.bottom_bar) > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project