All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xing Zheng <zhengxing@rock-chips.com>
To: Shunqian Zheng <zhengsq@rock-chips.com>,
	heiko@sntech.de, sboyd@codeaurora.org, mturquette@baylibre.com,
	dianders@chromium.org
Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org,
	zhangqing@rock-chips.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: rockchip: add 2016M to big cpu clk rate table
Date: Thu, 1 Sep 2016 14:08:18 +0800	[thread overview]
Message-ID: <57C7C5D2.7000404@rock-chips.com> (raw)
In-Reply-To: <1472684782-17940-1-git-send-email-zhengsq@rock-chips.com>

Hi Shunqian,

On 2016年09月01日 07:06, Shunqian Zheng wrote:
> We would prefer the 2016M as 2.0G than 1992M which seems odd, adding
> it to big cpu clk rate table then we can set 2016M in dts.
>
> Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
> ---
>   drivers/clk/rockchip/clk-rk3399.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index ede6c47..a6a15c6 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -375,6 +375,7 @@ static struct rockchip_cpuclk_rate_table rk3399_cpuclkb_rates[] __initdata = {
>   	RK3399_CPUCLKB_RATE(2184000000, 1, 11, 11),
>   	RK3399_CPUCLKB_RATE(2088000000, 1, 10, 10),
>   	RK3399_CPUCLKB_RATE(2040000000, 1, 10, 10),
> +	RK3399_CPUCLKB_RATE(2016000000, 1, 9, 9),
>   	RK3399_CPUCLKB_RATE(1992000000, 1, 9, 9),
>   	RK3399_CPUCLKB_RATE(1896000000, 1, 9, 9),
>   	RK3399_CPUCLKB_RATE(1800000000, 1, 8, 8),
It looks good to me.

Reviewed-by: Xing Zheng <zhengxing@rock-chips.com>

Thanks.

-- 
- Xing Zheng



  reply	other threads:[~2016-09-01  6:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 23:06 [PATCH] clk: rockchip: add 2016M to big cpu clk rate table Shunqian Zheng
2016-09-01  6:08 ` Xing Zheng [this message]
2016-09-01 11:35 ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57C7C5D2.7000404@rock-chips.com \
    --to=zhengxing@rock-chips.com \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=zhangqing@rock-chips.com \
    --cc=zhengsq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.