From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH v3 3/5] arm64: dts: rockchip: add the gmac power domain on rk3399 Date: Fri, 02 Sep 2016 01:53:37 +0800 Message-ID: <57C86B21.4090409@rock-chips.com> References: <1472686132-27827-1-git-send-email-wxt@rock-chips.com> <1472686132-27827-4-git-send-email-wxt@rock-chips.com> <2409903.3qiu7FpA8p@diego> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2409903.3qiu7FpA8p@diego> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: =?UTF-8?B?SGVpa28gU3TDvGJuZXI=?= Cc: Mark Rutland , Huang Tao , dbasehore@chromium.org, Elaine Zhang , Xing Zheng , linux-rockchip@lists.infradead.org, netdev@vger.kernel.org, Jianqun Xu , Brian Norris , Will Deacon , Douglas Anderson , linux-kernel@vger.kernel.org, Masahiro Yamada , devicetree@vger.kernel.org, Rob Herring , Roger Chen , Catalin Marinas , David Wu , Shunqian Zheng , linux-arm-kernel@lists.infradead.org, Caesar Wang List-Id: linux-rockchip.vger.kernel.org Ck9uIDIwMTblubQwOeaciDAx5pelIDE5OjQxLCBIZWlrbyBTdMO8Ym5lciB3cm90ZToKPiBIaSBD YWVzYXIsCj4KPiBBbSBEb25uZXJzdGFnLCAxLiBTZXB0ZW1iZXIgMjAxNiwgMDc6Mjg6NTAgc2No cmllYiBDYWVzYXIgV2FuZzoKPj4gVGhpcyBwYXRjaCBzdXBwb3J0cyB0aGUgZ21hYyBwZCB0byBz YXZlIHBvd2VyIGNvbnN1bXB0aW9uLgo+PiBFdmVuIHRob3VnaCBzb21lIGJvYXJkcyBub3QgbmVl ZCBFdGhlcm5ldCBzdXBwb3J0LCB0aGUgZHJpdmVyCj4+IGNvcmUgY2FuIGFsc28gdGFrZSBjYXJl IG9mIHBvd2VyaW5nIHVwIHRoZSBwZCBiZWZvcmUgcHJvYmUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6 IFJvZ2VyIENoZW4gPHJvZ2VyLmNoZW5Acm9jay1jaGlwcy5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6 IENhZXNhciBXYW5nIDx3eHRAcm9jay1jaGlwcy5jb20+Cj4gd2hvIGlzIHRoZSBhdXRob3Igb2Yg dGhpcyBwYXRjaD8gUm9nZXIgb3IgeW91PyBCZWNhdXNlIHdlIHNob3VsZCBlaXRoZXIgZHJvcAo+ IFJvZ2VyJ3MgU2lnbmVkLW9mZiBvciBmaXggdGhlIGF1dGhvcnNoaXAgdG8gbGlzdCBoaW0uCgpU aGFua3MgZm9yIHJlbWluZGluZyBtZS4KQ2FuIHlvdSB0YWtlIGEgbG9vayBhdCB0aGUgbmV3ZXIg djQgc2VyaWVzIHBhdGNoZXM/IDopCmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gv OTMwODAxMy8KCgo+Cj4KPiBIZWlrbwo+Cj4+IC0tLQo+Pgo+PiBDaGFuZ2VzIGluIHYzOgo+PiAt IGxlYXZlIGludG8gdHdvIHBhdGNoZXMgYmFzZWQgb24gcGF0Y2h2MiwgYW5kIGZpeCBuaXRzIGFu ZCBjb21taXQsIGFzCj4+ICAgIGNvbW1lbnQgb24gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9y Zy9wYXRjaC85MzA2MzM5Lwo+Pgo+PiBDaGFuZ2VzIGluIHYyOgo+PiAtIEZpeGVzIHRoZSBvcmRl ciwgc3MgSGVpa28gY29tbW5ldHMgb24KPj4gICAgaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9y Zy9wYXRjaC85MzA1OTkxLwo+Pgo+PiAgIGFyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmsz Mzk5LmR0c2kgfCAxMCArKysrKysrKysrCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlv bnMoKykKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmsz Mzk5LmR0c2kKPj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzM5OS5kdHNpIGlu ZGV4IDMyYWViYzguLjJhYjIzM2YgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMv cm9ja2NoaXAvcmszMzk5LmR0c2kKPj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazMzOTkuZHRzaQo+PiBAQCAtNjExLDYgKzYxMSwxMSBAQAo+PiAgIAkJc3RhdHVzID0gImRp c2FibGVkIjsKPj4gICAJfTsKPj4KPj4gKwlxb3NfZ21hYzogcW9zQGZmYTVjMDAwIHsKPj4gKwkJ Y29tcGF0aWJsZSA9ICJzeXNjb24iOwo+PiArCQlyZWcgPSA8MHgwIDB4ZmZhNWMwMDAgMHgwIDB4 MjA+Owo+PiArCX07Cj4+ICsKPj4gICAJcW9zX2hkY3A6IHFvc0BmZmE5MDAwMCB7Cj4+ICAgCQlj b21wYXRpYmxlID0gInN5c2NvbiI7Cj4+ICAgCQlyZWcgPSA8MHgwIDB4ZmZhOTAwMDAgMHgwIDB4 MjA+Owo+PiBAQCAtNzM5LDYgKzc0NCwxMSBAQAo+PiAgIAkJCX07Cj4+Cj4+ICAgCQkJLyogVGhl c2UgcG93ZXIgZG9tYWlucyBhcmUgZ3JvdXBlZCBieSBWRF9MT0dJQyAqLwo+PiArCQkJcGRfZ21h Y0BSSzMzOTlfUERfR01BQyB7Cj4+ICsJCQkJcmVnID0gPFJLMzM5OV9QRF9HTUFDPjsKPj4gKwkJ CQljbG9ja3MgPSA8JmNydSBBQ0xLX0dNQUM+Owo+PiArCQkJCXBtX3FvcyA9IDwmcW9zX2dtYWM+ Owo+PiArCQkJfTsKPj4gICAJCQlwZF92aW9AUkszMzk5X1BEX1ZJTyB7Cj4+ICAgCQkJCXJlZyA9 IDxSSzMzOTlfUERfVklPPjsKPj4gICAJCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4KPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IExpbnV4LXJvY2tj aGlwIG1haWxpbmcgbGlzdAo+IExpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKPiBo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlw CgoKLS0gCmNhZXNhciB3YW5nIHwgc29mdHdhcmUgZW5naW5lZXIgfCB3eHRAcm9jay1jaGlwLmNv bQoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: wxt@rock-chips.com (Caesar Wang) Date: Fri, 02 Sep 2016 01:53:37 +0800 Subject: [PATCH v3 3/5] arm64: dts: rockchip: add the gmac power domain on rk3399 In-Reply-To: <2409903.3qiu7FpA8p@diego> References: <1472686132-27827-1-git-send-email-wxt@rock-chips.com> <1472686132-27827-4-git-send-email-wxt@rock-chips.com> <2409903.3qiu7FpA8p@diego> Message-ID: <57C86B21.4090409@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?09?01? 19:41, Heiko St?bner wrote: > Hi Caesar, > > Am Donnerstag, 1. September 2016, 07:28:50 schrieb Caesar Wang: >> This patch supports the gmac pd to save power consumption. >> Even though some boards not need Ethernet support, the driver >> core can also take care of powering up the pd before probe. >> >> Signed-off-by: Roger Chen >> Signed-off-by: Caesar Wang > who is the author of this patch? Roger or you? Because we should either drop > Roger's Signed-off or fix the authorship to list him. Thanks for reminding me. Can you take a look at the newer v4 series patches? :) https://patchwork.kernel.org/patch/9308013/ > > > Heiko > >> --- >> >> Changes in v3: >> - leave into two patches based on patchv2, and fix nits and commit, as >> comment on https://patchwork.kernel.org/patch/9306339/ >> >> Changes in v2: >> - Fixes the order, ss Heiko commnets on >> https://patchwork.kernel.org/patch/9305991/ >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 32aebc8..2ab233f 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -611,6 +611,11 @@ >> status = "disabled"; >> }; >> >> + qos_gmac: qos at ffa5c000 { >> + compatible = "syscon"; >> + reg = <0x0 0xffa5c000 0x0 0x20>; >> + }; >> + >> qos_hdcp: qos at ffa90000 { >> compatible = "syscon"; >> reg = <0x0 0xffa90000 0x0 0x20>; >> @@ -739,6 +744,11 @@ >> }; >> >> /* These power domains are grouped by VD_LOGIC */ >> + pd_gmac at RK3399_PD_GMAC { >> + reg = ; >> + clocks = <&cru ACLK_GMAC>; >> + pm_qos = <&qos_gmac>; >> + }; >> pd_vio at RK3399_PD_VIO { >> reg = ; >> #address-cells = <1>; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- caesar wang | software engineer | wxt at rock-chip.com