All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>
Cc: bblanco@plumgrid.com, davem@davemloft.net,
	alexei.starovoitov@gmail.com, john.r.fastabend@intel.com,
	netdev@vger.kernel.org, xiyou.wangcong@gmail.com
Subject: Re: [net-next PATCH] e1000: add initial XDP support
Date: Thu, 1 Sep 2016 12:33:13 -0700	[thread overview]
Message-ID: <57C88279.4030701@gmail.com> (raw)
In-Reply-To: <61de1b91-30b4-67ba-4192-834fa30757ea@mojatatu.com>

[...]

> I think given how ancient the e1000 is we may see the driver being
> a contributing overhead. I believe XDP given location will do
> well - but for this kind of driver my gut feeling is probably not
> by large margin.
> 

Right so just ran the baseline, xdp, tc spread and its all more or
less in the noise where you drop the packets doesn't matter much. At
least in my setup where I'm running e1000 in a VM backed by a tap
device. I don't have a physical e1000 in my system at the moment to
test.

I still think this code is valuable though because it lets me run
the same XDP program in a e1000 VM that I'm running on my 10/40Gbps
NIC. Also it gives me a nice test platform to work on.

I'm going to resubmit the patch with a couple of the fixes pointed out
by others.

Thanks,
John

  parent reply	other threads:[~2016-09-01 21:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27  7:11 [net-next PATCH] e1000: add initial XDP support John Fastabend
2016-08-28  5:55 ` Or Gerlitz
2016-08-29  5:33   ` John Fastabend
2016-08-28 12:23 ` Jamal Hadi Salim
2016-08-29  8:30   ` Jesper Dangaard Brouer
2016-08-29 10:53     ` Jamal Hadi Salim
2016-08-29 13:39       ` Jesper Dangaard Brouer
2016-08-29 15:55         ` Jesper Dangaard Brouer
2016-08-30 12:13           ` Jamal Hadi Salim
2016-08-30 13:31             ` Jesper Dangaard Brouer
2016-09-01 21:35               ` John Fastabend
2016-09-01 19:33       ` John Fastabend [this message]
2016-08-28 15:56 ` William Tu
2016-08-29  5:36   ` John Fastabend

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57C88279.4030701@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bblanco@plumgrid.com \
    --cc=brouer@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.