From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org ([198.145.29.96]:56191 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbcIBIFR (ORCPT ); Fri, 2 Sep 2016 04:05:17 -0400 Subject: Re: [PATCH] drm/bridge: adv7511: add support for the 2nd chip To: Sergei Shtylyov , airlied@linux.ie, dri-devel@lists.freedesktop.org References: <4933961.PFafUbE9pV@wasted.cogentembedded.com> Cc: linux-renesas-soc@vger.kernel.org From: Archit Taneja Message-ID: <57C932B6.9090503@codeaurora.org> Date: Fri, 2 Sep 2016 13:35:10 +0530 MIME-Version: 1.0 In-Reply-To: <4933961.PFafUbE9pV@wasted.cogentembedded.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi, On 9/2/2016 2:13 AM, Sergei Shtylyov wrote: > The Renesas Wheat board has 2 ADV7513 chips on the same I2C bus, however > the ADV751x driver only supports 1 chip as it tries to assign the packet/ > EDID/CEC memory I2C devices to the fixed I2C addresses. Assign these I2C > addresses at the fixed offsets (derived from the programming guide) from > the main register map address instead... > > Signed-off-by: Sergei Shtylyov > > --- > The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch. > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > Index: linux/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > =================================================================== > --- linux.orig/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ linux/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -922,15 +922,13 @@ static int adv7511_parse_dt(struct devic > return 0; > } > > -static const int edid_i2c_addr = 0x7e; > -static const int packet_i2c_addr = 0x70; > -static const int cec_i2c_addr = 0x78; > - > static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id) > { > struct adv7511_link_config link_config; > struct adv7511 *adv7511; > struct device *dev = &i2c->dev; > + unsigned int main_i2c_addr = i2c->addr << 1; > + unsigned int edid_i2c_addr = main_i2c_addr + 4; > unsigned int val; > int ret; > > @@ -991,8 +989,10 @@ static int adv7511_probe(struct i2c_clie > > regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR, edid_i2c_addr); > regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR, > - packet_i2c_addr); > - regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR, cec_i2c_addr); > + main_i2c_addr - 0xa); > + regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR, > + main_i2c_addr - 2); The adv7533.c part of the driver uses cec_i2c_addr to create a another dummy i2c device for CEC. Could you update this patch to derive the cec address from the main i2c address for the ADV7533 part too? Thanks, Archit > + > adv7511_packet_disable(adv7511, 0xffff); > > adv7511->i2c_main = i2c; > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] drm/bridge: adv7511: add support for the 2nd chip Date: Fri, 2 Sep 2016 13:35:10 +0530 Message-ID: <57C932B6.9090503@codeaurora.org> References: <4933961.PFafUbE9pV@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 196876EA20 for ; Fri, 2 Sep 2016 08:05:16 +0000 (UTC) In-Reply-To: <4933961.PFafUbE9pV@wasted.cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov , airlied@linux.ie, dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiA5LzIvMjAxNiAyOjEzIEFNLCBTZXJnZWkgU2h0eWx5b3Ygd3JvdGU6Cj4gVGhlIFJl bmVzYXMgV2hlYXQgYm9hcmQgaGFzIDIgQURWNzUxMyBjaGlwcyBvbiB0aGUgc2FtZSBJMkMgYnVz LCBob3dldmVyCj4gdGhlIEFEVjc1MXggZHJpdmVyIG9ubHkgc3VwcG9ydHMgMSBjaGlwIGFzICBp dCB0cmllcyB0byBhc3NpZ24gdGhlIHBhY2tldC8KPiBFRElEL0NFQyAgbWVtb3J5IEkyQyBkZXZp Y2VzICB0byB0aGUgZml4ZWQgSTJDIGFkZHJlc3Nlcy4gQXNzaWduIHRoZXNlIEkyQwo+IGFkZHJl c3NlcyBhdCB0aGUgZml4ZWQgb2Zmc2V0cyAoZGVyaXZlZCBmcm9tIHRoZSBwcm9ncmFtbWluZyBn dWlkZSkgZnJvbQo+IHRoZSAgbWFpbiByZWdpc3RlciBtYXAgYWRkcmVzcyAgaW5zdGVhZC4uLgo+ Cj4gU2lnbmVkLW9mZi1ieTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29nZW50 ZW1iZWRkZWQuY29tPgo+Cj4gLS0tCj4gVGhlIHBhdGNoIGlzIGFnYWluc3QgRGF2aWQgQWlybGll J3MgJ2xpbnV4LmdpdCcgcmVwbydzICdkcm0tbmV4dCcgYnJhbmNoLgo+Cj4gICBkcml2ZXJzL2dw dS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUxMV9kcnYuYyB8ICAgMTIgKysrKysrLS0tLS0tCj4g ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gSW5k ZXg6IGxpbnV4L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jCj4g PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQo+IC0tLSBsaW51eC5vcmlnL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUx MS9hZHY3NTExX2Rydi5jCj4gKysrIGxpbnV4L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUx MS9hZHY3NTExX2Rydi5jCj4gQEAgLTkyMiwxNSArOTIyLDEzIEBAIHN0YXRpYyBpbnQgYWR2NzUx MV9wYXJzZV9kdChzdHJ1Y3QgZGV2aWMKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPgo+IC1zdGF0aWMg Y29uc3QgaW50IGVkaWRfaTJjX2FkZHIgPSAweDdlOwo+IC1zdGF0aWMgY29uc3QgaW50IHBhY2tl dF9pMmNfYWRkciA9IDB4NzA7Cj4gLXN0YXRpYyBjb25zdCBpbnQgY2VjX2kyY19hZGRyID0gMHg3 ODsKPiAtCj4gICBzdGF0aWMgaW50IGFkdjc1MTFfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmky YywgY29uc3Qgc3RydWN0IGkyY19kZXZpY2VfaWQgKmlkKQo+ICAgewo+ICAgCXN0cnVjdCBhZHY3 NTExX2xpbmtfY29uZmlnIGxpbmtfY29uZmlnOwo+ICAgCXN0cnVjdCBhZHY3NTExICphZHY3NTEx Owo+ICAgCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZpMmMtPmRldjsKPiArCXVuc2lnbmVkIGludCBt YWluX2kyY19hZGRyID0gaTJjLT5hZGRyIDw8IDE7Cj4gKwl1bnNpZ25lZCBpbnQgZWRpZF9pMmNf YWRkciA9IG1haW5faTJjX2FkZHIgKyA0Owo+ICAgCXVuc2lnbmVkIGludCB2YWw7Cj4gICAJaW50 IHJldDsKPgo+IEBAIC05OTEsOCArOTg5LDEwIEBAIHN0YXRpYyBpbnQgYWR2NzUxMV9wcm9iZShz dHJ1Y3QgaTJjX2NsaWUKPgo+ICAgCXJlZ21hcF93cml0ZShhZHY3NTExLT5yZWdtYXAsIEFEVjc1 MTFfUkVHX0VESURfSTJDX0FERFIsIGVkaWRfaTJjX2FkZHIpOwo+ICAgCXJlZ21hcF93cml0ZShh ZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX1BBQ0tFVF9JMkNfQUREUiwKPiAtCQkgICAgIHBh Y2tldF9pMmNfYWRkcik7Cj4gLQlyZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVnbWFwLCBBRFY3NTEx X1JFR19DRUNfSTJDX0FERFIsIGNlY19pMmNfYWRkcik7Cj4gKwkJICAgICBtYWluX2kyY19hZGRy IC0gMHhhKTsKPiArCXJlZ21hcF93cml0ZShhZHY3NTExLT5yZWdtYXAsIEFEVjc1MTFfUkVHX0NF Q19JMkNfQUREUiwKPiArCQkgICAgIG1haW5faTJjX2FkZHIgLSAyKTsKClRoZSBhZHY3NTMzLmMg cGFydCBvZiB0aGUgZHJpdmVyIHVzZXMgY2VjX2kyY19hZGRyIHRvIGNyZWF0ZSBhIGFub3RoZXIK ZHVtbXkgaTJjIGRldmljZSBmb3IgQ0VDLiBDb3VsZCB5b3UgdXBkYXRlIHRoaXMgcGF0Y2ggdG8g ZGVyaXZlIHRoZQpjZWMgYWRkcmVzcyBmcm9tIHRoZSBtYWluIGkyYyBhZGRyZXNzIGZvciB0aGUg QURWNzUzMyBwYXJ0IHRvbz8KClRoYW5rcywKQXJjaGl0Cgo+ICsKPiAgIAlhZHY3NTExX3BhY2tl dF9kaXNhYmxlKGFkdjc1MTEsIDB4ZmZmZik7Cj4KPiAgIAlhZHY3NTExLT5pMmNfbWFpbiA9IGky YzsKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g ZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo+CgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlvbiBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2Yg Q29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXggRm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2pl Y3QKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==