From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH 4/4 v2] drm/bridge: adv7511: Initialize audio packet on adv7533 Date: Fri, 2 Sep 2016 15:19:17 +0530 Message-ID: <57C94B1D.8040509@codeaurora.org> References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <1472514096-10915-5-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id 270936EA41 for ; Fri, 2 Sep 2016 09:49:32 +0000 (UTC) In-Reply-To: <1472514096-10915-5-git-send-email-john.stultz@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz , lkml Cc: Andy Green , Guodong Xu , dri-devel@lists.freedesktop.org, Jose Abreu , Wolfram Sang , Mark Brown , Srinivas Kandagatla , Laurent Pinchart , Andy Green , Zhangfei Gao , Dave Long List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiA4LzMwLzIwMTYgNToxMSBBTSwgSm9obiBTdHVsdHogd3JvdGU6Cj4gRnJvbTogQW5k eSBHcmVlbiA8YW5keS5ncmVlbkBsaW5hcm8ub3JnPgo+Cj4gU2V0IHRoZSBpbml0aWFsIGF1ZGlv IHBhY2tldCBzZXR0aW5ncyB0byBhbGxvdyB0aGUgYXVkaW8KPiBkcml2ZXIgdG8gd29yay4KPgo+ IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IEFyY2hpdCBUYW5lamEg PGFyY2hpdHRAY29kZWF1cm9yYS5vcmc+Cj4gQ2M6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQu cGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBDYzogV29sZnJhbSBTYW5nIDx3c2ErcmVuZXNh c0BzYW5nLWVuZ2luZWVyaW5nLmNvbT4KPiBDYzogU3Jpbml2YXMgS2FuZGFnYXRsYSA8c3Jpbml2 YXMua2FuZGFnYXRsYUBsaW5hcm8ub3JnPgo+IENjOiAiVmlsbGUgU3lyasOkbMOkIiA8dmlsbGUu c3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEJvcmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJl emlsbG9uQGZyZWUtZWxlY3Ryb25zLmNvbT4KPiBDYzogQW5keSBHcmVlbiA8YW5keUB3YXJtY2F0 LmNvbT4KPiBDYzogRGF2ZSBMb25nIDxkYXZlLmxvbmdAbGluYXJvLm9yZz4KPiBDYzogR3VvZG9u ZyBYdSA8Z3VvZG9uZy54dUBsaW5hcm8ub3JnPgo+IENjOiBaaGFuZ2ZlaSBHYW8gPHpoYW5nZmVp Lmdhb0BsaW5hcm8ub3JnPgo+IENjOiBNYXJrIEJyb3duIDxicm9vbmllQGtlcm5lbC5vcmc+Cj4g Q2M6IExhcnMtUGV0ZXIgQ2xhdXNlbiA8bGFyc0BtZXRhZm9vLmRlPgo+IENjOiBKb3NlIEFicmV1 IDxqb2FicmV1QHN5bm9wc3lzLmNvbT4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IFNpZ25lZC1vZmYtYnk6IEFuZHkgR3JlZW4gPGFuZHkuZ3JlZW5AbGluYXJvLm9yZz4K PiBbanN0dWx0ejogRm9yd2FyZCBwb3J0ZWQgdG8gbWFpbmxpbmUsIGNoYW5nZWQgdG8gdXNlIHJl Z2lzdGVyCj4gICBuYW1lcyByYXRoZXIgdGhlbiBoZXggdmFsdWVzLCBhbmQgcmVtb3ZlZCBjb25m aWcgdmFsdWVzIHNldCBieQo+ICAgYXVkaW8gZHJpdmVyLl0KPiBTaWduZWQtb2ZmLWJ5OiBKb2hu IFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvYWR2NzUxMS9hZHY3NTMzLmMgfCAyMiArKysrKysrKysrKysrKysrKysrKysrCj4g ICAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTMzLmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL2Fkdjc1MTEvYWR2NzUzMy5jCj4gaW5kZXggNjc5OGVjZi4uY2NlZDdjOSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2NzUzMy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MzMuYwo+IEBAIC0xMDQsNiArMTA0LDI4 IEBAIHZvaWQgYWR2NzUzM19kc2lfcG93ZXJfb24oc3RydWN0IGFkdjc1MTEgKmFkdikKPiAgIAkv KiBkaXNhYmxlIHRlc3QgbW9kZSAqLwo+ICAgCXJlZ21hcF93cml0ZShhZHYtPnJlZ21hcF9jZWMs IDB4NTUsIDB4MDApOwo+Cj4gKwkvKiBoaWRlIEF1ZGlvIGluZm9mcmFtZSB1cGRhdGVzICovCj4g KwlyZWdtYXBfdXBkYXRlX2JpdHMoYWR2LT5yZWdtYXAsIEFEVjc1MTFfUkVHX0lORk9GUkFNRV9V UERBVEUsCj4gKwkJCQlCSVQoNSksIEJJVCg1KSk7Cj4gKwkvKiBlbmFibGUgTi9DVFMsIGVuYWJs ZSBBdWRpbyBzYW1wbGUgcGFja2V0cyAqLwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKGFkdi0+cmVn bWFwLCBBRFY3NTExX1JFR19QQUNLRVRfRU5BQkxFMSwKPiArCQkJCUJJVCg1KSwgQklUKDUpKTsK PiArCS8qIGVuYWJsZSBOL0NUUyAqLwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKGFkdi0+cmVnbWFw LCBBRFY3NTExX1JFR19QQUNLRVRfRU5BQkxFMSwKPiArCQkJCUJJVCg2KSwgQklUKDYpKTsKPiAr CS8qIG5vdCBjb3B5cmlnaHRlZCAqLwo+ICsJcmVnbWFwX3VwZGF0ZV9iaXRzKGFkdi0+cmVnbWFw LCBBRFY3NTExX1JFR19BVURJT19DRkcxLAo+ICsJCQkJQklUKDUpLCBCSVQoNSkpOwo+ICsJLyog ZW5hYmxlIGF1ZGlvIGluZm9mcmFtZXMgKi8KPiArCXJlZ21hcF91cGRhdGVfYml0cyhhZHYtPnJl Z21hcCwgQURWNzUxMV9SRUdfUEFDS0VUX0VOQUJMRTEsCj4gKwkJCQlCSVQoMyksIEJJVCgzKSk7 Cj4gKwkvKiBBViBtdXRlIGRpc2FibGUgKi8KPiArCXJlZ21hcF91cGRhdGVfYml0cyhhZHYtPnJl Z21hcCwgQURWNzUxMV9SRUdfR0MoMCksCj4gKwkJCQlCSVQoNykgfCBCSVQoNiksIEJJVCg3KSk7 Cj4gKwkvKiB1c2UgQXVkaW8gaW5mb2ZyYW1lIHVwZGF0ZWQgaW5mbyAqLwo+ICsJcmVnbWFwX3Vw ZGF0ZV9iaXRzKGFkdi0+cmVnbWFwLCBBRFY3NTExX1JFR19HQygxKSwKPiArCQkJCUJJVCg1KSwg MCk7Cj4gKwoKV291bGRuJ3QgdGhlc2Ugd3JpdGVzIGJlIG5lZWRlZCBieSBBRFY3NTF4IGNoaXBz IHRvbz8gVGhlc2Ugc2VlbSB0bwpiZWxvbmcgdG8gdGhlIG1haW4gQURWNzV4eCByZWdtYXAuIFRo ZXNlIHNob3VsZCBwcm9iYWJseSBiZSBhIHNlcGFyYXRlIApmdW5jIGluIGFkdjc1MTFfYXVkaW8u YyBvciBhZHY3NTExX2Rydi5jLCBhbmQgaXQgc2hvdWxkIGJlIGNhbGxlZCBpbgphZHY3NTExX3Bv d2VyX29uLCBzbyB0aGF0IEFEVjc1MXggY2hpcHMgY2FuIHV0aWxpemUgdGhpcyB0b28uCgpUaGFu a3MsCkFyY2hpdAoKPiAgIAlyZWdtYXBfcmVnaXN0ZXJfcGF0Y2goYWR2LT5yZWdtYXBfY2VjLCBh ZHY3NTMzX2NlY19maXhlZF9yZWdpc3RlcnMsCj4gICAJCQkgICAgICBBUlJBWV9TSVpFKGFkdjc1 MzNfY2VjX2ZpeGVkX3JlZ2lzdGVycykpOwo+ICAgfQo+CgotLSAKUXVhbGNvbW0gSW5ub3ZhdGlv biBDZW50ZXIsIEluYy4gaXMgYSBtZW1iZXIgb2YgQ29kZSBBdXJvcmEgRm9ydW0sCmEgTGludXgg Rm91bmRhdGlvbiBDb2xsYWJvcmF0aXZlIFByb2plY3QKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752297AbcIBJtg (ORCPT ); Fri, 2 Sep 2016 05:49:36 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44462 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbcIBJtd (ORCPT ); Fri, 2 Sep 2016 05:49:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 9209561F17 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH 4/4 v2] drm/bridge: adv7511: Initialize audio packet on adv7533 To: John Stultz , lkml References: <1472514096-10915-1-git-send-email-john.stultz@linaro.org> <1472514096-10915-5-git-send-email-john.stultz@linaro.org> Cc: Andy Green , David Airlie , Laurent Pinchart , Wolfram Sang , Srinivas Kandagatla , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Boris Brezillon , Andy Green , Dave Long , Guodong Xu , Zhangfei Gao , Mark Brown , Lars-Peter Clausen , Jose Abreu , dri-devel@lists.freedesktop.org From: Archit Taneja Message-ID: <57C94B1D.8040509@codeaurora.org> Date: Fri, 2 Sep 2016 15:19:17 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1472514096-10915-5-git-send-email-john.stultz@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/30/2016 5:11 AM, John Stultz wrote: > From: Andy Green > > Set the initial audio packet settings to allow the audio > driver to work. > > Cc: David Airlie > Cc: Archit Taneja > Cc: Laurent Pinchart > Cc: Wolfram Sang > Cc: Srinivas Kandagatla > Cc: "Ville Syrjälä" > Cc: Boris Brezillon > Cc: Andy Green > Cc: Dave Long > Cc: Guodong Xu > Cc: Zhangfei Gao > Cc: Mark Brown > Cc: Lars-Peter Clausen > Cc: Jose Abreu > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Andy Green > [jstultz: Forward ported to mainline, changed to use register > names rather then hex values, and removed config values set by > audio driver.] > Signed-off-by: John Stultz > --- > drivers/gpu/drm/bridge/adv7511/adv7533.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c b/drivers/gpu/drm/bridge/adv7511/adv7533.c > index 6798ecf..cced7c9 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c > @@ -104,6 +104,28 @@ void adv7533_dsi_power_on(struct adv7511 *adv) > /* disable test mode */ > regmap_write(adv->regmap_cec, 0x55, 0x00); > > + /* hide Audio infoframe updates */ > + regmap_update_bits(adv->regmap, ADV7511_REG_INFOFRAME_UPDATE, > + BIT(5), BIT(5)); > + /* enable N/CTS, enable Audio sample packets */ > + regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1, > + BIT(5), BIT(5)); > + /* enable N/CTS */ > + regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1, > + BIT(6), BIT(6)); > + /* not copyrighted */ > + regmap_update_bits(adv->regmap, ADV7511_REG_AUDIO_CFG1, > + BIT(5), BIT(5)); > + /* enable audio infoframes */ > + regmap_update_bits(adv->regmap, ADV7511_REG_PACKET_ENABLE1, > + BIT(3), BIT(3)); > + /* AV mute disable */ > + regmap_update_bits(adv->regmap, ADV7511_REG_GC(0), > + BIT(7) | BIT(6), BIT(7)); > + /* use Audio infoframe updated info */ > + regmap_update_bits(adv->regmap, ADV7511_REG_GC(1), > + BIT(5), 0); > + Wouldn't these writes be needed by ADV751x chips too? These seem to belong to the main ADV75xx regmap. These should probably be a separate func in adv7511_audio.c or adv7511_drv.c, and it should be called in adv7511_power_on, so that ADV751x chips can utilize this too. Thanks, Archit > regmap_register_patch(adv->regmap_cec, adv7533_cec_fixed_registers, > ARRAY_SIZE(adv7533_cec_fixed_registers)); > } > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project