diff for duplicates of <57C95B88.80909@samsung.com> diff --git a/a/1.txt b/N1/1.txt index a4dbdd4..d64e8c1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hi Javier, -On 2016년 08월 27일 02:49, Javier Martinez Canillas wrote: +On 2016? 08? 27? 02:49, Javier Martinez Canillas wrote: > Hello Chanwoo, > > The patch looks good to me, I just have a few minor comments: @@ -25,7 +25,7 @@ OK. I'll add a comment as following: > [snip] > >> + ->> + tmu_atlas0: tmu@10060000 { +>> + tmu_atlas0: tmu at 10060000 { >> + compatible = "samsung,exynos5433-tmu"; >> + reg = <0x10060000 0x200>; >> + interrupts = <0 95 0>; @@ -39,7 +39,7 @@ OK. I'll use the GIC_SPI at all of them. > > [snip] > ->> + mipi_phy: video-phy@105C0708 { +>> + mipi_phy: video-phy at 105C0708 { >> + compatible = "samsung,exynos5433-mipi-video-phy"; >> + #phy-cells = <1>; >> + samsung,pmu-syscon = <&pmu_system_controller>; @@ -60,7 +60,7 @@ Also, the first MIPI_PHY's address is 0x105c0710. I'll fix it. If you want to add the 'reg' property, I can add DT node as following: - mipi_phy: video-phy@105c0710 { + mipi_phy: video-phy at 105c0710 { reg = <0x105c0710 0x0>; compatible = "samsung,exynos5433-mipi-video-phy"; ... @@ -72,7 +72,7 @@ the base address with of_iomap(). > > [snip] > ->> + usbdrd30: usb@15400000 { +>> + usbdrd30: usb at 15400000 { >> + compatible = "samsung,exynos5250-dwusb3"; >> + clocks = <&cmu_fsys CLK_ACLK_USBDRD30>, >> + <&cmu_fsys CLK_SCLK_USBDRD30>; @@ -107,7 +107,7 @@ But, the usbdrd's base address is 0x15400000. > Ditto, the node doesn't have a unit address but has reg property. OK. I'll modify it as following: - dwc3@15400000 { + dwc3 at 15400000 { > >> + interrupts = <0 231 0>; @@ -117,7 +117,7 @@ OK. I'll modify it as following: >> + }; >> + >> + ->> + usbhost30: usb@15a00000 { +>> + usbhost30: usb at 15a00000 { >> + compatible = "samsung,exynos5250-dwusb3"; >> + clocks = <&cmu_fsys CLK_ACLK_USBHOST30>, >> + <&cmu_fsys CLK_SCLK_USBHOST30>; @@ -148,7 +148,7 @@ This case is same with above 'usbdrd30'. > Ditto, the node doesn't have a unit address but has reg property. I'll modify it as following: - usbdrd_dwc3_0: dwc3@15a00000 { + usbdrd_dwc3_0: dwc3 at 15a00000 { > >> + interrupts = <0 244 0>; @@ -163,7 +163,7 @@ I'll modify it as following: >> + audio-subsystem { I'll modify it as following: - audio-subsystem@11400000 { + audio-subsystem at 11400000 { >> + compatible = "samsung,exynos5433-lpass"; >> + reg = <0x11400000 0x100>, <0x11500000 0x08>; diff --git a/a/content_digest b/N1/content_digest index b33e22e..1c1d46d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,40 +2,15 @@ "ref\01472046551-703-6-git-send-email-cw00.choi@samsung.com\0" "ref\0CGME20160826174936epcas1p3e0fe5d9cd14e17aba25c3109ba899e83@epcas1p3.samsung.com\0" "ref\04341f429-64a9-b14c-aeca-d61aac2ee81d@osg.samsung.com\0" - "From\0Chanwoo Choi <cw00.choi@samsung.com>\0" - "Subject\0Re: [PATCH v2 5/7] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC\0" + "From\0cw00.choi@samsung.com (Chanwoo Choi)\0" + "Subject\0[PATCH v2 5/7] arm64: dts: exynos: Add dts files for Samsung Exynos5433 64bit SoC\0" "Date\0Fri, 02 Sep 2016 19:59:20 +0900\0" - "To\0Javier Martinez Canillas <javier@osg.samsung.com>" - k.kozlowski@samsung.com - kgene@kernel.org - robh+dt@kernel.org - mark.rutland@arm.com - catalin.marinas@arm.com - will.deacon@arm.com - devicetree@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-samsung-soc@vger.kernel.org - " linux-kernel@vger.kernel.org\0" - "Cc\0krzk@kernel.org" - jh80.chung@samsung.com - sw0312.kim@samsung.com - jy0922.shim@samsung.com - inki.dae@samsung.com - jonghwa3.lee@samsung.com - beomho.seo@samsung.com - jaewon02.kim@samsung.com - human.hwang@samsung.com - ideal.song@samsung.com - ingi2.kim@samsung.com - m.szyprowski@samsung.com - a.hajda@samsung.com - s.nawrocki@samsung.com - " chanwoo@kernel.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hi Javier,\n" "\n" - "On 2016\353\205\204 08\354\233\224 27\354\235\274 02:49, Javier Martinez Canillas wrote:\n" + "On 2016? 08? 27? 02:49, Javier Martinez Canillas wrote:\n" "> Hello Chanwoo,\n" "> \n" "> The patch looks good to me, I just have a few minor comments:\n" @@ -60,7 +35,7 @@ "> [snip]\n" "> \n" ">> +\n" - ">> +\t\ttmu_atlas0: tmu@10060000 {\n" + ">> +\t\ttmu_atlas0: tmu at 10060000 {\n" ">> +\t\t\tcompatible = \"samsung,exynos5433-tmu\";\n" ">> +\t\t\treg = <0x10060000 0x200>;\n" ">> +\t\t\tinterrupts = <0 95 0>;\n" @@ -74,7 +49,7 @@ "> \n" "> [snip]\n" "> \n" - ">> +\t\tmipi_phy: video-phy@105C0708 {\n" + ">> +\t\tmipi_phy: video-phy at 105C0708 {\n" ">> +\t\t\tcompatible = \"samsung,exynos5433-mipi-video-phy\";\n" ">> +\t\t\t#phy-cells = <1>;\n" ">> +\t\t\tsamsung,pmu-syscon = <&pmu_system_controller>;\n" @@ -95,7 +70,7 @@ "\n" "If you want to add the 'reg' property, I can add DT node as following:\n" "\n" - "\tmipi_phy: video-phy@105c0710 {\n" + "\tmipi_phy: video-phy at 105c0710 {\n" "\t\treg = <0x105c0710 0x0>;\n" "\t\tcompatible = \"samsung,exynos5433-mipi-video-phy\";\n" "\t\t...\n" @@ -107,7 +82,7 @@ "> \n" "> [snip]\n" "> \n" - ">> +\t\tusbdrd30: usb@15400000 {\n" + ">> +\t\tusbdrd30: usb at 15400000 {\n" ">> +\t\t\tcompatible = \"samsung,exynos5250-dwusb3\";\n" ">> +\t\t\tclocks = <&cmu_fsys CLK_ACLK_USBDRD30>,\n" ">> +\t\t\t\t<&cmu_fsys CLK_SCLK_USBDRD30>;\n" @@ -142,7 +117,7 @@ "> Ditto, the node doesn't have a unit address but has reg property.\n" "\n" "OK. I'll modify it as following:\n" - "\t\t\tdwc3@15400000 {\n" + "\t\t\tdwc3 at 15400000 {\n" "\n" "> \n" ">> +\t\t\t\tinterrupts = <0 231 0>;\n" @@ -152,7 +127,7 @@ ">> +\t\t};\n" ">> +\n" ">> +\n" - ">> +\t\tusbhost30: usb@15a00000 {\n" + ">> +\t\tusbhost30: usb at 15a00000 {\n" ">> +\t\t\tcompatible = \"samsung,exynos5250-dwusb3\";\n" ">> +\t\t\tclocks = <&cmu_fsys CLK_ACLK_USBHOST30>,\n" ">> +\t\t\t\t<&cmu_fsys CLK_SCLK_USBHOST30>;\n" @@ -183,7 +158,7 @@ "> Ditto, the node doesn't have a unit address but has reg property.\n" "\n" "I'll modify it as following:\n" - "\t\t\tusbdrd_dwc3_0: dwc3@15a00000 {\n" + "\t\t\tusbdrd_dwc3_0: dwc3 at 15a00000 {\n" "\n" "> \n" ">> +\t\t\t\tinterrupts = <0 244 0>;\n" @@ -198,7 +173,7 @@ ">> +\t\taudio-subsystem {\n" "\n" "I'll modify it as following:\n" - "\t\taudio-subsystem@11400000 {\n" + "\t\taudio-subsystem at 11400000 {\n" "\n" ">> +\t\t\tcompatible = \"samsung,exynos5433-lpass\";\n" ">> +\t\t\treg = <0x11400000 0x100>, <0x11500000 0x08>;\n" @@ -213,4 +188,4 @@ "Best Regards,\n" Chanwoo Choi -fe94dc41bd9dc5f3d36acc6942eb0533608fcc9266c6f08e04698fab6fa06386 +48a302298d5b2538c459bd1902369469584a3f37a276e75bdab273f7d1e7f7d5
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.