From: Kishon Vijay Abraham I <kishon@ti.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Pramod Kumar <pramod.kumar@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>, Jon Mason <jonmason@broadcom.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops
Date: Fri, 2 Sep 2016 17:46:57 +0530 [thread overview]
Message-ID: <57C96DB9.6080904@ti.com> (raw)
In-Reply-To: <1472565240-31053-2-git-send-email-axel.lin@ingics.com>
On Tuesday 30 August 2016 07:24 PM, Axel Lin wrote:
> Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting.
> While at it, also makes ns2_pci_phy_ops const as it's never get modified.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> Reviewed-and-tested-by: Jon Mason <jon.mason@broadcom.com>
merged, thanks
-Kishon
> ---
> This was sent on http://www.spinics.net/lists/netdev/msg383514.html
> Resent on https://lkml.org/lkml/2016/8/12/659
> drivers/phy/phy-bcm-ns2-pcie.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/phy-bcm-ns2-pcie.c b/drivers/phy/phy-bcm-ns2-pcie.c
> index ee61772..4c7d11d 100644
> --- a/drivers/phy/phy-bcm-ns2-pcie.c
> +++ b/drivers/phy/phy-bcm-ns2-pcie.c
> @@ -47,8 +47,9 @@ err:
> return rc;
> }
>
> -static struct phy_ops ns2_pci_phy_ops = {
> +static const struct phy_ops ns2_pci_phy_ops = {
> .init = ns2_pci_phy_init,
> + .owner = THIS_MODULE,
> };
>
> static int ns2_pci_phy_probe(struct mdio_device *mdiodev)
>
next prev parent reply other threads:[~2016-09-02 12:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 13:53 [RESEND AGAIN][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy Axel Lin
2016-08-30 13:54 ` [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner field in ns2_pci_phy_ops Axel Lin
2016-08-30 14:25 ` Pramod Kumar
2016-09-02 12:16 ` Kishon Vijay Abraham I [this message]
2016-08-30 14:05 ` [RESEND AGAIN][PATCH 1/2] phy: bcm-ns2-pcie: Get rid of struct ns2_pci_phy Kishon Vijay Abraham I
2016-08-30 14:11 ` Axel Lin
2016-08-30 14:25 ` Pramod Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57C96DB9.6080904@ti.com \
--to=kishon@ti.com \
--cc=andrew@lunn.ch \
--cc=axel.lin@ingics.com \
--cc=jonmason@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pramod.kumar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.