All of lore.kernel.org
 help / color / mirror / Atom feed
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: irq_create_fwspec_mapping() in 4.8-rc2
Date: Fri, 2 Sep 2016 16:09:19 +0100	[thread overview]
Message-ID: <57C9961F.8080602@arm.com> (raw)
In-Reply-To: <F5716CCD-34FF-4CA8-B5F5-C2A33A5D9E91@gmail.com>

On 02/09/16 15:52, Andras Szemzo wrote:
>>
>> Can you try this patch and report the values you find?
>>
> Sure, here is the output:
> 
> irq: type mismatch (2/3), failed to map hwirq-11 for /soc/pinctrl at 0x400e0e00/gpio at 0x400e1200!

So something has already configured the interrupt to be
IRQ_TYPE_EDGE_BOTH, and this clashes with your
IRQ_TYPE_EDGE_FALLING.

My bet is on this one:

diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
index 80daead..9f09041 100644
--- a/drivers/pinctrl/pinctrl-at91.c
+++ b/drivers/pinctrl/pinctrl-at91.c
@@ -1614,7 +1614,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
 				   &gpio_irqchip,
 				   0,
 				   handle_edge_irq,
-				   IRQ_TYPE_EDGE_BOTH);
+				   IRQ_TYPE_NONE);
 	if (ret) {
 		dev_err(&pdev->dev, "at91_gpio.%d: Couldn't add irqchip to gpiochip.\n",
 			at91_gpio->pioc_idx);

Can you give it a go and let me know what happens?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2016-09-02 15:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02  6:51 irq_create_fwspec_mapping() in 4.8-rc2 Andras Szemzo
2016-09-02 14:15 ` Marc Zyngier
2016-09-02 14:29   ` Andras Szemzo
2016-09-02 14:47     ` Marc Zyngier
2016-09-02 14:52       ` Andras Szemzo
2016-09-02 15:09         ` Marc Zyngier [this message]
2016-09-02 15:15           ` Andras Szemzo
2016-09-02 15:31             ` Marc Zyngier
2016-09-05 12:40               ` Linus Walleij
2016-09-05 12:56                 ` Marc Zyngier
2016-09-05 21:41                   ` Linus Walleij
2016-09-06  5:53                     ` Nicolas Ferre
2016-09-05 13:10                 ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57C9961F.8080602@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.