From: Heiko Schocher <hs@denx.de>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubifs: compress lines for immediate return
Date: Mon, 5 Sep 2016 08:35:37 +0200 [thread overview]
Message-ID: <57CD1239.6060105@denx.de> (raw)
In-Reply-To: <94271caf-4852-1d08-c6a0-102aac22ab65@nod.at>
Hello Richard,
Am 05.09.2016 um 08:28 schrieb Richard Weinberger:
> Heiko,
>
> On 05.09.2016 06:59, Heiko Schocher wrote:
>> fix the following code:
>>
>> -ret = expression;
>> -if (ret)
>> - return ret;
>> -return 0;
>> +return expression;
>
> "Fix"? ;-)
> What was broken?
Ok, fix is to hard spoken ... nothing broken, sorry for confusing!
> I agree that we can write the expression in a different way, but is it really worth it?
I think yes ...
> Is this part of a tree-wide cleanup?
Yes, and I thought it is worth to change this part in linux too.
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2016-09-05 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 4:59 [PATCH] ubifs: compress lines for immediate return Heiko Schocher
2016-09-05 6:28 ` Richard Weinberger
2016-09-05 6:35 ` Heiko Schocher [this message]
2016-09-05 6:38 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57CD1239.6060105@denx.de \
--to=hs@denx.de \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.