From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bh4LN-0007nt-EJ for qemu-devel@nongnu.org; Mon, 05 Sep 2016 20:34:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bh4LK-0000b1-8i for qemu-devel@nongnu.org; Mon, 05 Sep 2016 20:34:29 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:10986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bh4LJ-0000Zi-CW for qemu-devel@nongnu.org; Mon, 05 Sep 2016 20:34:26 -0400 Message-ID: <57CE0E63.1090507@huawei.com> Date: Tue, 6 Sep 2016 08:31:31 +0800 From: "Longpeng (Mike)" MIME-Version: 1.0 References: <1472782975-20056-1-git-send-email-longpeng2@huawei.com> <20160905185332.GN1151@thinpad.lan.raisama.net> In-Reply-To: <20160905185332.GN1151@thinpad.lan.raisama.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] target-i386: present virtual L3 cache info for vcpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: rth@twiddle.net, pbonzini@redhat.com, mst@redhat.com, zhaoshenglong@huawei.com, arei.gonglei@huawei.com, peter.huangpeng@huawei.com, herongguang.he@huawei.com, qemu-devel@nongnu.org, "Longpeng(Mike)" Hi Eduardo, On 2016/9/6 2:53, Eduardo Habkost wrote: > On Fri, Sep 02, 2016 at 10:22:55AM +0800, Longpeng(Mike) wrote: > [...] >> --- >> Changes since v2: >> - add more useful commit mesage. >> - rename "compat-cache" to "l3-cache-shared". > > What exactly "shared" means here? All the property does is to > enable/disable the L3 cache, as its own description says: > >> >> + /* Compatibility bits for old machine types. >> + * If true present virtual l3 cache for VM. >> + */ >> + bool enable_l3_cache_shared; >> + > > Why not just "l3-cache" or "l3-cache-enabled"? > I wanted to fix l1/l2's inconsistent bugs together originally, so I named it "compat-cache". But later I thought it's too ugly to adding much l1/l2's compatible macros, so I given up this idea. Instead, rename it to "l3-cache-shared". Thanks for your good suggestion. I will choose "l3-cache-enabled" in the v5. -- Regards, Longpeng(Mike)