From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [v14 PATCH 2/5] phy: Add USB Type-C PHY driver for rk3399 Date: Tue, 6 Sep 2016 09:38:31 +0530 Message-ID: <57CE413F.8030203@ti.com> References: <1472015825-11365-1-git-send-email-zyw@rock-chips.com> <1472015825-11365-3-git-send-email-zyw@rock-chips.com> <57CCCA56.5000702@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <57CCCA56.5000702-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Chanwoo Choi , Chris Zhong , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, yzq-TNX95d0MmH7DzftRWevZcw@public.gmane.org, groeck-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org, marcheu-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kever Yang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rockchip.vger.kernel.org SGkgY2hhbndvbywKCk9uIE1vbmRheSAwNSBTZXB0ZW1iZXIgMjAxNiAwNjo1OCBBTSwgQ2hhbndv byBDaG9pIHdyb3RlOgo+IERlYXIgYWxsLAo+IAo+IE9uIDIwMTbrhYQgMDjsm5QgMjTsnbwgMTQ6 MTcsIENocmlzIFpob25nIHdyb3RlOgo+PiBBZGQgYSBQSFkgcHJvdmlkZXIgZHJpdmVyIGZvciB0 aGUgcmszMzk5IFNvQyBUeXBlLWMgUEhZLiBUaGUgVVNCCj4+IFR5cGUtQyBQSFkgaXMgZGVzaWdu ZWQgdG8gc3VwcG9ydCB0aGUgVVNCMyBhbmQgRFAgYXBwbGljYXRpb25zLgo+PiBUaGUgVVNCMyBv cGVyYXRlcyBpbiBTdXBlclNwZWVkIG1vZGUgYW5kIHRoZSBEUCBjYW4gb3BlcmF0ZSBhdCBSQlIs Cj4+IEhCUiBhbmQgSEJSMiBkYXRhIHJhdGVzLiBUaGlzIGRyaXZlciBjcmVhdGUgMiBQSFkgZGV2 aWNlcyBzZXBhcmF0ZWx5Cj4+IGZvciBVU0IzIGFuZCBEaXNwbHlQb3J0LCBhbmQgcmVnaXN0ZXJz IHRoZW0gdW5kZXIgdGhlIGNoaWxkIG5vZGUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFpo b25nIDx6eXdAcm9jay1jaGlwcy5jb20+Cj4+IFNpZ25lZC1vZmYtYnk6IEtldmVyIFlhbmcgPGtl dmVyLnlhbmdAcm9jay1jaGlwcy5jb20+Cj4+IFJldmlld2VkLWJ5OiBHdWVudGVyIFJvZWNrIDxn cm9lY2tAY2hyb21pdW0ub3JnPgo+PiBUZXN0ZWQtYnk6IEd1ZW50ZXIgUm9lY2sgPGdyb2Vja0Bj aHJvbWl1bS5vcmc+Cj4+Cj4+IC0tLQo+Pgo+PiBDaGFuZ2VzIGluIHYxNDoKPj4gLSBjaGFuZ2Ug dGhlIG5hbWUgb2YgcHJvcGVydHkgZnJvbSBzdXBlciBzcGVlZCB0byBFWFRDT05fUFJPUF9VU0Jf U1MKPj4KPj4gQ2hhbmdlcyBpbiB2MTM6Cj4+IC0gYWRkIHNvbWUgZGVzY3JpcHRpb24gaW4gZnJv bnQgb2YgZHJpdmVyCj4+IC0gY2hhbmdlIG5hbWUgb2YgdXNiIHRvIHVzYjMKPj4gLSBhZGQgYSBV U0IzIFJYIHJlZ2lzdGVyIGNvbmZpZ3VyYXRpb24KPj4gLSBkbyBub3QgcmV0dXJuIGVyciBpZiBu b3RoaW5nIGNvbm5lY3RlZCB3aXRoIFR5cGUtQywgd2hlbiB1c2IgcGh5IHBvd2VyIG9uLAo+PiAg IHNpbmNlIHRoZSBVU0IgY29yZSBkcml2ZXIgd2lsbCBjYWxsIHBoeSBwb3dlciB3aXRob3V0IFVT QjMgZGV2aWNlIGNvbm5lY3RlZC4KPj4KPj4gQ2hhbmdlcyBpbiB2MTI6Cj4+IC0gZW5hYmxlIERQ K1VTQjMgbW9kZSwgb25seSB3aGVuIEVYVENPTl9QUk9QX1VTQl9TVVBFUlNQRUVEIGVxdWFsIDEK Pj4gICBhbmQgRFAgaXMgYXR0YWNoZWQKPj4KPj4gQ2hhbmdlcyBpbiB2MTE6Cj4+IC0gbWFrZSBh IGNsZWFyZXIgZGVtYXJjYXRpb24gYmV0d2VlbiB1c2IgcGh5IGFuZCBkcCBwaHkuCj4+Cj4+IENo YW5nZXMgaW4gdjEwOgo+PiAtIGRvIG5vdCBjb250cm9sIGRwIHNlbGVjdCBhbmQgaHBkIGNvbmZp ZyBpbiBwaHkgZHJpdmVyCj4+Cj4+IENoYW5nZXMgaW4gdjk6Cj4+IC0gdGhlIG5ld19tb2RlIHNo b3VsZCBiZSBpbnQgbm90IHU4Cj4+IC0gbW92ZSBtdXRleF9sb2NrKCZ0Y3BoeS0+bG9jayk7IHRv IGVhcmxpZXIgcGxhY2UuIGluCj4+ICAgcm9ja2NoaXBfdXNiM19waHlfcG93ZXJfb2ZmCj4+IC0g YmV0dGVyIG11dGV4IGxvY2sgZm9yIHBoeSBtb2RlIGFuZCBmbGlwCj4+IC0gc3BsaXQgdGhlIFR5 cGUtQyBQSFkgaW50byB0d28gUEhZczogVVNCMyBhbmQgRFAKPj4KPj4gQ2hhbmdlcyBpbiB2ODoK Pj4gLSBzZXQgdGhlIGRlZmF1bHQgY2FibGUgaWQgdG8gRVhUQ09OX1VTQl9IT1NUCj4+IC0gb3B0 aW1pemF0aW9uIEVycm9yIGxvZwo+Pgo+PiBDaGFuZ2VzIGluIHY3Ogo+PiAtIHN1cHBvcnQgbmV3 IEFQSSBvZiBleHRjb24KPj4KPj4gQ2hhbmdlcyBpbiB2NjoKPj4gLSBkZWxldGUgdGhlIHN1cHBv cnQgb2YgUElOX0FTU0lHTl9BL0IKPj4gLSBzZXQgdGhlIGRlZmF1bHQgbW9kZSB0byBNT0RFX0RG UF9VU0IKPj4gLSBkaXNhYmxlIERQIFBMTCBhdCBVU0IzIG9ubHkgbW9kZQo+Pgo+PiBDaGFuZ2Vz IGluIHY1Ogo+PiAtIHN1cHBvcnQgZ2V0IHByb3BlcnR5IGZyb20gZXh0Y29uCj4+IC0gcmVtb3Zl IFBJTiBBU1NJR04gQS9CIHN1cHBvcnQKPj4KPj4gQ2hhbmdlcyBpbiB2NDoKPj4gLSBzZWxlY3Qg RVhUQ09OCj4+IC0gdXNlIHBoeSBmcmFtZXdvcmsgdG8gY29udHJvbCB0aGUgVVNCMyBhbmQgRFAg ZnVuY3Rpb24KPj4gLSByZW5hbWUgUElOX01BUF8gdG8gUElOX0FTU0lHTl8KPj4KPj4gQ2hhbmdl cyBpbiB2MzoKPj4gLSByZW1vdmUgdGhlIHBoeSBmcmFtZXdvcmsoS2lzaG9uIFZpamF5IEFicmFo YW0gSSkKPj4gLSBhZGQgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSBtYWNybwo+PiAtIHVzZSBhIHNp bmdsZSBzcGFjZSBiZXR3ZWVuIHR5cGUgYW5kIG5hbWUKPj4gLSBhZGQgc3BhY2VzIGFmdGVyIG9w ZW5pbmcgYW5kIGJlZm9yZSBjbG9zaW5nIGJyYWNlcy4KPj4gLSB1c2UgdTE2IGZvciByZWdpc3Rl ciB2YWx1ZQo+PiAtIHJlbW92ZSB0eXBlLWMgcGh5IGhlYWRlciBmaWxlCj4+IC0gQ29kaW5nU3R5 bGUgb3B0aW1pemF0aW9uCj4+IC0gdXNlIHNvbWUgY2FibGUgZXh0Y29uIHRvIGdldCB0eXBlLWMg cG9ydCBpbmZvcm1hdGlvbgo+PiAtIGFkZCBhIGV4dGNvbiB0byBub3RpZnkgRGlzcGxheSBQb3J0 Cj4+Cj4+IENoYW5nZXMgaW4gdjI6Cj4+IC0gc2VsZWN0IFJFU0VUX0NPTlRST0xMRVIKPj4gLSBh bHBoYWJldGljIG9yZGVyCj4+IC0gbW9kaWZ5IHNvbWUgc3BlbGxpbmcgbWlzdGFrZXMKPj4gLSBt YWtlIG1vZGUgY2xlYW5lcgo+PiAtIHVzZSBib29sIGZvciBlbmFibGUvZGlzYWJsZQo+PiAtIGNo ZWNrIGFsbCBvZiB0aGUgcmV0dXJuIHZhbHVlCj4+IC0gcmV0dXJuIGEgYmV0dGVyIGVyciBudW1i ZXIKPj4gLSB1c2UgbW9yZSByZWFkeF9wb2xsX3RpbWVvdXQoKQo+PiAtIGNsa19kaXNhYmxlX3Vu cHJlcGFyZSh0Y3BoeS0+Y2xrX3JlZik7Cj4+IC0gcmVtb3ZlIHVudXNlIGZ1bmN0aW9ucywgcm9j a2NoaXBfdHlwZWNfcGh5X3Bvd2VyX29uL29mZgo+PiAtIHJlbW92ZSB1bm5lY2Vzc2FyeSB0eXBl Y2FzdCBmcm9tIHZvaWQgKgo+PiAtIHVzZSBkdHMgbm9kZSB0byBkaXN0aW5ndWlzaCBiZXR3ZWVu IHBoeXMuCj4+Cj4+IENoYW5nZXMgaW4gdjE6Cj4+IC0gdXBkYXRlIHRoZSBsaWNlbmNlIG5vdGUK Pj4gLSBpbml0IGNvcmUgY2xvY2sgdG8gNTBNSHoKPj4gLSB1c2UgZXh0Y29uIEFQSQo+PiAtIHJl bW92ZSB1bnVzZWQgZ2xvYmFsCj4+IC0gYWRkIHNvbWUgY29tbWVudHMgZm9yIG1hZ2ljIG51bQo+ PiAtIGNoYW5nZSB1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCkgdG91c2xlZXBfcmFuZ2UoMTAwMCwg MTA1MCkKPj4gLSByZW1vdmUgX19mdW5jX18gZnJvbSBkZXZfZXJyCj4+IC0gcmV0dXJuIGVyciBu dW1iZXIgd2hlbiBnZXQgY2xrIGZhaWxlZAo+PiAtIHJlbW92ZSBBRERSX0FESiBkZWZpbmUKPj4g LSB1c2UgZGV2bV9jbGtfZ2V0KCZwZGV2LT5kZXYsICJ0Y3BkY29yZSIpCj4+Cj4+ICBkcml2ZXJz L3BoeS9LY29uZmlnICAgICAgICAgICAgICB8ICAgIDkgKwo+PiAgZHJpdmVycy9waHkvTWFrZWZp bGUgICAgICAgICAgICAgfCAgICAxICsKPj4gIGRyaXZlcnMvcGh5L3BoeS1yb2NrY2hpcC10eXBl Yy5jIHwgMTAxMyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgMyBm aWxlcyBjaGFuZ2VkLCAxMDIzIGluc2VydGlvbnMoKykKPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBk cml2ZXJzL3BoeS9waHktcm9ja2NoaXAtdHlwZWMuYwo+Pgo+IAo+IFtzbmlwXQo+IAo+IFRoaXMg cGF0Y2ggcmVseSBvbiB0aGUgZXh0Y29uIGdpdCByZXBvc2l0b3J5IHRvIHN1cHBvcnQgdGhlIGV4 dGNvbiBwcm9wZXJ0eQo+IGFuZCBVU0IgMy4wIHByb3BlcnR5LiBJIGNyZWF0ZWQgdGhlIGltbXV0 YWJsZSBicmFuY2goaWItZXh0Y29uLXBoeS00LjkpLgo+IEkgc2VuZCB0aGlzIHB1bGwgcmVxdWVz dCB0byBwcmV2ZW50IHRoZSBidWlsZCBlcnJvci4KPiAKPiAoVGhlIHBhdGNoZXMgb2YgZXh0Y29u IHByb3BlcnR5IGZvciBVU0IgMy4wIGRlcGVuZCBvbiB0aGUgb3RoZXIgZXh0Y29uIHBhdGNoZXMK PiB3aGljaCBhcmUgYWxyZWFkeSBtZXJnZWQuIFNvLCBpdCBpcyBkaWZmY3VsdCB0byBzZXBhcmF0 ZSB0aGUgb25seSBwYXRjaGVzCj4gb2YgZXh0Y29uIHByb3BlcnR5LikKPiAKPiBCZXN0IFJlZ2Fy ZHMsCj4gQ2hhbndvbyBDaG9pCj4gCj4gVGhlIGZvbGxvd2luZyBjaGFuZ2VzIHNpbmNlIGNvbW1p dCAyOWI0ODE3ZDQwMThkZjc4MDg2MTU3ZWEzYTU1YzFkOTQyNGE3Y2ZjOgo+IAo+ICAgTGludXgg NC44LXJjMSAoMjAxNi0wOC0wNyAxODoxODowMCAtMDcwMCkKPiAKPiBhcmUgYXZhaWxhYmxlIGlu IHRoZSBnaXQgcmVwb3NpdG9yeSBhdDoKPiAKPiAgIGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9z Y20vbGludXgva2VybmVsL2dpdC9jaGFud29vL2V4dGNvbi5naXQgaWItZXh0Y29uLXBoeS00LjkK CkkndmUgaW5jbHVkZWQgdGhpcyBicmFuY2ggaW4gbGludXgtcGh5IG5leHQgZm9yIG1lcmdpbmcg cGh5LXJvY2tjaGlwLXR5cGVjLmMuCgpUaGFua3MKS2lzaG9uCj4gCj4gZm9yIHlvdSB0byBmZXRj aCBjaGFuZ2VzIHVwIHRvIDg0NTdhMWI0OWEyYWYwYTBlNzFmODBhZmVkOWY3YzgwZGUzNjE2MTA6 Cj4gCj4gICBleHRjb246IEludHJvZHVjZSBFWFRDT05fUFJPUF9VU0JfU1MgcHJvcGVydHkgZm9y IFN1cGVyU3BlZWQgbW9kZSAoMjAxNi0wOC0xOCAxMDoyMzozNiArMDkwMCkKPiAKPiAtLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gQ2hhbndvbyBDaG9pICgxMik6Cj4gICAgICAgZXh0Y29uOiBhcml6b25hOiBSZW1vdmUgdGhl IHVzYWdlIG9mIGV4dGNvbl91cGRhdGVfc3RhdGUoKQo+ICAgICAgIGV4dGNvbjogYWRjLWphY2s6 IFJlbW92ZSB0aGUgdXNhZ2Ugb2YgZXh0Y29uX3NldF9zdGF0ZSgpCj4gICAgICAgZXh0Y29uOiBn cGlvOiBSZW1vdmUgdGhlIHVzYWdlIG9mIGV4dGNvbl9zZXRfc3RhdGUoKQo+ICAgICAgIGV4dGNv bjogUmVtb3ZlIHRoZSBzdGF0ZV9zdG9yZSgpIHRvIHByZXZlbnQgdGhlIHdyb25nIGFjY2Vzcwo+ ICAgICAgIGV4dGNvbjogQmxvY2sgdGhlIGJpdCBtYXNraW5nIG9wZXJhdGlvbiBmb3IgY2FibGUg c3RhdGUgZXhjZXB0IGZvciBleHRjb24gY29yZQo+ICAgICAgIGV4dGNvbjogQWRkIHRoZSBleHRj b25fdHlwZSB0byBnYXRoZXIgZWFjaCBjb25uZWN0b3IgaW50byBmaXZlIGNhdGVnb3J5Cj4gICAg ICAgZXh0Y29uOiBBZGQgdGhlIHN1cHBvcnQgZm9yIGV4dGNvbiBwcm9wZXJ0eSBhY2NvcmRpbmcg dG8gZXh0Y29uIHR5cGUKPiAgICAgICBleHRjb246IEFkZCB0aGUgc3VwcG9ydCBmb3IgdGhlIGNh cGFiaWxpdHkgb2YgZWFjaCBwcm9wZXJ0eQo+ICAgICAgIGV4dGNvbjogUmVuYW1lIHRoZSBleHRj b25fc2V0L2dldF9zdGF0ZSgpIHRvIG1haW50YWluIHRoZSBmdW5jdGlvbiBuYW1pbmcgcGF0dGVy bgo+ICAgICAgIGV4dGNvbjogQWRkIHRoZSBzeW5jaHJvbml6YXRpb24gZXh0Y29uIEFQSXMgdG8g c3VwcG9ydCB0aGUgbm90aWZpY2F0aW9uCj4gICAgICAgZXh0Y29uOiBBZGQgbmV3IEVYVENPTl9E SVNQX0hNRCBmb3IgSGVhZC1tb3VudGVkIERpc3BsYXkgZGV2aWNlCj4gICAgICAgZXh0Y29uOiBB ZGQgbmV3IEVYVENPTl9DSEdfV1BUIGZvciBXaXJlbGVzcyBQb3dlciBUcmFuc2ZlciBkZXZpY2UK PiAKPiBDaGFybGVzIEtlZXBheCAoMSk6Cj4gICAgICAgZXh0Y29uOiBhcml6b25hOiBSZW1vdmUg dW5uZWVkZWQgc2VtaS1jb2xvbgo+IAo+IENocmlzIFpob25nICgxKToKPiAgICAgICBleHRjb246 IEFkZCBFWFRDT05fRElTUF9EUCBhbmQgdGhlIHByb3BlcnR5IGZvciBVU0IgVHlwZS1DCj4gCj4g R3VlbnRlciBSb2VjayAoMSk6Cj4gICAgICAgZXh0Y29uOiBJbnRyb2R1Y2UgRVhUQ09OX1BST1Bf VVNCX1NTIHByb3BlcnR5IGZvciBTdXBlclNwZWVkIG1vZGUKPiAKPiBNYW5pbmRlciBTaW5naCAo MSk6Cj4gICAgICAgZXh0Y29uOiBGaXggY29tcGlsZSB0aW1lIHdhcm5pbmcKPiAKPiBTdGVwaGVu IEJveWQgKDEpOgo+ICAgICAgIGV4dGNvbjogTW92ZSBleHRjb25fZ2V0X2VkZXZfYnlfcGhhbmRs ZSgpIGVycm9ycyB0byBkYmcgbGV2ZWwKPiAKPiBWZW5rYXQgUmVkZHkgVGFsbGEgKDEpOgo+ICAg ICAgIGV4dGNvbjogYWRjLWphY2s6IHVwZGF0ZSBjYWJsZSBzdGF0ZSBkdXJpbmcgYm9vdAo+IAo+ ICBkcml2ZXJzL2V4dGNvbi9leHRjb24tYWRjLWphY2suYyAgICAgICB8ICAyNyArLQo+ICBkcml2 ZXJzL2V4dGNvbi9leHRjb24tYXJpem9uYS5jICAgICAgICB8ICAxMyArLQo+ICBkcml2ZXJzL2V4 dGNvbi9leHRjb24tZ3Bpby5jICAgICAgICAgICB8ICAgMiArLQo+ICBkcml2ZXJzL2V4dGNvbi9l eHRjb24uYyAgICAgICAgICAgICAgICB8IDc3NCArKysrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0KPiAgaW5jbHVkZS9saW51eC9leHRjb24uaCAgICAgICAgICAgICAgICAgfCAxODEgKysr KysrKy0KPiAgaW5jbHVkZS9saW51eC9leHRjb24vZXh0Y29uLWFkYy1qYWNrLmggfCAgIDQgKy0K PiAgNiBmaWxlcyBjaGFuZ2VkLCA4MDkgaW5zZXJ0aW9ucygrKSwgMTkyIGRlbGV0aW9ucygtKQo+ IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgt cm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hp cAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Tue, 6 Sep 2016 09:38:31 +0530 Subject: [v14 PATCH 2/5] phy: Add USB Type-C PHY driver for rk3399 In-Reply-To: <57CCCA56.5000702@samsung.com> References: <1472015825-11365-1-git-send-email-zyw@rock-chips.com> <1472015825-11365-3-git-send-email-zyw@rock-chips.com> <57CCCA56.5000702@samsung.com> Message-ID: <57CE413F.8030203@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi chanwoo, On Monday 05 September 2016 06:58 AM, Chanwoo Choi wrote: > Dear all, > > On 2016? 08? 24? 14:17, Chris Zhong wrote: >> Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB >> Type-C PHY is designed to support the USB3 and DP applications. >> The USB3 operates in SuperSpeed mode and the DP can operate at RBR, >> HBR and HBR2 data rates. This driver create 2 PHY devices separately >> for USB3 and DisplyPort, and registers them under the child node. >> >> Signed-off-by: Chris Zhong >> Signed-off-by: Kever Yang >> Reviewed-by: Guenter Roeck >> Tested-by: Guenter Roeck >> >> --- >> >> Changes in v14: >> - change the name of property from super speed to EXTCON_PROP_USB_SS >> >> Changes in v13: >> - add some description in front of driver >> - change name of usb to usb3 >> - add a USB3 RX register configuration >> - do not return err if nothing connected with Type-C, when usb phy power on, >> since the USB core driver will call phy power without USB3 device connected. >> >> Changes in v12: >> - enable DP+USB3 mode, only when EXTCON_PROP_USB_SUPERSPEED equal 1 >> and DP is attached >> >> Changes in v11: >> - make a clearer demarcation between usb phy and dp phy. >> >> Changes in v10: >> - do not control dp select and hpd config in phy driver >> >> Changes in v9: >> - the new_mode should be int not u8 >> - move mutex_lock(&tcphy->lock); to earlier place. in >> rockchip_usb3_phy_power_off >> - better mutex lock for phy mode and flip >> - split the Type-C PHY into two PHYs: USB3 and DP >> >> Changes in v8: >> - set the default cable id to EXTCON_USB_HOST >> - optimization Error log >> >> Changes in v7: >> - support new API of extcon >> >> Changes in v6: >> - delete the support of PIN_ASSIGN_A/B >> - set the default mode to MODE_DFP_USB >> - disable DP PLL at USB3 only mode >> >> Changes in v5: >> - support get property from extcon >> - remove PIN ASSIGN A/B support >> >> Changes in v4: >> - select EXTCON >> - use phy framework to control the USB3 and DP function >> - rename PIN_MAP_ to PIN_ASSIGN_ >> >> Changes in v3: >> - remove the phy framework(Kishon Vijay Abraham I) >> - add parentheses around the macro >> - use a single space between type and name >> - add spaces after opening and before closing braces. >> - use u16 for register value >> - remove type-c phy header file >> - CodingStyle optimization >> - use some cable extcon to get type-c port information >> - add a extcon to notify Display Port >> >> Changes in v2: >> - select RESET_CONTROLLER >> - alphabetic order >> - modify some spelling mistakes >> - make mode cleaner >> - use bool for enable/disable >> - check all of the return value >> - return a better err number >> - use more readx_poll_timeout() >> - clk_disable_unprepare(tcphy->clk_ref); >> - remove unuse functions, rockchip_typec_phy_power_on/off >> - remove unnecessary typecast from void * >> - use dts node to distinguish between phys. >> >> Changes in v1: >> - update the licence note >> - init core clock to 50MHz >> - use extcon API >> - remove unused global >> - add some comments for magic num >> - change usleep_range(1000, 2000) tousleep_range(1000, 1050) >> - remove __func__ from dev_err >> - return err number when get clk failed >> - remove ADDR_ADJ define >> - use devm_clk_get(&pdev->dev, "tcpdcore") >> >> drivers/phy/Kconfig | 9 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-rockchip-typec.c | 1013 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 1023 insertions(+) >> create mode 100644 drivers/phy/phy-rockchip-typec.c >> > > [snip] > > This patch rely on the extcon git repository to support the extcon property > and USB 3.0 property. I created the immutable branch(ib-extcon-phy-4.9). > I send this pull request to prevent the build error. > > (The patches of extcon property for USB 3.0 depend on the other extcon patches > which are already merged. So, it is diffcult to separate the only patches > of extcon property.) > > Best Regards, > Chanwoo Choi > > The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: > > Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git ib-extcon-phy-4.9 I've included this branch in linux-phy next for merging phy-rockchip-typec.c. Thanks Kishon > > for you to fetch changes up to 8457a1b49a2af0a0e71f80afed9f7c80de361610: > > extcon: Introduce EXTCON_PROP_USB_SS property for SuperSpeed mode (2016-08-18 10:23:36 +0900) > > ---------------------------------------------------------------- > Chanwoo Choi (12): > extcon: arizona: Remove the usage of extcon_update_state() > extcon: adc-jack: Remove the usage of extcon_set_state() > extcon: gpio: Remove the usage of extcon_set_state() > extcon: Remove the state_store() to prevent the wrong access > extcon: Block the bit masking operation for cable state except for extcon core > extcon: Add the extcon_type to gather each connector into five category > extcon: Add the support for extcon property according to extcon type > extcon: Add the support for the capability of each property > extcon: Rename the extcon_set/get_state() to maintain the function naming pattern > extcon: Add the synchronization extcon APIs to support the notification > extcon: Add new EXTCON_DISP_HMD for Head-mounted Display device > extcon: Add new EXTCON_CHG_WPT for Wireless Power Transfer device > > Charles Keepax (1): > extcon: arizona: Remove unneeded semi-colon > > Chris Zhong (1): > extcon: Add EXTCON_DISP_DP and the property for USB Type-C > > Guenter Roeck (1): > extcon: Introduce EXTCON_PROP_USB_SS property for SuperSpeed mode > > Maninder Singh (1): > extcon: Fix compile time warning > > Stephen Boyd (1): > extcon: Move extcon_get_edev_by_phandle() errors to dbg level > > Venkat Reddy Talla (1): > extcon: adc-jack: update cable state during boot > > drivers/extcon/extcon-adc-jack.c | 27 +- > drivers/extcon/extcon-arizona.c | 13 +- > drivers/extcon/extcon-gpio.c | 2 +- > drivers/extcon/extcon.c | 774 ++++++++++++++++++++++++++------- > include/linux/extcon.h | 181 +++++++- > include/linux/extcon/extcon-adc-jack.h | 4 +- > 6 files changed, 809 insertions(+), 192 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbcIFEJ1 (ORCPT ); Tue, 6 Sep 2016 00:09:27 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:47236 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbcIFEJY (ORCPT ); Tue, 6 Sep 2016 00:09:24 -0400 Subject: Re: [v14 PATCH 2/5] phy: Add USB Type-C PHY driver for rk3399 To: Chanwoo Choi , Chris Zhong , , , , , , , , , References: <1472015825-11365-1-git-send-email-zyw@rock-chips.com> <1472015825-11365-3-git-send-email-zyw@rock-chips.com> <57CCCA56.5000702@samsung.com> CC: , Kever Yang , , From: Kishon Vijay Abraham I Message-ID: <57CE413F.8030203@ti.com> Date: Tue, 6 Sep 2016 09:38:31 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <57CCCA56.5000702@samsung.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi chanwoo, On Monday 05 September 2016 06:58 AM, Chanwoo Choi wrote: > Dear all, > > On 2016년 08월 24일 14:17, Chris Zhong wrote: >> Add a PHY provider driver for the rk3399 SoC Type-c PHY. The USB >> Type-C PHY is designed to support the USB3 and DP applications. >> The USB3 operates in SuperSpeed mode and the DP can operate at RBR, >> HBR and HBR2 data rates. This driver create 2 PHY devices separately >> for USB3 and DisplyPort, and registers them under the child node. >> >> Signed-off-by: Chris Zhong >> Signed-off-by: Kever Yang >> Reviewed-by: Guenter Roeck >> Tested-by: Guenter Roeck >> >> --- >> >> Changes in v14: >> - change the name of property from super speed to EXTCON_PROP_USB_SS >> >> Changes in v13: >> - add some description in front of driver >> - change name of usb to usb3 >> - add a USB3 RX register configuration >> - do not return err if nothing connected with Type-C, when usb phy power on, >> since the USB core driver will call phy power without USB3 device connected. >> >> Changes in v12: >> - enable DP+USB3 mode, only when EXTCON_PROP_USB_SUPERSPEED equal 1 >> and DP is attached >> >> Changes in v11: >> - make a clearer demarcation between usb phy and dp phy. >> >> Changes in v10: >> - do not control dp select and hpd config in phy driver >> >> Changes in v9: >> - the new_mode should be int not u8 >> - move mutex_lock(&tcphy->lock); to earlier place. in >> rockchip_usb3_phy_power_off >> - better mutex lock for phy mode and flip >> - split the Type-C PHY into two PHYs: USB3 and DP >> >> Changes in v8: >> - set the default cable id to EXTCON_USB_HOST >> - optimization Error log >> >> Changes in v7: >> - support new API of extcon >> >> Changes in v6: >> - delete the support of PIN_ASSIGN_A/B >> - set the default mode to MODE_DFP_USB >> - disable DP PLL at USB3 only mode >> >> Changes in v5: >> - support get property from extcon >> - remove PIN ASSIGN A/B support >> >> Changes in v4: >> - select EXTCON >> - use phy framework to control the USB3 and DP function >> - rename PIN_MAP_ to PIN_ASSIGN_ >> >> Changes in v3: >> - remove the phy framework(Kishon Vijay Abraham I) >> - add parentheses around the macro >> - use a single space between type and name >> - add spaces after opening and before closing braces. >> - use u16 for register value >> - remove type-c phy header file >> - CodingStyle optimization >> - use some cable extcon to get type-c port information >> - add a extcon to notify Display Port >> >> Changes in v2: >> - select RESET_CONTROLLER >> - alphabetic order >> - modify some spelling mistakes >> - make mode cleaner >> - use bool for enable/disable >> - check all of the return value >> - return a better err number >> - use more readx_poll_timeout() >> - clk_disable_unprepare(tcphy->clk_ref); >> - remove unuse functions, rockchip_typec_phy_power_on/off >> - remove unnecessary typecast from void * >> - use dts node to distinguish between phys. >> >> Changes in v1: >> - update the licence note >> - init core clock to 50MHz >> - use extcon API >> - remove unused global >> - add some comments for magic num >> - change usleep_range(1000, 2000) tousleep_range(1000, 1050) >> - remove __func__ from dev_err >> - return err number when get clk failed >> - remove ADDR_ADJ define >> - use devm_clk_get(&pdev->dev, "tcpdcore") >> >> drivers/phy/Kconfig | 9 + >> drivers/phy/Makefile | 1 + >> drivers/phy/phy-rockchip-typec.c | 1013 ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 1023 insertions(+) >> create mode 100644 drivers/phy/phy-rockchip-typec.c >> > > [snip] > > This patch rely on the extcon git repository to support the extcon property > and USB 3.0 property. I created the immutable branch(ib-extcon-phy-4.9). > I send this pull request to prevent the build error. > > (The patches of extcon property for USB 3.0 depend on the other extcon patches > which are already merged. So, it is diffcult to separate the only patches > of extcon property.) > > Best Regards, > Chanwoo Choi > > The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: > > Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git ib-extcon-phy-4.9 I've included this branch in linux-phy next for merging phy-rockchip-typec.c. Thanks Kishon > > for you to fetch changes up to 8457a1b49a2af0a0e71f80afed9f7c80de361610: > > extcon: Introduce EXTCON_PROP_USB_SS property for SuperSpeed mode (2016-08-18 10:23:36 +0900) > > ---------------------------------------------------------------- > Chanwoo Choi (12): > extcon: arizona: Remove the usage of extcon_update_state() > extcon: adc-jack: Remove the usage of extcon_set_state() > extcon: gpio: Remove the usage of extcon_set_state() > extcon: Remove the state_store() to prevent the wrong access > extcon: Block the bit masking operation for cable state except for extcon core > extcon: Add the extcon_type to gather each connector into five category > extcon: Add the support for extcon property according to extcon type > extcon: Add the support for the capability of each property > extcon: Rename the extcon_set/get_state() to maintain the function naming pattern > extcon: Add the synchronization extcon APIs to support the notification > extcon: Add new EXTCON_DISP_HMD for Head-mounted Display device > extcon: Add new EXTCON_CHG_WPT for Wireless Power Transfer device > > Charles Keepax (1): > extcon: arizona: Remove unneeded semi-colon > > Chris Zhong (1): > extcon: Add EXTCON_DISP_DP and the property for USB Type-C > > Guenter Roeck (1): > extcon: Introduce EXTCON_PROP_USB_SS property for SuperSpeed mode > > Maninder Singh (1): > extcon: Fix compile time warning > > Stephen Boyd (1): > extcon: Move extcon_get_edev_by_phandle() errors to dbg level > > Venkat Reddy Talla (1): > extcon: adc-jack: update cable state during boot > > drivers/extcon/extcon-adc-jack.c | 27 +- > drivers/extcon/extcon-arizona.c | 13 +- > drivers/extcon/extcon-gpio.c | 2 +- > drivers/extcon/extcon.c | 774 ++++++++++++++++++++++++++------- > include/linux/extcon.h | 181 +++++++- > include/linux/extcon/extcon-adc-jack.h | 4 +- > 6 files changed, 809 insertions(+), 192 deletions(-) >