From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756201AbcIFNzd (ORCPT ); Tue, 6 Sep 2016 09:55:33 -0400 Received: from mga09.intel.com ([134.134.136.24]:22899 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755578AbcIFNz3 (ORCPT ); Tue, 6 Sep 2016 09:55:29 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,291,1470726000"; d="scan'208";a="757640645" Subject: Re: [PATCH] usb: xhci-plat: Add generic PHY support To: Srinath Mannam , Felipe Balbi References: <20160714083354.10220-1-srinath.mannam@broadcom.com> <87a8hkilpe.fsf@linux.intel.com> Cc: BCM Kernel Feedback , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Scott Branden , Ray Jui From: Mathias Nyman Message-ID: <57CECAB8.6060402@linux.intel.com> Date: Tue, 6 Sep 2016 16:55:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.08.2016 10:26, Srinath Mannam wrote: > Hi Mathias Nyman, > > Could you please provide your inputs on this? > If you find it in good condition, please consider it for the next release. > I'm not that involved in the usb phy or generic phy, but to me it looks like we should let usb core handle this and not duplicate any more of the phy code to xhci-plat.c usb_add_hcd() in hcd.c already takes care of both usb phy and generic phy cases, I'd like to remove the phy code from xhci-plat.c if possible, but haven't looked into if there are some parts that must be done in xhci-plat.c still. -Mathias