Re: [PATCH v2] irqchip/gic: Allow self-SGIs for SMP on UP configurations

[Marc Zyngier <marc.zyngier@arm.com>]

On 09/09/16 16:31, Fabio Estevam wrote:
> Hi Marc,
> 
> On Fri, Sep 9, 2016 at 11:40 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> Hi Fabio,
>>
>> On 09/09/16 14:44, Fabio Estevam wrote:
>>> From: Marc Zyngier <marc.zyngier@arm.com>
>>>
>>> commit 059e232089e45b0befc9933d31209c225e08b426 upstream.
>>>
>>> On systems where a single CPU is present, the GIC may not support
>>> having SGIs delivered to a target list. In that case, we use the
>>> self-SGI mechanism to allow the interrupt to be delivered locally.
>>>
>>> Cc: <stable@vger.kernel.org> # 4.7.x
>>> Tested-by: Fabio Estevam <fabio.estevam@nxp.com>
>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>>
>> I'm sorry, but what is the justification for this to be backported to a
>> stable kernel? It is not a regression, since we never supported this
> 
> Without this patch imx6ul SoC hangs after a 'reboot' command.

But that's not a regression, right? It *never* worked before, as far as
I know, because we never supported such a configuration in the past.

I'm a bit concerned when I see backporting random patches to random
kernel versions for things that are not bugs. I'll leave it up to Greg
to decide, but I thought I should point out what this patch actually is.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...