All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark yao <mark.yao@rock-chips.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, airlied@linux.ie, heiko@sntech.de
Cc: arnd@arndb.de, xie.baoyou@zte.com.cn,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: add missing header dependencies
Date: Sat, 10 Sep 2016 10:59:19 +0800	[thread overview]
Message-ID: <57D37707.8050607@rock-chips.com> (raw)
In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org>

On 2016年09月07日 18:53, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes]
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: no previous prototype for 'rockchip_drm_fbdev_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared
> in drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 +
>   1 file changed, 1 insertion(+)

Applied to my drm-fixes, Thanks

> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 207e01d..a16c69f 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -20,6 +20,7 @@
>   #include "rockchip_drm_drv.h"
>   #include "rockchip_drm_gem.h"
>   #include "rockchip_drm_fb.h"
> +#include "rockchip_drm_fbdev.h"
>   
>   #define PREFERRED_BPP		32
>   #define to_drm_private(x) \


-- 
Ｍark Yao


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: add missing header dependencies
Date: Sat, 10 Sep 2016 10:59:19 +0800	[thread overview]
Message-ID: <57D37707.8050607@rock-chips.com> (raw)
In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org>

On 2016?09?07? 18:53, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes]
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: no previous prototype for 'rockchip_drm_fbdev_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared
> in drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 +
>   1 file changed, 1 insertion(+)

Applied to my drm-fixes, Thanks

> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 207e01d..a16c69f 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -20,6 +20,7 @@
>   #include "rockchip_drm_drv.h"
>   #include "rockchip_drm_gem.h"
>   #include "rockchip_drm_fb.h"
> +#include "rockchip_drm_fbdev.h"
>   
>   #define PREFERRED_BPP		32
>   #define to_drm_private(x) \


-- 
?ark Yao

WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, airlied@linux.ie, heiko@sntech.de
Cc: dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	arnd@arndb.de, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] drm/rockchip: add missing header dependencies
Date: Sat, 10 Sep 2016 10:59:19 +0800	[thread overview]
Message-ID: <57D37707.8050607@rock-chips.com> (raw)
In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org>

On 2016年09月07日 18:53, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes]
> drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: no previous prototype for 'rockchip_drm_fbdev_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared
> in drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
>   drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 +
>   1 file changed, 1 insertion(+)

Applied to my drm-fixes, Thanks

> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> index 207e01d..a16c69f 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c
> @@ -20,6 +20,7 @@
>   #include "rockchip_drm_drv.h"
>   #include "rockchip_drm_gem.h"
>   #include "rockchip_drm_fb.h"
> +#include "rockchip_drm_fbdev.h"
>   
>   #define PREFERRED_BPP		32
>   #define to_drm_private(x) \


-- 
Ｍark Yao

  reply	other threads:[~2016-09-10  2:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 10:53 [PATCH] drm/rockchip: add missing header dependencies Baoyou Xie
2016-09-07 10:53 ` Baoyou Xie
2016-09-10  2:59 ` Mark yao [this message]
2016-09-10  2:59   ` Mark yao
2016-09-10  2:59   ` Mark yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57D37707.8050607@rock-chips.com \
    --to=mark.yao@rock-chips.com \
    --cc=airlied@linux.ie \
    --cc=arnd@arndb.de \
    --cc=baoyou.xie@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.