From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: add missing header dependencies Date: Sat, 10 Sep 2016 10:59:19 +0800 Message-ID: <57D37707.8050607@rock-chips.com> References: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Baoyou Xie , airlied@linux.ie, heiko@sntech.de Cc: arnd@arndb.de, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA55pyIMDfml6UgMTg6NTMsIEJhb3lvdSBYaWUgd3JvdGU6Cj4gV2UgZ2V0IDIg d2FybmluZ3Mgd2hlbiBidWlsZGluZyBrZXJuZWwgd2l0aCBXPTE6Cj4gZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV9mYmRldi5jOjEzMDo1OiB3YXJuaW5nOiBubyBwcmV2aW91 cyBwcm90b3R5cGUgZm9yICdyb2NrY2hpcF9kcm1fZmJkZXZfaW5pdCcgWy1XbWlzc2luZy1wcm90 b3R5cGVzXQo+IGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZmJkZXYuYzox NzM6Njogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciAncm9ja2NoaXBfZHJtX2Zi ZGV2X2ZpbmknIFstV21pc3NpbmctcHJvdG90eXBlc10KPgo+IEluIGZhY3QsIHRoZXNlIGZ1bmN0 aW9ucyBhcmUgZGVjbGFyZWQKPiBpbiBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBf ZHJtX2ZiZGV2LmgsCj4gc28gdGhpcyBwYXRjaCBhZGRzIG1pc3NpbmcgaGVhZGVyIGRlcGVuZGVu Y2llcy4KPgo+IFNpZ25lZC1vZmYtYnk6IEJhb3lvdSBYaWUgPGJhb3lvdS54aWVAbGluYXJvLm9y Zz4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZmJkZXYu YyB8IDEgKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCgpBcHBsaWVkIHRvIG15 IGRybS1maXhlcywgVGhhbmtzCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvcm9ja2NoaXBfZHJtX2ZiZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2No aXBfZHJtX2ZiZGV2LmMKPiBpbmRleCAyMDdlMDFkLi5hMTZjNjlmIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZmJkZXYuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZmJkZXYuYwo+IEBAIC0yMCw2ICsyMCw3 IEBACj4gICAjaW5jbHVkZSAicm9ja2NoaXBfZHJtX2Rydi5oIgo+ICAgI2luY2x1ZGUgInJvY2tj aGlwX2RybV9nZW0uaCIKPiAgICNpbmNsdWRlICJyb2NrY2hpcF9kcm1fZmIuaCIKPiArI2luY2x1 ZGUgInJvY2tjaGlwX2RybV9mYmRldi5oIgo+ICAgCj4gICAjZGVmaW5lIFBSRUZFUlJFRF9CUFAJ CTMyCj4gICAjZGVmaW5lIHRvX2RybV9wcml2YXRlKHgpIFwKCgotLSAK77ytYXJrIFlhbwoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Sat, 10 Sep 2016 10:59:19 +0800 Subject: [PATCH] drm/rockchip: add missing header dependencies In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> References: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> Message-ID: <57D37707.8050607@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?09?07? 18:53, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: no previous prototype for 'rockchip_drm_fbdev_fini' [-Wmissing-prototypes] > > In fact, these functions are declared > in drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 + > 1 file changed, 1 insertion(+) Applied to my drm-fixes, Thanks > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > index 207e01d..a16c69f 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > @@ -20,6 +20,7 @@ > #include "rockchip_drm_drv.h" > #include "rockchip_drm_gem.h" > #include "rockchip_drm_fb.h" > +#include "rockchip_drm_fbdev.h" > > #define PREFERRED_BPP 32 > #define to_drm_private(x) \ -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753287AbcIJC7d (ORCPT ); Fri, 9 Sep 2016 22:59:33 -0400 Received: from regular1.263xmail.com ([211.150.99.136]:55730 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751537AbcIJC7c (ORCPT ); Fri, 9 Sep 2016 22:59:32 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED4: 1 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: xie.baoyou@zte.com.cn X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: add missing header dependencies To: Baoyou Xie , airlied@linux.ie, heiko@sntech.de References: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Mark yao Message-ID: <57D37707.8050607@rock-chips.com> Date: Sat, 10 Sep 2016 10:59:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1473245580-538-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年09月07日 18:53, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:130:5: warning: no previous prototype for 'rockchip_drm_fbdev_init' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:173:6: warning: no previous prototype for 'rockchip_drm_fbdev_fini' [-Wmissing-prototypes] > > In fact, these functions are declared > in drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 1 + > 1 file changed, 1 insertion(+) Applied to my drm-fixes, Thanks > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > index 207e01d..a16c69f 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > @@ -20,6 +20,7 @@ > #include "rockchip_drm_drv.h" > #include "rockchip_drm_gem.h" > #include "rockchip_drm_fb.h" > +#include "rockchip_drm_fbdev.h" > > #define PREFERRED_BPP 32 > #define to_drm_private(x) \ -- Ｍark Yao