From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: mark symbols static where possible Date: Sat, 10 Sep 2016 10:59:34 +0800 Message-ID: <57D37716.5000902@rock-chips.com> References: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Baoyou Xie , airlied@linux.ie, heiko@sntech.de Cc: arnd@arndb.de, xie.baoyou@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDA55pyIMDfml6UgMTk6MDEsIEJhb3lvdSBYaWUgd3JvdGU6Cj4gV2UgZ2V0IDIg d2FybmluZ3Mgd2hlbiBidWlsZGluZyBrZXJuZWwgd2l0aCBXPTE6Cj4gZHJpdmVycy9ncHUvZHJt L3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYzozMDk6Njogd2FybmluZzogbm8gcHJldmlvdXMg cHJvdG90eXBlIGZvciAncm9ja2NoaXBfZHJtX2ZiX3N1c3BlbmQnIFstV21pc3NpbmctcHJvdG90 eXBlc10KPiBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jOjMxODo2 OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9yICdyb2NrY2hpcF9kcm1fZmJfcmVz dW1lJyBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCj4KPiBJbiBmYWN0LCB0aGVzZSBmdW5jdGlvbnMg YXJlIG9ubHkgdXNlZCBpbiB0aGUgZmlsZSBpbiB3aGljaCB0aGV5IGFyZQo+IGRlY2xhcmVkIGFu ZCBkb24ndCBuZWVkIGEgZGVjbGFyYXRpb24sIGJ1dCBjYW4gYmUgbWFkZSBzdGF0aWMuCj4gU28g dGhpcyBwYXRjaCBtYXJrcyB0aGVzZSBmdW5jdGlvbnMgd2l0aCAnc3RhdGljJy4KPgo+IFNpZ25l ZC1vZmYtYnk6IEJhb3lvdSBYaWUgPGJhb3lvdS54aWVAbGluYXJvLm9yZz4KPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMgfCA0ICsrLS0KPiAgIDEg ZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpBcHBsaWVkIHRv IG15IGRybS1maXhlcywgVGhhbmtzCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tj aGlwX2RybV9kcnYuYwo+IGluZGV4IGE4MjJkNDkuLjM3MjM2ODMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZHJ2LmMKPiBAQCAtMzA2LDcgKzMwNiw3IEBA IHN0YXRpYyBzdHJ1Y3QgZHJtX2RyaXZlciByb2NrY2hpcF9kcm1fZHJpdmVyID0gewo+ICAgfTsK PiAgIAo+ICAgI2lmZGVmIENPTkZJR19QTV9TTEVFUAo+IC12b2lkIHJvY2tjaGlwX2RybV9mYl9z dXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pCj4gK3N0YXRpYyB2b2lkIHJvY2tjaGlwX2Ry bV9mYl9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pCj4gICB7Cj4gICAJc3RydWN0IHJv Y2tjaGlwX2RybV9wcml2YXRlICpwcml2ID0gZHJtLT5kZXZfcHJpdmF0ZTsKPiAgIAo+IEBAIC0z MTUsNyArMzE1LDcgQEAgdm9pZCByb2NrY2hpcF9kcm1fZmJfc3VzcGVuZChzdHJ1Y3QgZHJtX2Rl dmljZSAqZHJtKQo+ICAgCWNvbnNvbGVfdW5sb2NrKCk7Cj4gICB9Cj4gICAKPiAtdm9pZCByb2Nr Y2hpcF9kcm1fZmJfcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNlICpkcm0pCj4gK3N0YXRpYyB2b2lk IHJvY2tjaGlwX2RybV9mYl9yZXN1bWUoc3RydWN0IGRybV9kZXZpY2UgKmRybSkKPiAgIHsKPiAg IAlzdHJ1Y3Qgcm9ja2NoaXBfZHJtX3ByaXZhdGUgKnByaXYgPSBkcm0tPmRldl9wcml2YXRlOwo+ ICAgCgoKLS0gCu+8rWFyayBZYW8g5aea5pm65oOFCgpSb2NrY2hpcCDnpo/lt57nkZ7oiq/lvq7n lLXlrZDmnInpmZDlhazlj7gKCkZ1emhvdSBIZWFkcXVhcnRlcnMKCkFkZHI6Tm8uMjEgQnVpbGRp bmcsIEEgRGlzdHJpY3QsIEZ1emhvdQoKU29mdHdhcmUgUGFyaywgODkgU29mdCBBdmVudWUsIFRv bmdwYW4gUm9hZCwKCkd1bG91IERpc3RyaWN0LCBGdXpob3UgKDM1MDAwMykKCuWcsOWdgDrnpo/l u7rnnIHnpo/lt57luILpk5znm5jot6/ova/ku7blpKfpgZM4OeWPt+i9r+S7tuWbrUHljLoyMeWP t+alvCAoMzUwMDAzKQoKVGVsOu+8iDg2LTA1OTHvvIk4Mzk5MTkwNiAtIDgyOTYKCkUtbWFpbDpt YXJrLnlhb0Byb2NrLWNoaXBzLmNvbQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Sat, 10 Sep 2016 10:59:34 +0800 Subject: [PATCH] drm/rockchip: mark symbols static where possible In-Reply-To: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> References: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> Message-ID: <57D37716.5000902@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?09?07? 19:01, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6: warning: no previous prototype for 'rockchip_drm_fb_resume' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to my drm-fixes, Thanks > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index a822d49..3723683 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -306,7 +306,7 @@ static struct drm_driver rockchip_drm_driver = { > }; > > #ifdef CONFIG_PM_SLEEP > -void rockchip_drm_fb_suspend(struct drm_device *drm) > +static void rockchip_drm_fb_suspend(struct drm_device *drm) > { > struct rockchip_drm_private *priv = drm->dev_private; > > @@ -315,7 +315,7 @@ void rockchip_drm_fb_suspend(struct drm_device *drm) > console_unlock(); > } > > -void rockchip_drm_fb_resume(struct drm_device *drm) > +static void rockchip_drm_fb_resume(struct drm_device *drm) > { > struct rockchip_drm_private *priv = drm->dev_private; > -- ?ark Yao ??? Rockchip ??????????? Fuzhou Headquarters Addr:No.21 Building, A District, Fuzhou Software Park, 89 Soft Avenue, Tongpan Road, Gulou District, Fuzhou (350003) ??:?????????????89????A?21?? (350003) Tel:?86-0591?83991906 - 8296 E-mail:mark.yao at rock-chips.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753861AbcIJC7p (ORCPT ); Fri, 9 Sep 2016 22:59:45 -0400 Received: from regular1.263xmail.com ([211.150.99.141]:48018 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753376AbcIJC7n (ORCPT ); Fri, 9 Sep 2016 22:59:43 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED4: 1 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: xie.baoyou@zte.com.cn X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <1b82b31ea38ca9f9e138e139516bd4e6> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: mark symbols static where possible To: Baoyou Xie , airlied@linux.ie, heiko@sntech.de References: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Mark yao Message-ID: <57D37716.5000902@rock-chips.com> Date: Sat, 10 Sep 2016 10:59:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1473246088-780-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年09月07日 19:01, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:309:6: warning: no previous prototype for 'rockchip_drm_fb_suspend' [-Wmissing-prototypes] > drivers/gpu/drm/rockchip/rockchip_drm_drv.c:318:6: warning: no previous prototype for 'rockchip_drm_fb_resume' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to my drm-fixes, Thanks > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > index a822d49..3723683 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c > @@ -306,7 +306,7 @@ static struct drm_driver rockchip_drm_driver = { > }; > > #ifdef CONFIG_PM_SLEEP > -void rockchip_drm_fb_suspend(struct drm_device *drm) > +static void rockchip_drm_fb_suspend(struct drm_device *drm) > { > struct rockchip_drm_private *priv = drm->dev_private; > > @@ -315,7 +315,7 @@ void rockchip_drm_fb_suspend(struct drm_device *drm) > console_unlock(); > } > > -void rockchip_drm_fb_resume(struct drm_device *drm) > +static void rockchip_drm_fb_resume(struct drm_device *drm) > { > struct rockchip_drm_private *priv = drm->dev_private; > -- Ｍark Yao 姚智情 Rockchip 福州瑞芯微电子有限公司 Fuzhou Headquarters Addr:No.21 Building, A District, Fuzhou Software Park, 89 Soft Avenue, Tongpan Road, Gulou District, Fuzhou (350003) 地址:福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003) Tel:（86-0591）83991906 - 8296 E-mail:mark.yao@rock-chips.com