From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhoucm1 Subject: Re: [PATCH] drm/amdgpu: move some release handles into fail labels Date: Mon, 12 Sep 2016 10:40:35 +0800 Message-ID: <57D615A3.8050806@amd.com> References: <1473646581-25186-1-git-send-email-ray.huang@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1473646581-25186-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Huang Rui , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Alex Deucher , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= CgpPbiAyMDE25bm0MDnmnIgxMuaXpSAxMDoxNiwgSHVhbmcgUnVpIHdyb3RlOgo+IENsZWFuIHVw IHRoZSBjb2RlcyB0byBtb3ZlIHRoZSByZWxlYXNlIGhhbmRsZXMgaW50byBmYWlsIGxhYmVscy4K Pgo+IFNpZ25lZC1vZmYtYnk6IEh1YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+ClJldmlld2Vk LWJ5OiBDaHVubWluZyBaaG91IDxkYXZpZDEuemhvdUBhbWQuY29tPgo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmMgfCAyMSArKysrKysrKysrLS0tLS0t LS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMo LSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNv ZGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jCj4gaW5kZXgg NWNjOTVmMS4uNGE1YzIxMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdw dS9hbWRncHVfdWNvZGUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw dV91Y29kZS5jCj4gQEAgLTI0NywzNSArMjQ3LDI4IEBAIGludCBhbWRncHVfdWNvZGVfaW5pdF9i byhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikKPiAgIAljb25zdCBzdHJ1Y3QgY29tbW9uX2Zp cm13YXJlX2hlYWRlciAqaGVhZGVyID0gTlVMTDsKPiAgIAo+ICAgCWVyciA9IGFtZGdwdV9ib19j cmVhdGUoYWRldiwgYWRldi0+ZmlybXdhcmUuZndfc2l6ZSwgUEFHRV9TSVpFLCB0cnVlLAo+IC0J CQlBTURHUFVfR0VNX0RPTUFJTl9HVFQsIDAsIE5VTEwsIE5VTEwsIGJvKTsKPiArCQkJICAgICAg IEFNREdQVV9HRU1fRE9NQUlOX0dUVCwgMCwgTlVMTCwgTlVMTCwgYm8pOwo+ICAgCWlmIChlcnIp IHsKPiAgIAkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBhbGxvY2F0 ZSBmYWlsZWRcbiIsIGVycik7Cj4gLQkJZXJyID0gLUVOT01FTTsKPiAgIAkJZ290byBmYWlsZWQ7 Cj4gICAJfQo+ICAgCj4gICAJZXJyID0gYW1kZ3B1X2JvX3Jlc2VydmUoKmJvLCBmYWxzZSk7Cj4g ICAJaWYgKGVycikgewo+IC0JCWFtZGdwdV9ib191bnJlZihibyk7Cj4gICAJCWRldl9lcnIoYWRl di0+ZGV2LCAiKCVkKSBGaXJtd2FyZSBidWZmZXIgcmVzZXJ2ZSBmYWlsZWRcbiIsIGVycik7Cj4g LQkJZ290byBmYWlsZWQ7Cj4gKwkJZ290byBmYWlsZWRfcmVzZXJ2ZTsKPiAgIAl9Cj4gICAKPiAg IAllcnIgPSBhbWRncHVfYm9fcGluKCpibywgQU1ER1BVX0dFTV9ET01BSU5fR1RULCAmZndfbWNf YWRkcik7Cj4gICAJaWYgKGVycikgewo+IC0JCWFtZGdwdV9ib191bnJlc2VydmUoKmJvKTsKPiAt CQlhbWRncHVfYm9fdW5yZWYoYm8pOwo+ICAgCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkgRmly bXdhcmUgYnVmZmVyIHBpbiBmYWlsZWRcbiIsIGVycik7Cj4gLQkJZ290byBmYWlsZWQ7Cj4gKwkJ Z290byBmYWlsZWRfcGluOwo+ICAgCX0KPiAgIAo+ICAgCWVyciA9IGFtZGdwdV9ib19rbWFwKCpi bywgJmZ3X2J1Zl9wdHIpOwo+ICAgCWlmIChlcnIpIHsKPiAgIAkJZGV2X2VycihhZGV2LT5kZXYs ICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBrbWFwIGZhaWxlZFxuIiwgZXJyKTsKPiAtCQlhbWRncHVf Ym9fdW5waW4oKmJvKTsKPiAtCQlhbWRncHVfYm9fdW5yZXNlcnZlKCpibyk7Cj4gLQkJYW1kZ3B1 X2JvX3VucmVmKGJvKTsKPiAtCQlnb3RvIGZhaWxlZDsKPiArCQlnb3RvIGZhaWxlZF9rbWFwOwo+ ICAgCX0KPiAgIAo+ICAgCWFtZGdwdV9ib191bnJlc2VydmUoKmJvKTsKPiBAQCAtMjkxLDYgKzI4 NCwxMiBAQCBpbnQgYW1kZ3B1X3Vjb2RlX2luaXRfYm8oc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYpCj4gICAJCX0KPiAgIAl9Cj4gICAKPiArZmFpbGVkX2ttYXA6Cj4gKwlhbWRncHVfYm9fdW5w aW4oKmJvKTsKPiArZmFpbGVkX3BpbjoKPiArCWFtZGdwdV9ib191bnJlc2VydmUoKmJvKTsKPiAr ZmFpbGVkX3Jlc2VydmU6Cj4gKwlhbWRncHVfYm9fdW5yZWYoYm8pOwo+ICAgZmFpbGVkOgo+ICAg CWlmIChlcnIpCj4gICAJCWFkZXYtPmZpcm13YXJlLnNtdV9sb2FkID0gZmFsc2U7CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK