From: Vaishali Thakkar <vaishali.thakkar@oracle.com>
To: QLogic-Storage-Upstream@qlogic.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Use of schedule() function while holding a lock in ql4_nx.c
Date: Mon, 12 Sep 2016 10:49:03 +0530 [thread overview]
Message-ID: <57D63AC7.9010507@oracle.com> (raw)
Hello,
I was wondering about the call to schedule in function qla4_82xx_crb_win_lock for driver
drivers/scsi/qla4xxx/ql4_nx.c. It is called in 2 functions [qla4_82xx_rd_32 and
qla4_82xx_wr_32] while holding a write_lock_irqsave. Normally we avoid using sleeping
functions while holding a lock.
Is there some reason that I am overlooking? Why it is OK in this case? Are we using
schedule() here intentionally?
Thank you.
--
Vaishali
reply other threads:[~2016-09-12 5:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57D63AC7.9010507@oracle.com \
--to=vaishali.thakkar@oracle.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.