From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752532AbcIMGgj (ORCPT ); Tue, 13 Sep 2016 02:36:39 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:45741 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750940AbcIMGgh (ORCPT ); Tue, 13 Sep 2016 02:36:37 -0400 Subject: Re: [PATCH 1/3] tools include: Add uapi mman.h for each architecture To: Arnaldo Carvalho de Melo References: <1473684871-209320-1-git-send-email-wangnan0@huawei.com> <1473684871-209320-2-git-send-email-wangnan0@huawei.com> <20160912190742.GG4897@kernel.org> <20160912211520.GA10582@kernel.org> CC: , , From: "Wangnan (F)" Message-ID: <57D79E5C.9090200@huawei.com> Date: Tue, 13 Sep 2016 14:36:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160912211520.GA10582@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020205.57D79E6D.0137,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 496643d6f8a6c83a5ee0cdddfcb4f062 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/13 5:15, Arnaldo Carvalho de Melo wrote: > Em Mon, Sep 12, 2016 at 04:07:42PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Mon, Sep 12, 2016 at 12:54:29PM +0000, Wang Nan escreveu: >>> Some mmap related macros have different values for different >>> architectures. This patch introduces uapi mman.h for each >>> architectures. >>> >>> Three headers are cloned from kernel include to tools/include: >>> >>> tools/include/uapi/asm-generic/mman-common.h >>> tools/include/uapi/asm-generic/mman.h >>> tools/include/uapi/linux/mman.h >> Cool, the above was done as copies, why not the rest? IIRC you mentioned >> some reasoning behind that decision, but we need it spelled out here. >> >> For instance, I went on and look at arch/xtensa/include/uapi/asm/mman.h, >> and couldn't find why we shouldn't copy it just like the three files >> above. >> >> I'm looking now at why the build breaks in so many systems, first hunch >> is that bits/ part (the ones without the failure details probably have >> the same errors), alpine uses musl libc, but some that broke are glibc >> based. > So, please take a look at my perf/core branch, I applied 1/3 and 3/3, > but took a different path for 2/3, now it builds for all systems I have > containers for: Clever! The key is to use mman.h in uapi instead of . Code require these macros is coincidentally needn't the definition of functions like mmap, munmap and mprotect. Your solution is better. Thank you. > # time dm > 1 67.700 alpine:3.4: Ok > 2 23.565 android-ndk:r12b-arm: Ok > 3 67.823 archlinux:latest: Ok > 4 37.277 centos:5: Ok > 5 57.621 centos:6: Ok > 6 68.348 centos:7: Ok > 7 61.971 debian:7: Ok > 8 65.711 debian:8: Ok > 9 36.894 debian:experimental: Ok > 10 66.274 fedora:20: Ok > 11 70.054 fedora:21: Ok > 12 68.310 fedora:22: Ok > 13 68.033 fedora:23: Ok > 14 72.322 fedora:24: Ok > 15 29.529 fedora:24-x-ARC-uClibc: Ok > 16 77.458 fedora:rawhide: Ok > 17 80.110 mageia:5: Ok > 18 72.664 opensuse:13.2: Ok > 19 70.878 opensuse:42.1: Ok > 20 80.322 opensuse:tumbleweed: Ok > 21 62.237 ubuntu:12.04.5: Ok > 22 39.998 ubuntu:14.04: Ok > 23 69.383 ubuntu:14.04.4: Ok > 24 76.120 ubuntu:15.10: Ok > 25 69.668 ubuntu:16.04: Ok > 26 69.061 ubuntu:16.04-x-arm: Ok > 27 73.337 ubuntu:16.04-x-arm64: Ok > 28 77.061 ubuntu:16.04-x-powerpc64: Ok > 29 55.340 ubuntu:16.04-x-powerpc64el: Ok > 30 85.579 ubuntu:16.10: Ok > 31 59.645 ubuntu:16.10-x-s390: Ok > > real 32m59.385s > user 0m1.856s > sys 0m2.077s > # >